Page MenuHomePhorge
Feed Advanced Search

May 5 2021

machniak abandoned D2458: Reseller Stats UI.

Merged into dev/reseller.

May 5 2021, 2:24 PM
machniak committed rK5fa8cd3e7be0: Merge branch 'master' into dev/reseller (authored by machniak).
Merge branch 'master' into dev/reseller
May 5 2021, 2:11 PM
machniak committed rK2a5209079916: Reseller Stats UI (authored by machniak).
Reseller Stats UI
May 5 2021, 1:37 PM

May 4 2021

machniak requested changes to D2494: Laravel Passport support.
  1. See inline comments
  2. When logging into the user UI I see this in the log:
[2021-05-04 09:27:08] local.DEBUG: [SQL] select * from `oauth_clients` where `id` = ? limit 1 [array (
  0 => '1',
)]
[2021-05-04 09:27:08] local.DEBUG: [SQL] select * from `oauth_clients` where `id` = ? limit 1 [array (
  0 => '1',
)]

I.e. a duplicated query. Would be good to investigate why it is done twice.

  1. Token refresh does not work. A scenario:
    • set token_expiry_minutes = 1 minute,
    • log in to the UI, and wait a minute,
    • you'll see that the refresh request returns 401 Unauthorized.
    • in log: The resource owner or authorization server denied the request. {"exception":"[object] (League\\OAuth2\\Server\\Exception\\OAuthServerException(code: 9): The resource owner or authorization server denied the request. at /home/alec/repos/kolab/src/vendor/league/oauth2-server/src/Exception/OAuthServerException.php:243).
    • I guess you just have to add refresh_token to the request in line 166 of app.js.
  2. When runing Feature suite tests I got 3 errors:
1) Tests\Feature\Controller\PasswordResetTest::testPasswordResetValidInput
ErrorException: Undefined property: stdClass::$access_token
2) Tests\Feature\Controller\SignupTest::testSignupValidInput
ErrorException: Undefined property: stdClass::$access_token
3) Tests\Feature\Controller\SignupTest::testSignupGroupAccount
ErrorException: Undefined property: stdClass::$access_token
  1. Look like a few browser test failures are also related to Undefined property: stdClass::$access_token.
  2. We should think how deploy encryption keys across multiple hosts.
  3. Could https://github.com/laravel/passport/issues/379 be a problem for us in any way considering our future use of Passport?
May 4 2021, 11:50 AM
machniak requested review of D2512: Display existing entitlement cost instead of the SKU cost where appropriate.
May 4 2021, 10:18 AM

May 3 2021

machniak accepted D2410: rcube_imap_generic.php fixes.
May 3 2021, 10:08 AM

Apr 30 2021

machniak closed D2428: Signup Invitations.

Merged into dev/reseller.

Apr 30 2021, 11:21 AM
machniak committed rKe7a47d5d39d1: Signup Invitations (authored by machniak).
Signup Invitations
Apr 30 2021, 11:20 AM
machniak requested review of D2506: [Admin] Distribution lists UI.
Apr 30 2021, 11:10 AM

Apr 28 2021

machniak added inline comments to D2428: Signup Invitations.
Apr 28 2021, 11:28 AM

Apr 27 2021

machniak added a comment to D2428: Signup Invitations.

@mollekopf Ready for the final review.

Apr 27 2021, 12:45 PM
machniak updated the diff for D2428: Signup Invitations.
  • Add wording for the invitation email
Apr 27 2021, 12:44 PM
machniak planned changes to D2428: Signup Invitations.
Apr 27 2021, 12:35 PM
machniak updated the diff for D2428: Signup Invitations.

Fix

Apr 27 2021, 12:25 PM
machniak updated the diff for D2428: Signup Invitations.
  • Don't process csv if any email address is invalid
  • Cleanup
Apr 27 2021, 12:24 PM
machniak requested changes to D2494: Laravel Passport support.
Apr 27 2021, 10:55 AM
machniak retitled D2395: Localization with vue-i18n from [WIP] Localization with vue-i18n
Apr 27 2021, 9:41 AM

Apr 26 2021

machniak updated the diff for D2395: Localization with vue-i18n.
  • Small css improvements to the page menu
Apr 26 2021, 3:13 PM
machniak updated the diff for D2395: Localization with vue-i18n.
  • Store user language in a cookie, always load English
  • Small code cleanup
  • Update tests
  • Small linting fixes
  • Browser test for the language selector
Apr 26 2021, 2:22 PM
machniak committed rACf559eeb51d71: Fix regression in LDAP authentication (authored by machniak).
Fix regression in LDAP authentication
Apr 26 2021, 10:10 AM

Apr 23 2021

machniak updated the diff for D2395: Localization with vue-i18n.
  • Rebase
  • Improve language selector
  • Store UI localization in php file
  • Remove unused Laravel localization files
Apr 23 2021, 2:46 PM
machniak updated the diff for D2500: [User] Distribution lists UI.

Rebase

Apr 23 2021, 12:30 PM
machniak requested review of D2500: [User] Distribution lists UI.
Apr 23 2021, 12:29 PM
machniak requested changes to D2494: Laravel Passport support.

Just code review. I didn't look closer to this yet.

Apr 23 2021, 9:02 AM

Apr 21 2021

machniak added a comment to D2488: Implode doesn't work for DateTime objects.

I don't like that output format. How did you get to the problem? Maybe you should use Carbon objects instead.

Apr 21 2021, 7:08 PM
machniak committed rKbb367b9a0e38: Fix test regressions (authored by machniak).
Fix test regressions
Apr 21 2021, 1:00 PM
machniak committed rK627eb4f1844e: Fix phpstan errors (authored by machniak).
Fix phpstan errors
Apr 21 2021, 1:00 PM
machniak committed rK8e95b606b8d7: Fix wallet notice precision (authored by machniak).
Fix wallet notice precision
Apr 21 2021, 11:41 AM
machniak closed D2464: Fix wallet notice precision.
Apr 21 2021, 11:41 AM
machniak committed rK7e6b1576f5cf: [Meet] Fix video elements sizing bug (authored by machniak).
[Meet] Fix video elements sizing bug
Apr 21 2021, 11:41 AM
machniak closed D2470: [Meet] Fix video elements sizing bug.
Apr 21 2021, 11:41 AM
machniak committed rK525d8a74d97e: Use build year in the copyright footer (authored by machniak).
Use build year in the copyright footer
Apr 21 2021, 11:39 AM
machniak closed D2476: Use build year in the copyright footer.
Apr 21 2021, 11:39 AM
machniak committed rKce369e66b199: ux cleanup. move 'delete account' button to the top (authored by machniak).
ux cleanup. move 'delete account' button to the top
Apr 21 2021, 11:39 AM
machniak closed D1954: ux cleanup. move 'delete account' button to the top.
Apr 21 2021, 11:39 AM
machniak committed rK5e9dec8fad30: Remove "ON UPDATE" from expires_at column (authored by machniak).
Remove "ON UPDATE" from expires_at column
Apr 21 2021, 11:39 AM
machniak closed D2440: Remove "ON UPDATE" from expires_at column.
Apr 21 2021, 11:38 AM
machniak updated the diff for D2440: Remove "ON UPDATE" from expires_at column.
  • Use ALTER TABLE .. MODIFY
Apr 21 2021, 11:32 AM

Apr 19 2021

machniak updated the diff for D1954: ux cleanup. move 'delete account' button to the top.
  • Fix tests
  • Small color improvements
Apr 19 2021, 1:00 PM

Apr 16 2021

machniak committed rK78dd5aa5847b: Support X-Client-IP header (authored by machniak).
Support X-Client-IP header
Apr 16 2021, 2:29 PM
machniak updated the summary of D2395: Localization with vue-i18n.
Apr 16 2021, 1:17 PM
machniak updated the diff for D2395: Localization with vue-i18n.
  • Manu localization
  • FAQ localization
Apr 16 2021, 1:06 PM
machniak updated the diff for D2395: Localization with vue-i18n.
  • Hide the lang selector if there's only a single language available
Apr 16 2021, 9:27 AM

Apr 15 2021

machniak updated the diff for D2395: Localization with vue-i18n.
  • Upgrade to laravel-mix v6 (webpack v5) and other js dependencies
  • Don't preload English
  • Localization engine for theme files
  • Rebase
  • Improve language selector
Apr 15 2021, 3:28 PM
machniak retitled D2476: Use build year in the copyright footer from Use build year and configured company name in the copyright footer
Apr 15 2021, 11:42 AM
machniak updated the diff for D2476: Use build year in the copyright footer.
  • Don't use app.company.name in copyright footer
Apr 15 2021, 11:41 AM
machniak abandoned D2389: update copyright info.

Close in favor of D2476

Apr 15 2021, 10:53 AM
machniak requested review of D2476: Use build year in the copyright footer.
Apr 15 2021, 10:52 AM

Apr 14 2021

machniak added a comment to D2470: [Meet] Fix video elements sizing bug.

The main cause for the issue is the chat element that uses width: 30%, which causes the screen to be split not evenly (sometimes with 0.5px difference). offsetWidth is always rounded up to full pixels. So, when you divide that (0.5px bigger than in reality) width by the number of columns the sum of widthts of the participant boxes will be bigger than the real width of the container.

Apr 14 2021, 6:17 PM
machniak committed rK1335d6cf57ce: Remove dead code (authored by machniak).
Remove dead code
Apr 14 2021, 2:32 PM
machniak requested review of D2470: [Meet] Fix video elements sizing bug.
Apr 14 2021, 2:29 PM
machniak requested review of D2464: Fix wallet notice precision.
Apr 14 2021, 12:02 PM

Apr 13 2021

machniak requested review of D2458: Reseller Stats UI.
Apr 13 2021, 3:57 PM
machniak committed rRPK6204b43186e3: Fix compatibility with PHP 5.4 (authored by machniak).
Fix compatibility with PHP 5.4
Apr 13 2021, 8:43 AM

Apr 12 2021

machniak requested review of D2452: Tenant scope for CLI commands.
Apr 12 2021, 3:06 PM

Apr 9 2021

machniak requested review of D2446: Reseller comissioning system.
Apr 9 2021, 2:03 PM
machniak requested review of D2440: Remove "ON UPDATE" from expires_at column.
Apr 9 2021, 9:34 AM

Apr 8 2021

machniak committed rK0b12e0a6b939: Make doctrine/dbal a production requirement (authored by machniak).
Make doctrine/dbal a production requirement
Apr 8 2021, 3:36 PM
machniak committed rK5935a9df4fe8: Store request headers with signup codes (authored by machniak).
Store request headers with signup codes
Apr 8 2021, 3:13 PM
machniak requested changes to D1954: ux cleanup. move 'delete account' button to the top.

Browser tests need to be updated.

Apr 8 2021, 12:45 PM
machniak committed rK208e09e04570: Remove unused EntitlementsController (authored by machniak).
Remove unused EntitlementsController
Apr 8 2021, 12:41 PM
machniak committed rK8ac7ed94dad1: Reseller UI basics completed, with tests (authored by machniak).
Reseller UI basics completed, with tests
Apr 8 2021, 12:41 PM

Apr 7 2021

machniak committed rK607ee93e88e7: Reseller: Domains and Discounts controller (authored by machniak).
Reseller: Domains and Discounts controller
Apr 7 2021, 10:37 AM

Apr 6 2021

machniak updated the diff for D2422: Signup code refactoring.
  • Add reverse migration, document more SignupCode properties
Apr 6 2021, 12:50 PM
machniak accepted D2383: Convert to foreign currencies using openexchangerates.org.

I was expecting a single whitelist. We don't really need two, do we?

Apr 6 2021, 11:56 AM
machniak requested changes to D2137: add charge period to transactions.
Apr 6 2021, 9:16 AM

Apr 2 2021

machniak updated the diff for D2428: Signup Invitations.
  • Fix
Apr 2 2021, 12:05 PM
machniak updated the diff for D2428: Signup Invitations.
  • Cleanup
Apr 2 2021, 12:04 PM
machniak requested review of D2428: Signup Invitations.
Apr 2 2021, 10:16 AM

Mar 31 2021

machniak planned changes to D2422: Signup code refactoring.
Mar 31 2021, 10:07 AM

Mar 26 2021

machniak committed rKc4bd4ead4b10: Make User::canRead() work with resellers (authored by machniak).
Make User::canRead() work with resellers
Mar 26 2021, 9:41 AM

Mar 25 2021

machniak updated the diff for D2422: Signup code refactoring.
  • Simplify
Mar 25 2021, 4:21 PM
machniak retitled D2422: Signup code refactoring from Throttling signups using an IP address
Mar 25 2021, 4:15 PM
machniak updated the diff for D2422: Signup code refactoring.
  • Replace pack() with hex2bin()
  • SignupCode refactor
Mar 25 2021, 4:15 PM
machniak requested review of D2422: Signup code refactoring.
Mar 25 2021, 10:00 AM
machniak requested changes to D2383: Convert to foreign currencies using openexchangerates.org.
Mar 25 2021, 9:24 AM

Mar 24 2021

machniak committed rK9617696a57c1: Reseller: Access to users/domains in UI (authored by machniak).
Reseller: Access to users/domains in UI
Mar 24 2021, 3:17 PM
machniak accepted D2239: New Payment dialog structure.
Mar 24 2021, 1:43 PM
machniak committed rK6cfac91269ca: Re-add lost withEnvTenant() and withUserTenant() macros (authored by machniak).
Re-add lost withEnvTenant() and withUserTenant() macros
Mar 24 2021, 1:07 PM
machniak committed rK4af1eef6dd8e: Merge branch 'dev/reseller' of ssh://git.kolab.org/source/kolab into… (authored by machniak).
Merge branch 'dev/reseller' of ssh://git.kolab.org/source/kolab into…
Mar 24 2021, 12:06 PM
machniak committed rK114fa81adeeb: Fix rebase regressions (authored by machniak).
Fix rebase regressions
Mar 24 2021, 12:06 PM
machniak committed rK6389c0784186: Remove redundant code that sets tenant_id on signup (authored by machniak).
Remove redundant code that sets tenant_id on signup
Mar 24 2021, 12:06 PM
machniak committed rK527617296431: Fix error found by phpstan (authored by machniak).
Fix error found by phpstan
Mar 24 2021, 12:06 PM
machniak committed rK792299bd1512: withEnvTenant and withUserTenant macros (authored by machniak).
withEnvTenant and withUserTenant macros
Mar 24 2021, 12:06 PM
machniak committed rKd5d6073547eb: Update ObjectDelete and ObjectUpdate commands, and move the dangerous test to… (authored by vanmeeuwen).
Update ObjectDelete and ObjectUpdate commands, and move the dangerous test to…
Mar 24 2021, 12:06 PM
machniak committed rK538aa48b53c7: These are just completely not needed, since there are no direct effects to… (authored by vanmeeuwen).
These are just completely not needed, since there are no direct effects to…
Mar 24 2021, 12:06 PM
machniak committed rK719f30bcea4d: Transfer commit (authored by vanmeeuwen).
Transfer commit
Mar 24 2021, 12:06 PM
machniak committed rK84c22530a67d: scalpel:discount:merge -> discount:merge (authored by vanmeeuwen).
scalpel:discount:merge -> discount:merge
Mar 24 2021, 12:06 PM
machniak committed rK27c01203e01c: More complete commands, show-case dangerous delete command in scalpel (authored by vanmeeuwen).
More complete commands, show-case dangerous delete command in scalpel
Mar 24 2021, 12:06 PM
machniak committed rK64d27ce00896: Some additional command logic (authored by vanmeeuwen).
Some additional command logic
Mar 24 2021, 12:06 PM
machniak committed rK75be665b70c7: Revert "Add degraded status to user:status command" (authored by machniak).
Revert "Add degraded status to user:status command"
Mar 24 2021, 12:06 PM
machniak added a reverting change for rKc441d3ca2090: Add degraded status to user:status command: rK75be665b70c7: Revert "Add degraded status to user:status command".
Mar 24 2021, 12:06 PM
machniak committed rK885509af3077: Add degraded status to user:status command (authored by machniak).
Add degraded status to user:status command
Mar 24 2021, 12:06 PM
machniak committed rKf29193ac9e00: Add some reseller tests (authored by machniak).
Add some reseller tests
Mar 24 2021, 12:06 PM
machniak committed rK515f066c5090: Reseller app engine (authored by machniak).
Reseller app engine
Mar 24 2021, 12:06 PM
machniak committed rKd751b400bd72: More changes for the work in progress (authored by vanmeeuwen).
More changes for the work in progress
Mar 24 2021, 12:06 PM
machniak committed rKc39bcc2cf670: Rebase on master (authored by vanmeeuwen).
Rebase on master
Mar 24 2021, 12:06 PM
machniak committed rKd70ff989c5fc: Make Reseller/UsersController more complete (authored by machniak).
Make Reseller/UsersController more complete
Mar 24 2021, 12:06 PM
machniak committed rK0880a58061ee: Remove redundant code that sets tenant_id on signup (authored by machniak).
Remove redundant code that sets tenant_id on signup
Mar 24 2021, 12:06 PM
machniak committed rKbead23e3acef: Add a domain that is for the other tenant (authored by vanmeeuwen).
Add a domain that is for the other tenant
Mar 24 2021, 12:06 PM