Page MenuHomekolab.org

[Admin] Distribution lists UI
ClosedPublic

Authored by machniak on Fri, Apr 30, 11:10 AM.

Details

Reviewers
mollekopf
Group Reviewers
Restricted Project
Commits
rKe11caabd056a: [Admin] Distribution lists UI
Summary

Add UI elements for admins and make LDAP backend to reflect group suspended state

Test Plan

./phpunit

Diff Detail

Repository
rK kolab
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

machniak created this revision.Fri, Apr 30, 11:10 AM
machniak requested review of this revision.Fri, Apr 30, 11:10 AM

I thought we agreed on calling this Distlists instead of Groups (to leave "groups" as a more generic term for another feature), other than that this looks ok to me.

src/routes/api.php
157

Wasn't this supposed to become distlists or so instead of groups?

mollekopf requested changes to this revision.Thu, May 6, 3:36 PM
This revision now requires changes to proceed.Thu, May 6, 3:36 PM
machniak added inline comments.
src/routes/api.php
157

Well, It was groups before and it is internally 'groups' still. I hesitate to change everything to distlists now. It is 'distlist' in the UI, though.

So, we can change everything to 'distlist' later, but I'm not sure that was Jeroen's intention. I remember it was his decission to make it 'groups' (and I asked that it might not be the best name then) when it was implemented in the first place. It looks that he changed his mind, but I don't know if it includes internals.

One probem I see is existence of both App\Handlers\Group and App\Handlers\Distlist (see D2500) but this can be resolved by renaming the later to AllowDistlist or sth like that.

So, @vanmeeuwen should I rename everything to distlist including the DB table name? Anyway, I think this can be done after merging these diffs.

This revision was not accepted when it landed; it landed in state Needs Revision.Fri, May 7, 10:57 AM
This revision was automatically updated to reflect the committed changes.