Add UI elements for admins and make LDAP backend to reflect group suspended state
Details
- Reviewers
mollekopf - Group Reviewers
Restricted Project - Commits
- rKe11caabd056a: [Admin] Distribution lists UI
./phpunit
Diff Detail
- Repository
- rK kolab
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
I thought we agreed on calling this Distlists instead of Groups (to leave "groups" as a more generic term for another feature), other than that this looks ok to me.
src/routes/api.php | ||
---|---|---|
157 | Wasn't this supposed to become distlists or so instead of groups? |
src/routes/api.php | ||
---|---|---|
157 | Well, It was groups before and it is internally 'groups' still. I hesitate to change everything to distlists now. It is 'distlist' in the UI, though. So, we can change everything to 'distlist' later, but I'm not sure that was Jeroen's intention. I remember it was his decission to make it 'groups' (and I asked that it might not be the best name then) when it was implemented in the first place. It looks that he changed his mind, but I don't know if it includes internals. One probem I see is existence of both App\Handlers\Group and App\Handlers\Distlist (see D2500) but this can be resolved by renaming the later to AllowDistlist or sth like that. So, @vanmeeuwen should I rename everything to distlist including the DB table name? Anyway, I think this can be done after merging these diffs. |