Page MenuHomekolab.org

Remove "ON UPDATE" from expires_at column
ClosedPublic

Authored by machniak on Apr 9 2021, 9:34 AM.

Details

Reviewers
mollekopf
Group Reviewers
Restricted Project
Commits
rK5e9dec8fad30: Remove "ON UPDATE" from expires_at column
Test Plan

./phpunit

Diff Detail

Repository
rK kolab
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

machniak created this revision.Apr 9 2021, 9:34 AM
machniak requested review of this revision.Apr 9 2021, 9:34 AM
mollekopf accepted this revision.Apr 20 2021, 3:21 PM
mollekopf added a subscriber: mollekopf.

Instead of CHANGE you could also just use MODIFY I think (since we're not renaming columns):

ALTER TABLE `signup_codes` MODIFY `expires_at` TIMESTAMP NOT NULL DEFAULT CURRENT_TIMESTAMP

The change looks good otherwise, so you can ship it after this fix (or ship directly, as this will work too.).

This revision is now accepted and ready to land.Apr 20 2021, 3:21 PM
machniak updated this revision to Diff 6925.Apr 21 2021, 11:32 AM
  • Use ALTER TABLE .. MODIFY
This revision was automatically updated to reflect the committed changes.