Page MenuHomePhorge

Remove "ON UPDATE" from expires_at column
ClosedPublic

Authored by machniak on Apr 9 2021, 9:34 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Mar 23, 3:30 PM
Unknown Object (File)
Thu, Feb 29, 4:03 PM
Unknown Object (File)
Feb 25 2024, 3:29 PM
Unknown Object (File)
Jan 25 2024, 4:59 AM
Unknown Object (File)
Jan 18 2024, 12:19 PM
Unknown Object (File)
Jan 17 2024, 3:34 AM
Unknown Object (File)
Jan 9 2024, 3:49 PM
Unknown Object (File)
Dec 30 2023, 10:57 AM
Subscribers
Restricted Project

Details

Reviewers
mollekopf
Group Reviewers
Restricted Project
Commits
rK5e9dec8fad30: Remove "ON UPDATE" from expires_at column
Test Plan

./phpunit

Diff Detail

Repository
rK kolab
Branch
dev/expires-at-col-fix
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 33850
Build 13414: arc lint + arc unit

Event Timeline

mollekopf subscribed.

Instead of CHANGE you could also just use MODIFY I think (since we're not renaming columns):

ALTER TABLE `signup_codes` MODIFY `expires_at` TIMESTAMP NOT NULL DEFAULT CURRENT_TIMESTAMP

The change looks good otherwise, so you can ship it after this fix (or ship directly, as this will work too.).

This revision is now accepted and ready to land.Apr 20 2021, 3:21 PM
  • Use ALTER TABLE .. MODIFY
This revision was automatically updated to reflect the committed changes.