Page MenuHomekolab.org

Tenant scope for CLI commands
ClosedPublic

Authored by machniak on Apr 12 2021, 3:06 PM.

Details

Reviewers
mollekopf
Group Reviewers
Restricted Project
Commits
rK6aa312a4a5db: Tenant scope for CLI commands
Summary

T421559

Test Plan

./phpunit

Diff Detail

Repository
rK kolab
Branch
dev/cli-tenant2
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 34336
Build 13726: arc lint + arc unit

Event Timeline

machniak requested review of this revision.Apr 12 2021, 3:06 PM
machniak created this revision.
machniak updated this revision to Diff 7222.Jun 1 2021, 12:41 PM
  • Couple of fixes, tenant-condition for wallets
machniak updated this revision to Diff 7228.Jun 1 2021, 2:06 PM
  • Simplify/Unify
machniak updated this revision to Diff 7234.Jun 1 2021, 3:26 PM
  • Simplify again
machniak retitled this revision from [WIP] Tenant scope for CLI commands to Tenant scope for CLI commands.Jun 1 2021, 3:26 PM
mollekopf accepted this revision.Jun 4 2021, 12:19 PM
mollekopf added a subscriber: mollekopf.

I'm wondering whether there isn't a more elegant solution to replacing all queries with a custom function that everything has to go through, so that e.g. a \App\Wallet::find or \App\Wallet::all would automatically take the tentant into account.

That said, this seems otherwise reasonable, so go ahead with it.
Please not I'm not fully on top of the dev/reseller branch, so I just looked it over for obvious mistakes.

This revision is now accepted and ready to land.Jun 4 2021, 12:19 PM
machniak closed this revision.Jun 4 2021, 12:32 PM

Merged into dev/reseller.