Page MenuHomekolab.org

Reseller comissioning system
ClosedPublic

Authored by machniak on Apr 9 2021, 2:03 PM.

Details

Reviewers
vanmeeuwen
Group Reviewers
Restricted Project
Commits
rK2de8edd9f18b: Reseller comissioning system

Diff Detail

Repository
rK kolab
Branch
dev/reseller-comissioning
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 34156
Build 13612: arc lint + arc unit

Event Timeline

machniak requested review of this revision.Apr 9 2021, 2:03 PM
machniak created this revision.
machniak retitled this revision from Reseller comissioning system to [WIP] Reseller comissioning system.May 12 2021, 11:37 AM
machniak edited the summary of this revision. (Show Details)
machniak updated this revision to Diff 7078.May 12 2021, 2:39 PM
  • Migration fixes, tests fixes, added some simple tests
machniak updated this revision to Diff 7090.May 13 2021, 3:29 PM
  • Add tests
  • Debit reseller's wallet on user deletion (for the negative balance value)
  • Credit/debit reseller's wallet on Penalize/Award action
machniak retitled this revision from [WIP] Reseller comissioning system to Reseller comissioning system.May 13 2021, 3:33 PM
machniak edited the summary of this revision. (Show Details)
vanmeeuwen requested changes to this revision.May 14 2021, 5:20 PM
vanmeeuwen added a subscriber: vanmeeuwen.

Didn't go through the tests yet.

src/app/Http/Controllers/API/V4/Admin/WalletsController.php
103

Perhaps not the wording we'll want to be using under each of the circumstances that create a positive or negative charge.

We should elaborate during the next standup perhaps.

src/app/PackageSku.php
44

It was implemented as a potential future feature, where despite the sku costs and free units, the package cost could still be set separately.

src/app/Providers/PaymentProvider.php
264

At the very least there's a spelling error in the word "commission", but since its also a FIXME, that's not even what I seek to point out.

This revision now requires changes to proceed.May 14 2021, 5:20 PM
vanmeeuwen accepted this revision.May 18 2021, 3:12 PM
This revision is now accepted and ready to land.May 18 2021, 3:12 PM
machniak closed this revision.May 18 2021, 4:06 PM

Merged into dev/reseller