Details
Details
- Reviewers
vanmeeuwen - Group Reviewers
Restricted Project - Commits
- rK2de8edd9f18b: Reseller comissioning system
Diff Detail
Diff Detail
- Repository
- rK kolab
- Branch
- dev/reseller-comissioning
- Lint
No Lint Coverage - Unit
No Test Coverage - Build Status
Buildable 34144 Build 13600: arc lint + arc unit
Event Timeline
Comment Actions
- Add tests
- Debit reseller's wallet on user deletion (for the negative balance value)
- Credit/debit reseller's wallet on Penalize/Award action
Comment Actions
Didn't go through the tests yet.
src/app/Http/Controllers/API/V4/Admin/WalletsController.php | ||
---|---|---|
103 ↗ | (On Diff #7090) | Perhaps not the wording we'll want to be using under each of the circumstances that create a positive or negative charge. We should elaborate during the next standup perhaps. |
src/app/PackageSku.php | ||
44 ↗ | (On Diff #7090) | It was implemented as a potential future feature, where despite the sku costs and free units, the package cost could still be set separately. |
src/app/Providers/PaymentProvider.php | ||
264 | At the very least there's a spelling error in the word "commission", but since its also a FIXME, that's not even what I seek to point out. |