Page MenuHomePhorge
Feed Search

Jun 12 2021

machniak updated the diff for D2593: Update to Openvidu-browser 2.18.
  • Disable jsnlog's error handlers added in OpenVidu 2.18
Jun 12 2021, 6:19 AM

Jun 11 2021

machniak requested review of D2593: Update to Openvidu-browser 2.18.
Jun 11 2021, 12:12 PM

Jun 10 2021

machniak requested review of D2587: Improve wallet() methods accuracy.
Jun 10 2021, 1:04 PM
machniak updated the diff for D2581: UI localization.
  • Add test for localization in getWalletNotice()
Jun 10 2021, 8:54 AM

Jun 9 2021

machniak requested review of D2581: UI localization.
Jun 9 2021, 12:34 PM

Jun 8 2021

machniak committed rRPK5a94fd8bc6e6: 2FA: Add missing login_lc config handling.
Jun 8 2021, 8:38 AM

Jun 4 2021

machniak requested review of D2572: Resellers - all changes.
Jun 4 2021, 1:03 PM
machniak committed rKfad0f675055c: Fix phpstan errors.
Jun 4 2021, 12:08 PM
machniak committed rK5925612aafcb: Fix tests regressions.
Jun 4 2021, 11:55 AM
machniak committed rKf336df8e9d45: Merge branch 'master' into dev/reseller.
Jun 4 2021, 11:55 AM
machniak closed D2452: Tenant scope for CLI commands.

Merged into dev/reseller.

Jun 4 2021, 10:32 AM
machniak committed rK6aa312a4a5db: Tenant scope for CLI commands.
Jun 4 2021, 10:31 AM
machniak committed rK5d98fbe82027: Require PHP>=7.3 and Guzzle Http Client.
Jun 4 2021, 10:26 AM

Jun 1 2021

machniak retitled D2452: Tenant scope for CLI commands from [WIP] Tenant scope for CLI commands
Jun 1 2021, 1:26 PM
machniak updated the diff for D2452: Tenant scope for CLI commands.
  • Simplify again
Jun 1 2021, 1:26 PM
machniak updated the diff for D2452: Tenant scope for CLI commands.
  • Simplify/Unify
Jun 1 2021, 12:06 PM
machniak updated the diff for D2452: Tenant scope for CLI commands.
  • Couple of fixes, tenant-condition for wallets
Jun 1 2021, 10:41 AM
machniak committed rK021a0daf6855: Merge branch 'master' into dev/reseller.
Jun 1 2021, 10:06 AM
machniak committed rKacf48440adde: UI localization (partial).
Jun 1 2021, 10:01 AM
machniak closed D2518: UI localization (partial).
Jun 1 2021, 10:01 AM
machniak committed rKa0069a7d5489: Introduce a unified mechanism for permissions checking in the UI.
Jun 1 2021, 10:01 AM
machniak closed D2524: Introduce a unified mechanism for permissions checking in the UI.
Jun 1 2021, 10:01 AM
machniak committed rKb6cc7fc764ca: [Reseller] Wallet page.
Jun 1 2021, 9:58 AM
machniak committed rK788c62c51e82: Add tenant() method to Domain, Group and Discount.
Jun 1 2021, 9:02 AM

May 27 2021

machniak committed rK35036d332a8f: Fix memory issue in wallet:charge command.
May 27 2021, 8:13 AM
machniak closed D2560: Fix memory issue in wallet:charge command.
May 27 2021, 8:13 AM
machniak committed rKeaac9aa08b9b: Per-tenant domains visibility.
May 27 2021, 7:35 AM
machniak added a comment to D2494: Laravel Passport support.

To sum up the current state:

  1. All tests pass!
  2. Tokens refresh request is fast now, but /auth/login is still 0.3-0.4 sec. I didn't investigate how much of that is passport.
  3. We should probably add some code to Kernel as in https://laravel.com/docs/6.x/passport#purging-tokens
  4. @vanmeeuwen, should take a look at this regarding deployment of the oauth keys and client secret (and ./artisan passport:keys --force) - we need the same keys on every Kolab4 host.
May 27 2021, 7:26 AM
machniak added a comment to D2566: Log sql query execution time.

On the other hand, maybe %dms format would be better for query time.

May 27 2021, 7:05 AM
machniak accepted D2566: Log sql query execution time.
May 27 2021, 5:55 AM

May 26 2021

machniak updated the diff for D2554: Add PGP keys generator.
  • Add exportPublicKey() use
May 26 2021, 2:13 PM
machniak updated the diff for D2554: Add PGP keys generator.
  • Use Laravel's Storage functionality
May 26 2021, 1:01 PM

May 25 2021

machniak updated the diff for D2554: Add PGP keys generator.
  • Switch new keypair algorithms to RSA
May 25 2021, 11:11 AM
machniak requested review of D2560: Fix memory issue in wallet:charge command.
May 25 2021, 8:02 AM
machniak requested review of D2554: Add PGP keys generator.
May 25 2021, 7:26 AM

May 21 2021

machniak added a comment to D2494: Laravel Passport support.

I did another run of tests and got the same result as above. I.e. I run vendor/bin/phpunit tests/Browser/Admin twice on master and all is green. Then I run the same on this diff and I got three tests failing. Looks like the problem is with refreshing the token. I see this in console dump:

https:\/\/admin.alec.dev.kolab.io\/api\/auth\/info?refresh=1 - Failed to load resource: the server responded with a status of 401 ()

I see C: POST https://admin.alec.dev.kolab.io/api/auth/info?refresh=1 [5M]: 0.0055 sec in the log and this is strange because it's too fast and there are no sql queries for this request logged.

May 21 2021, 9:19 AM

May 20 2021

machniak committed rSd734f252b37d: Fix fatal error introduced in the last commit.
May 20 2021, 12:24 PM
machniak committed rS15b11cf6a2df: Fix so Bcc header is not removed from mail stored in Sent folder.
May 20 2021, 12:19 PM
machniak requested changes to D2494: Laravel Passport support.

phpstan errors:

Line   app/Http/Controllers/API/AuthController.php                  
------ ------------------------------------------------------------- 
 157    Access to an undefined property object::$error_description.  
------ -------------------------------------------------------------
May 20 2021, 10:45 AM
machniak requested review of D2536: [Reseller] Wallet page.
May 20 2021, 7:48 AM

May 19 2021

machniak committed rKcf684339a3ca: Merge branch 'master' into dev/reseller.
May 19 2021, 10:13 AM
machniak requested changes to D2494: Laravel Passport support.
There was 1 error:
May 19 2021, 8:39 AM

May 18 2021

machniak abandoned D2377: [WIP] Resellers: Signup with approval.
May 18 2021, 2:12 PM
machniak abandoned D1453: small layout ui polish for user profile, user info, user list and dashboard.
May 18 2021, 2:08 PM
machniak closed D2446: Reseller comissioning system.

Merged into dev/reseller

May 18 2021, 2:06 PM
machniak committed rK2de8edd9f18b: Reseller comissioning system.
May 18 2021, 2:05 PM
machniak requested review of D2530: Per-tenant domains visibility.
May 18 2021, 11:11 AM

May 14 2021

machniak requested review of D2524: Introduce a unified mechanism for permissions checking in the UI.
May 14 2021, 11:36 AM

May 13 2021

machniak retitled D2446: Reseller comissioning system from [WIP] Reseller comissioning system
May 13 2021, 1:33 PM
machniak updated the diff for D2446: Reseller comissioning system.
  • Add tests
  • Debit reseller's wallet on user deletion (for the negative balance value)
  • Credit/debit reseller's wallet on Penalize/Award action
May 13 2021, 1:29 PM

May 12 2021

machniak updated the diff for D2446: Reseller comissioning system.
  • Migration fixes, tests fixes, added some simple tests
May 12 2021, 12:39 PM
machniak retitled D2446: Reseller comissioning system from Reseller comissioning system to [WIP] Reseller comissioning system.
May 12 2021, 9:37 AM

May 11 2021

machniak updated the diff for D2446: Reseller comissioning system.

Rebase

May 11 2021, 1:20 PM
machniak updated the diff for D2446: Reseller comissioning system.

Rebase

May 11 2021, 1:19 PM
machniak requested review of D2518: UI localization (partial).
May 11 2021, 11:31 AM

May 8 2021

machniak committed rK6dfd438618a0: Use @babel/eslint-parser, update eslint, fix some linting issues.
May 8 2021, 9:39 AM

May 7 2021

machniak committed rKf7fb3606a43e: Ignore phpstan error.
May 7 2021, 1:39 PM
machniak committed rK36b8497b2f4b: Distlists/Groups vs Resellers.
May 7 2021, 1:39 PM
machniak committed rK6d58303ab1ac: Fix phpstan errors.
May 7 2021, 1:39 PM
machniak committed rK8e4d64aeb1d3: Merge branch 'master' into dev/reseller.
May 7 2021, 1:39 PM
machniak committed rK1f18551de62a: Cleanup phpstan config.
May 7 2021, 11:00 AM
machniak committed rKaddb347dac2a: Move some code from webpack config to the before.php script.
May 7 2021, 11:00 AM
machniak committed rKb28c33417f00: Fix test regressions.
May 7 2021, 10:13 AM
machniak committed rK18a7cd7dbd77: Localization with vue-i18n.
May 7 2021, 10:13 AM
machniak closed D2395: Localization with vue-i18n.
May 7 2021, 10:13 AM
machniak committed rKe11caabd056a: [Admin] Distribution lists UI.
May 7 2021, 8:57 AM
machniak closed D2506: [Admin] Distribution lists UI.
May 7 2021, 8:57 AM
machniak committed rK365f9e9602b9: [User] Distribution lists UI.
May 7 2021, 8:57 AM
machniak closed D2500: [User] Distribution lists UI.
May 7 2021, 8:57 AM
machniak committed rK757939464319: Display existing entitlement cost instead of the SKU cost where appropriate.
May 7 2021, 7:53 AM
machniak closed D2512: Display existing entitlement cost instead of the SKU cost where appropriate.
May 7 2021, 7:52 AM
machniak updated subscribers of D2506: [Admin] Distribution lists UI.
May 7 2021, 6:55 AM

May 5 2021

machniak abandoned D2458: Reseller Stats UI.

Merged into dev/reseller.

May 5 2021, 12:24 PM
machniak committed rK5fa8cd3e7be0: Merge branch 'master' into dev/reseller.
May 5 2021, 12:11 PM
machniak committed rK2a5209079916: Reseller Stats UI.
May 5 2021, 11:37 AM

May 4 2021

machniak requested changes to D2494: Laravel Passport support.
  1. See inline comments
  2. When logging into the user UI I see this in the log:
[2021-05-04 09:27:08] local.DEBUG: [SQL] select * from `oauth_clients` where `id` = ? limit 1 [array (
  0 => '1',
)]
[2021-05-04 09:27:08] local.DEBUG: [SQL] select * from `oauth_clients` where `id` = ? limit 1 [array (
  0 => '1',
)]

I.e. a duplicated query. Would be good to investigate why it is done twice.

  1. Token refresh does not work. A scenario:
    • set token_expiry_minutes = 1 minute,
    • log in to the UI, and wait a minute,
    • you'll see that the refresh request returns 401 Unauthorized.
    • in log: The resource owner or authorization server denied the request. {"exception":"[object] (League\\OAuth2\\Server\\Exception\\OAuthServerException(code: 9): The resource owner or authorization server denied the request. at /home/alec/repos/kolab/src/vendor/league/oauth2-server/src/Exception/OAuthServerException.php:243).
    • I guess you just have to add refresh_token to the request in line 166 of app.js.
  2. When runing Feature suite tests I got 3 errors:
1) Tests\Feature\Controller\PasswordResetTest::testPasswordResetValidInput
ErrorException: Undefined property: stdClass::$access_token
2) Tests\Feature\Controller\SignupTest::testSignupValidInput
ErrorException: Undefined property: stdClass::$access_token
3) Tests\Feature\Controller\SignupTest::testSignupGroupAccount
ErrorException: Undefined property: stdClass::$access_token
  1. Look like a few browser test failures are also related to Undefined property: stdClass::$access_token.
  2. We should think how deploy encryption keys across multiple hosts.
  3. Could https://github.com/laravel/passport/issues/379 be a problem for us in any way considering our future use of Passport?
May 4 2021, 9:50 AM
machniak requested review of D2512: Display existing entitlement cost instead of the SKU cost where appropriate.
May 4 2021, 8:18 AM

May 3 2021

machniak accepted D2410: rcube_imap_generic.php fixes.
May 3 2021, 8:08 AM

Apr 30 2021

machniak closed D2428: Signup Invitations.

Merged into dev/reseller.

Apr 30 2021, 9:21 AM
machniak committed rKe7a47d5d39d1: Signup Invitations.
Apr 30 2021, 9:20 AM
machniak requested review of D2506: [Admin] Distribution lists UI.
Apr 30 2021, 9:10 AM

Apr 28 2021

machniak added inline comments to D2428: Signup Invitations.
Apr 28 2021, 9:28 AM

Apr 27 2021

machniak added a comment to D2428: Signup Invitations.

@mollekopf Ready for the final review.

Apr 27 2021, 10:45 AM
machniak updated the diff for D2428: Signup Invitations.
  • Add wording for the invitation email
Apr 27 2021, 10:44 AM
machniak planned changes to D2428: Signup Invitations.
Apr 27 2021, 10:35 AM
machniak updated the diff for D2428: Signup Invitations.

Fix

Apr 27 2021, 10:25 AM
machniak updated the diff for D2428: Signup Invitations.
  • Don't process csv if any email address is invalid
  • Cleanup
Apr 27 2021, 10:24 AM
machniak requested changes to D2494: Laravel Passport support.
Apr 27 2021, 8:55 AM
machniak retitled D2395: Localization with vue-i18n from [WIP] Localization with vue-i18n
Apr 27 2021, 7:41 AM

Apr 26 2021

machniak updated the diff for D2395: Localization with vue-i18n.
  • Small css improvements to the page menu
Apr 26 2021, 1:13 PM
machniak updated the diff for D2395: Localization with vue-i18n.
  • Store user language in a cookie, always load English
  • Small code cleanup
  • Update tests
  • Small linting fixes
  • Browser test for the language selector
Apr 26 2021, 12:22 PM
machniak committed rACf559eeb51d71: Fix regression in LDAP authentication.
Apr 26 2021, 8:10 AM

Apr 23 2021

machniak updated the diff for D2395: Localization with vue-i18n.
  • Rebase
  • Improve language selector
  • Store UI localization in php file
  • Remove unused Laravel localization files
Apr 23 2021, 12:46 PM
machniak updated the diff for D2500: [User] Distribution lists UI.

Rebase

Apr 23 2021, 10:30 AM
machniak requested review of D2500: [User] Distribution lists UI.
Apr 23 2021, 10:29 AM
machniak requested changes to D2494: Laravel Passport support.

Just code review. I didn't look closer to this yet.

Apr 23 2021, 7:02 AM

Apr 21 2021

machniak added a comment to D2488: Implode doesn't work for DateTime objects.

I don't like that output format. How did you get to the problem? Maybe you should use Carbon objects instead.

Apr 21 2021, 5:08 PM
machniak committed rKbb367b9a0e38: Fix test regressions.
Apr 21 2021, 11:00 AM
machniak committed rK627eb4f1844e: Fix phpstan errors.
Apr 21 2021, 11:00 AM
machniak committed rK8e95b606b8d7: Fix wallet notice precision.
Apr 21 2021, 9:41 AM