Page MenuHomekolab.org

small layout ui polish for user profile, user info, user list and dashboard
Needs ReviewPublic

Authored by bohlender on Jul 23 2020, 10:28 AM.

Details

Reviewers
None
Group Reviewers
Restricted Project
Summary

small ui polish for user list and view

improve dashboard layout

Diff Detail

Repository
rK kolab
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 30067
Build 11197: arc lint + arc unit

Event Timeline

bohlender requested review of this revision.Jul 23 2020, 10:29 AM
bohlender created this revision.
machniak added a reviewer: Restricted Project.Jul 27 2020, 8:55 AM
machniak added subscribers: Restricted Project, machniak.


I don't like any of it.

  1. I think that the dashboard should be pretty, these buttons do not look pretty.
  2. "Payment" -> "Payments" (btw, the negative balance badge looks not in place).
  3. I also do not like buttons in the Profile page. I understand that Delete Account button maybe should not be close to the Submit button, but how you did it the buttons are way too much separated. It looks just wrong on a wide screen.
  4. Why "Create new user" needs to be green? Is there some rule for that?
bohlender added a comment.EditedJul 27 2020, 10:07 AM


I don't like any of it.

  1. I think that the dashboard should be pretty, these buttons do not look pretty.

It looks better once we include a link to webmail.


  1. "Payment" -> "Payments" (btw, the negative balance badge looks not in place).

What is behind the button is things that have to do with payment which includes a history of payments and the possibility for future payments.
So I think that "payment" is the correct wording as it describes the category of things. Also a single payment is less scary than multiple payments.

I am not sure what you mean by not in place. As in not pixel perfectly aligned or does it just feel wrong?

  1. I also do not like buttons in the Profile page. I understand that Delete Account button maybe should not be close to the Submit button, but how you did it the buttons are way too much separated. It looks just wrong on a wide screen.

Would this be fixed by increasing the right and left margins of the whole window on wide screen displays? It looks fine on my wide screen view. Can you give me a screenshot of your widescreen view ?

The "OK" / "Submit" button should always be the last button in reading direction so bottom-right.
It would also work if it was the last button with nothing besides it so it can be placed bottom-left.

  1. Why "Create new user" needs to be green? Is there some rule for that?

The idea is to use green for positive / creative actions in contrast to red for negative/destructive actions.
We want to encourage users to create more accounts, so creating them should be associated with a positive color.
( in contrast to just changing a name which is a "neutral" blue action.

  1. I think that the dashboard should be pretty, these buttons do not look pretty.

It looks better once we include a link to webmail.

We have Webmail link in the menu. And it still does not look so nice on a wide screen.

  1. "Payment" -> "Payments" (btw, the negative balance badge looks not in place).

What is behind the button is things that have to do with payment which includes a history of payments and the possibility for future payments.
So I think that "payment" is the correct wording as it describes the category of things. Also a single payment is less scary than multiple payments.

I am not sure what you mean by not in place. As in not pixel perfectly aligned or does it just feel wrong?

Feels wrong. Also singular "payment" feels wrong.

  1. I also do not like buttons in the Profile page. I understand that Delete Account button maybe should not be close to the Submit button, but how you did it the buttons are way too much separated. It looks just wrong on a wide screen.

Would this be fixed by increasing the right and left margins of the whole window on wide screen displays? It looks fine on my wide screen view. Can you give me a screenshot of your widescreen view ?

The "OK" / "Submit" button should always be the last button in reading direction so bottom-right.
It would also work if it was the last button with nothing besides it so it can be placed bottom-left.

I would rather center the buttons, maybe with some greated space between buttons.

  1. Why "Create new user" needs to be green? Is there some rule for that?

The idea is to use green for positive / creative actions in contrast to red for negative/destructive actions.
We want to encourage users to create more accounts, so creating them should be associated with a positive color.
( in contrast to just changing a name which is a "neutral" blue action.

Ok, makes sense. That's the less problematic of all these.