• Add missing migration file

• remove some whitespace

• delete users from Info instead of list

The keepalive patch is available sine 0.9.7.

I've found one issue. The role change is not propagated to new connections. Scenario:

1. User1 joins as a subscriber
2. Moderator promotes him to a publisher
3. User2 joins and sees a UI issue, because the User1 tail is a subscriber-like tile, and there's a video element of User1 "out of the matrix".

• Add tests for media setup dialog

• Fix test regressions

• Media setup dialog

• 2.15.0 -> 2.16.0
• Remove spurious whitespace

Removed the in-memory cache instead.

If you think that this internal cache is not really needed then go this way and remove use of self::$typedata. In rare cases when we list folders for all folder types separately in a single request, we'll end up with several requests to the Roundcube imap cache, instead of one. I'm afraid that we might call folder_typedata() or folder_type() methods quite a lot, but I didn't check that, so I'm not sure.

New name

In D2143#24421, @machniak wrote:

How about we call self::folders_typedata($prefix); to populate the cache, but then user folder_type() anyways to fetch missing entries (it still uses the cache if available)?

I don't like it for performance reasons, because if we know the folder has no type then why would you bother with a METADATA request? This would create many redundant requests when listing mail folders. And I'm not sure it would solve your issue.

• Cleanup
• Simplify resize() calls
• More tests
• Test updateConnection endpoint

How about we call self::folders_typedata($prefix); to populate the cache, but then user folder_type() anyways to fetch missing entries (it still uses the cache if available)?

In D2143#24409, @machniak wrote:

With this change METADATA for every folder will be asked separately. This definitely will have performance implications. Maybe a better approach would be to add a method to reset kolab_storage::$typedata (and other cache-like data if needed). And call that method from syncroton's kolab_sync::sleep() or kolab_sync_backend_folder::hasHierarchyChanges().

With this change METADATA for every folder will be asked separately. This definitely will have performance implications. Maybe a better approach would be to add a method to reset kolab_storage::$typedata (and other cache-like data if needed). And call that method from syncroton's kolab_sync::sleep() or kolab_sync_backend_folder::hasHierarchyChanges().

See https://bifrost.kolabsystems.com/T408794 for context. I verified that the RC UI continues to function (especially activesync and folder config),
so it doesn't brake anything, and that the Ping works better for https://bifrost.kolabsystems.com/T408794

Removed comment that no longer applies

The previous patch was inclomplete as it built on another one, this is the full version.

• Fix typo

• Improve constants handling
• Add unique key on openvidu_connections.session_id
• Fix: session_id should be indexed but not unique
• Remove redundant where clause

Wouldn't global STATUS_FOLDER_HIERARCHY_HAS_CHANGED status be more appropriate? Or this does not work with Outlook?

This code is not supposed to be used by Kolab backend. We're using kolab_sync_backend_state::validate().

FWIW, I assume the original code meant to make the case prettier where all folders are below inbox. I think for the affected UI's it shouldn't be a big deal, and avoids the confusing situation we can have right now.

Instead of not showing a tree at all, show it for INBOX as well.