Page MenuHomePhorge
Feed Advanced Search

Jun 10 2020

machniak committed rK534d00000831: Cherry-picked contents from hkccp-import (authored by vanmeeuwen).
Cherry-picked contents from hkccp-import
Jun 10 2020, 11:41 AM
machniak closed D1291: Cherry-picked contents from hkccp-import.
Jun 10 2020, 11:41 AM
machniak committed rK0481c595510a: Add plain text parts to email (authored by machniak).
Add plain text parts to email
Jun 10 2020, 11:41 AM
machniak closed D1354: Add plain text parts to email.
Jun 10 2020, 11:41 AM
machniak added inline comments to D1360: Transaction log in admin UI.
Jun 10 2020, 10:58 AM
machniak updated the diff for D1360: Transaction log in admin UI.
  • Small code improvements
Jun 10 2020, 8:59 AM
machniak requested review of D1360: Transaction log in admin UI.
Jun 10 2020, 8:14 AM

Jun 9 2020

machniak committed rK7dc1e3fa2ee8: Limit number of records the test works with, code improvements (authored by machniak).
Limit number of records the test works with, code improvements
Jun 9 2020, 11:12 AM
machniak requested review of D1354: Add plain text parts to email.
Jun 9 2020, 10:47 AM

Jun 8 2020

machniak updated the diff for D1348: Receipts UI.
  • Use YYYY-MM format in receipt filename
Jun 8 2020, 12:03 PM
machniak requested review of D1348: Receipts UI.
Jun 8 2020, 8:49 AM

Jun 5 2020

machniak requested changes to D1150: Wallet magic.

@vanmeeuwen, I rebased, fixed obvious bugs and refactored the code so now we have Wallet::balanceLastsUntil() that we need tests for in tests/Feature/WalletTest::testBalanceLastsUntil().

Jun 5 2020, 1:47 PM
machniak updated the diff for D1150: Wallet magic.
  • Fix error due to missing use statements
  • Create Wallet::balanceLastsUntil()
Jun 5 2020, 1:44 PM
machniak added inline comments to D1297: Make sure we bill for entitlements that are deleted.
Jun 5 2020, 1:09 PM
machniak requested changes to D1297: Make sure we bill for entitlements that are deleted.

This learned us that an exception does not rollback uncommitted transactions. Here's a general fix for this issue:

--- a/src/app/Exceptions/Handler.php
+++ b/src/app/Exceptions/Handler.php
@@ -5,6 +5,7 @@ namespace App\Exceptions;
 use Exception;
 use Illuminate\Auth\AuthenticationException;
 use Illuminate\Foundation\Exceptions\Handler as ExceptionHandler;
+use Illuminate\Support\Facades\DB;
Jun 5 2020, 12:50 PM
machniak committed rK35814db70a9c: Fix test failing when executed more than once (authored by machniak).
Fix test failing when executed more than once
Jun 5 2020, 9:34 AM
machniak accepted D1291: Cherry-picked contents from hkccp-import.

My comments to src/app/Domain.php were not addressed, but it's not critical.

Jun 5 2020, 9:01 AM
machniak updated the diff for D1327: VAT on Receipts.
  • Render fake receipt with VAT
Jun 5 2020, 8:26 AM

Jun 4 2020

machniak committed rK279da5dfbdc1: Fix regression, improve button labels (authored by machniak).
Fix regression, improve button labels
Jun 4 2020, 4:22 PM
machniak requested review of D1327: VAT on Receipts.
Jun 4 2020, 3:07 PM
machniak committed rK10f2840186b8: Wallet history (authored by machniak).
Wallet history
Jun 4 2020, 1:59 PM
machniak closed D1321: Wallet history.
Jun 4 2020, 1:59 PM
machniak updated the diff for D1321: Wallet history.
  • Top-up -> Payment
Jun 4 2020, 1:58 PM
machniak committed rK9b606244c719: Support: Awarding a bonus or penalty (Bifrost#T315896) (authored by machniak).
Support: Awarding a bonus or penalty (Bifrost#T315896)
Jun 4 2020, 12:53 PM
machniak closed D1267: Support: Awarding a bonus or penalty (Bifrost#T315896).
Jun 4 2020, 12:53 PM
machniak requested review of D1321: Wallet history.
Jun 4 2020, 12:47 PM
machniak committed rK5df6db72a947: Receipt document (html and pdf) (authored by machniak).
Receipt document (html and pdf)
Jun 4 2020, 10:34 AM
machniak closed D1309: Receipt document (html and pdf).
Jun 4 2020, 10:33 AM
machniak added a comment to D1315: Return an empty body element for empty descriptions.

The spec. says Body is optional. https://docs.microsoft.com/en-us/openspecs/exchange_server_protocols/ms-ascal/70161e94-3b50-4d20-8c4d-e3ca608f9dc8

Jun 4 2020, 9:37 AM

Jun 3 2020

machniak committed rKc4f6f1b8b280: Wallet charge: top-ups and notifications (authored by machniak).
Wallet charge: top-ups and notifications
Jun 3 2020, 12:27 PM
machniak closed D1249: Wallet charge: top-ups and notifications.
Jun 3 2020, 12:26 PM
machniak updated the diff for D1249: Wallet charge: top-ups and notifications.
  • Fix typo
Jun 3 2020, 12:14 PM
machniak added inline comments to D1249: Wallet charge: top-ups and notifications.
Jun 3 2020, 9:41 AM
machniak updated the diff for D1249: Wallet charge: top-ups and notifications.
  • Fix Stripe auto-payment charge
  • Fix Mollie auto-payment
  • Add more tests
Jun 3 2020, 9:37 AM

Jun 1 2020

machniak updated the test plan for D1309: Receipt document (html and pdf).
Jun 1 2020, 10:43 AM
machniak requested review of D1309: Receipt document (html and pdf).
Jun 1 2020, 10:33 AM

May 29 2020

machniak retitled D1249: Wallet charge: top-ups and notifications from WIP: Wallet charge: top-ups and notifications
May 29 2020, 4:30 PM
machniak updated the summary of D1249: Wallet charge: top-ups and notifications.
May 29 2020, 4:30 PM
machniak updated the diff for D1249: Wallet charge: top-ups and notifications.
  • Update transaction log with payment description
  • Add wallet:mandate command to view/enable/disable auto-payment
  • Disabled mandate handling, test and fixed some flaky tests
May 29 2020, 4:29 PM
machniak updated the summary of D1267: Support: Awarding a bonus or penalty (Bifrost#T315896).
May 29 2020, 8:18 AM
machniak updated the diff for D1267: Support: Awarding a bonus or penalty (Bifrost#T315896).
  • Use transaction log
May 29 2020, 8:17 AM

May 28 2020

machniak planned changes to D1249: Wallet charge: top-ups and notifications.
May 28 2020, 12:58 PM
machniak updated the diff for D1249: Wallet charge: top-ups and notifications.
  • Add some payment notification jobs/emails
  • More on auto-top-ups and disabling mandates
  • Added tests for two jobs
  • Tests for Mollie wallet top-ups
  • Rename templates
  • Fix parse error
  • Stripe: Webhook fixes, more tests
  • Add todo
  • More webhook tests, send notifications for recurring payments only
  • Disable auto-payment mandate on failed payment
  • Add payment success/failure notification emails with tests
  • Payment mandate disabled notification
  • Fix typos
  • Small improvements
  • Improve wording
  • Add fakeRender() for all templates
May 28 2020, 12:57 PM
machniak requested changes to D1150: Wallet magic.

I think we'll need this code as a method on the Wallet object, as it will be needed also for UI. And we need a test. I don't understand the code, so I might get back to it later.

May 28 2020, 12:44 PM
machniak accepted D1102: An initial implementation of transactions..
May 28 2020, 12:07 PM
machniak committed rK9c680e8a7574: Support: Unsuspending/Suspending a user (Bifrost#T315890) (authored by machniak).
Support: Unsuspending/Suspending a user (Bifrost#T315890)
May 28 2020, 12:04 PM
machniak closed D1273: Support: Unsuspending/Suspending a user (Bifrost#T315890).
May 28 2020, 12:03 PM
machniak committed rKfac27dba481b: Add command to render mail templates (authored by machniak).
Add command to render mail templates
May 28 2020, 12:03 PM
machniak closed D1303: Add command to render mail templates.
May 28 2020, 12:03 PM
machniak updated the diff for D1273: Support: Unsuspending/Suspending a user (Bifrost#T315890).

Rebased

May 28 2020, 12:02 PM
machniak added inline comments to D1297: Make sure we bill for entitlements that are deleted.
May 28 2020, 11:54 AM
machniak accepted D1219: Make the id for a user fillable.
May 28 2020, 11:37 AM
machniak requested changes to D1297: Make sure we bill for entitlements that are deleted.

Tests look good.

May 28 2020, 10:45 AM
machniak requested changes to D1291: Cherry-picked contents from hkccp-import.
May 28 2020, 10:28 AM
machniak committed rK7058be93faee: Fix test (authored by machniak).
Fix test
May 28 2020, 9:58 AM
machniak requested changes to D1219: Make the id for a user fillable.
May 28 2020, 9:21 AM
machniak requested changes to D1102: An initial implementation of transactions..

One last change request. Is it finished?

May 28 2020, 9:12 AM
machniak requested review of D1303: Add command to render mail templates.
May 28 2020, 8:53 AM

May 27 2020

machniak planned changes to D1249: Wallet charge: top-ups and notifications.
May 27 2020, 3:15 PM
machniak updated the summary of D1249: Wallet charge: top-ups and notifications.
May 27 2020, 3:15 PM
machniak updated the diff for D1249: Wallet charge: top-ups and notifications.
  • More webhook tests, send notifications for recurring payments only
  • Disable auto-payment mandate on failed payment
  • Add payment success/failure notification emails with tests
  • Payment mandate disabled notification
  • Fix typos
  • Small improvements
  • Improve wording
May 27 2020, 3:14 PM
machniak added a comment to D1297: Make sure we bill for entitlements that are deleted.

Looking at the code in context of removing entitlements, I see we might not handle removing storage entitlements properly. We have to add some tests to tests/Feature/Controller/UsersTest::testUpdateEntitlements().

May 27 2020, 3:06 PM
machniak accepted D1285: Add a command db:ping and then use it.
May 27 2020, 12:40 PM
machniak planned changes to D1249: Wallet charge: top-ups and notifications.
May 27 2020, 11:52 AM
machniak added a comment to D1297: Make sure we bill for entitlements that are deleted.

So far so good. I have two stories to consider:

  1. User is deleting and adding the same SKU every 13 days - got it for free.
  2. (After 14 days of using his account) user raises quota, then in 14 days he lowers it - got the "rised quota period" for free.
May 27 2020, 11:51 AM

May 26 2020

machniak updated the summary of D1249: Wallet charge: top-ups and notifications.
May 26 2020, 1:34 PM
machniak updated the summary of D1249: Wallet charge: top-ups and notifications.
May 26 2020, 1:32 PM
machniak updated the diff for D1249: Wallet charge: top-ups and notifications.
  • Add some payment notification jobs/emails
  • More on auto-top-ups and disabling mandates
  • Added tests for two jobs
  • Tests for Mollie wallet top-ups
  • Rename templates
  • Fix parse error
  • Stripe: Webhook fixes, more tests
  • Add todo
May 26 2020, 1:30 PM
machniak added inline comments to D1102: An initial implementation of transactions..
May 26 2020, 1:05 PM
machniak added inline comments to D1102: An initial implementation of transactions..
May 26 2020, 12:49 PM
machniak committed rK0c6f883de458: Fix last occurrence of 'name' instead of first+last name (authored by machniak).
Fix last occurrence of 'name' instead of first+last name
May 26 2020, 12:44 PM
machniak added inline comments to D1102: An initial implementation of transactions..
May 26 2020, 8:10 AM

May 25 2020

machniak requested changes to D1102: An initial implementation of transactions..
May 25 2020, 4:59 PM
machniak added inline comments to D1102: An initial implementation of transactions..
May 25 2020, 11:43 AM

May 22 2020

machniak requested changes to D1102: An initial implementation of transactions..
May 22 2020, 5:06 PM

May 20 2020

machniak added a comment to D1279: Only authenticate against ldap if ldap is available..

Maybe we should authenticate the user with IMAP instead? As far as I know the protocol spec. does not require authentication, but it recommends it.

May 20 2020, 12:45 PM
machniak added a comment to T5866: Problem with calendar plugin for roundcube.

This driver is not a high prio for us. Patches welcome.

May 20 2020, 12:21 PM ยท Roundcube Kolab Plugins , Bug Reports

May 19 2020

machniak added a comment to T5866: Problem with calendar plugin for roundcube.

Ok, I was testing a different case. However, this case also works with Kolab backend. I assume that you're using the database driver. Is it right?

May 19 2020, 7:28 PM ยท Roundcube Kolab Plugins , Bug Reports

May 18 2020

machniak updated the diff for D1267: Support: Awarding a bonus or penalty (Bifrost#T315896).

Rebase

May 18 2020, 11:38 AM
machniak committed rKb8897a28a88c: Custom payments, auto-payments, Stripe support (authored by machniak).
Custom payments, auto-payments, Stripe support
May 18 2020, 9:45 AM
machniak closed D1231: Custom payments, auto-payments, Stripe support.
May 18 2020, 9:45 AM
machniak updated the diff for D1231: Custom payments, auto-payments, Stripe support.
  • Add Mollie/Stripe tests
  • Browser tests, mollie/stripe
  • More browser tests, make possible to run both stripe and mollie tests
  • Silence more phpstan errors
  • Use wallet's payment provider if exists instead of the default provider
  • Support: Display auto-payment info
  • Log failed payment responses
May 18 2020, 9:43 AM
machniak added a comment to D1273: Support: Unsuspending/Suspending a user (Bifrost#T315890).

@bohlender As you can see here I use btn-warning for the Subscribe/Unsubscribe button, which makes the button orange. I found that yellow didn't work well for buttons. Maybe we should just not use btn-warning at all. Please take a look at https://bifrost.kolabsystems.com/T315890#2637686 for possible improvement. I'd like to know your opinion.

May 18 2020, 9:37 AM
machniak committed rKb08395ff3822: OpenVidu 2.14.0 (authored by machniak).
OpenVidu 2.14.0
May 18 2020, 9:03 AM
machniak committed rK454da9e95131: OpenVidu: Room layout (authored by machniak).
OpenVidu: Room layout
May 18 2020, 8:54 AM
machniak committed rK9a7b0c5c69d0: OpenVidu: Screen sharing (authored by machniak).
OpenVidu: Screen sharing
May 18 2020, 8:54 AM

May 15 2020

machniak committed rK58b0b97bb5a7: Small css fixes (authored by machniak).
Small css fixes
May 15 2020, 11:02 AM
machniak committed rK47d1b7afcad3: RequestLogger: Log memory usage and exec time, don't log the token (authored by machniak).
RequestLogger: Log memory usage and exec time, don't log the token
May 15 2020, 10:12 AM

May 14 2020

machniak requested review of D1273: Support: Unsuspending/Suspending a user (Bifrost#T315890).
May 14 2020, 4:32 PM
machniak requested review of D1267: Support: Awarding a bonus or penalty (Bifrost#T315896).
May 14 2020, 12:52 PM

May 13 2020

machniak committed rKf137bf7a3983: Bootstrap 4.5.0, jQuery 3.5.1, Popper 1.6.1 + small css fixes (authored by machniak).
Bootstrap 4.5.0, jQuery 3.5.1, Popper 1.6.1 + small css fixes
May 13 2020, 10:06 AM

May 12 2020

machniak committed rK08416bd4d943: Openvidu-browser is dev-dependency (authored by machniak).
Openvidu-browser is dev-dependency
May 12 2020, 8:17 PM
machniak committed rK179f123706c0: Add some UI for openvidu (authored by machniak).
Add some UI for openvidu
May 12 2020, 3:31 PM

May 11 2020

machniak updated the diff for D1231: Custom payments, auto-payments, Stripe support.
  • Log failed payment responses
May 11 2020, 1:45 PM
machniak updated the diff for D1231: Custom payments, auto-payments, Stripe support.
  • Support: Display auto-payment info
May 11 2020, 9:29 AM
machniak committed rK1ee0e601c466: Integrate openvidu-browser, switch to SPA, enable CORS (authored by machniak).
Integrate openvidu-browser, switch to SPA, enable CORS
May 11 2020, 9:11 AM

May 7 2020

machniak added a project to T5866: Problem with calendar plugin for roundcube: Roundcube Kolab Plugins .

It works for me with Kolab backend, although the event info dialog displays "Repeat: Every 1 month(s), forever ". When I edit the event Recurrence form looks correct and the event is displayed properly on the 3rd Thursday as defined. So, I see only a problem with the "Repeat" text not being complete.

May 7 2020, 9:28 AM ยท Roundcube Kolab Plugins , Bug Reports

May 6 2020

machniak requested review of D1249: Wallet charge: top-ups and notifications.
May 6 2020, 1:14 PM

May 5 2020

machniak retitled D1231: Custom payments, auto-payments, Stripe support from [WIP] Custom payments, auto-payments, Stripe support
May 5 2020, 1:24 PM
machniak updated the diff for D1231: Custom payments, auto-payments, Stripe support.
  • Add Mollie/Stripe tests
  • Browser tests, mollie/stripe
  • More browser tests, make possible to run both stripe and mollie tests
  • Silence more phpstan errors
  • Use wallet's payment provider if exists instead of the default provider
May 5 2020, 1:22 PM