Page MenuHomePhorge
Feed Search

Jun 24 2024

machniak committed rK9f8438a620f3: Fold WalletCharge and WalletCheck into one.
Jun 24 2024, 12:54 PM
machniak closed D4797: Rename/move CLI command files to unify.
Jun 24 2024, 12:50 PM
machniak committed rK10af84405e78: Rename/move CLI command files to unify.
Jun 24 2024, 12:50 PM

Jun 21 2024

machniak requested changes to D4809: Turn the Receipt download into a ReceiptList.

Almost there. tests/Browser/WalletTest.php needs an update too.

Jun 21 2024, 11:20 AM

Jun 20 2024

machniak updated the diff for D4803: WIP: Server Side Events.
  • Workaround KTOR client bug, add development commands to send push notifications
Jun 20 2024, 4:32 PM

Jun 19 2024

machniak committed rK69685d461baf: CS fixes.
Jun 19 2024, 1:28 PM
machniak requested review of D4803: WIP: Server Side Events.
Jun 19 2024, 1:23 PM
machniak added a comment to T8373: kolab undelete-mailbox doesn't work.

Maybe something like this:

--- a/cyruslib.py
+++ b/cyruslib.py
@@ -885,6 +885,7 @@ class CYRUS:
             annotation = annotation.strip()
             tokens = tokenize(annotation)
             folder = tokens[0]
+            mailbox = ensure_binary(mailbox)
Jun 19 2024, 12:10 PM · Bug Reports

Jun 17 2024

machniak requested review of D4797: Rename/move CLI command files to unify.
Jun 17 2024, 12:24 PM
machniak added a comment to D4725: Fold WalletCharge and WalletCheck into one.

See my take in D4794: Fold WalletCharge and WalletCheck into one

Jun 17 2024, 10:28 AM
machniak requested review of D4794: Fold WalletCharge and WalletCheck into one.
Jun 17 2024, 10:22 AM

Jun 14 2024

machniak closed D4791: Add tenant context to signup codes.
Jun 14 2024, 11:03 AM
machniak committed rK7bc96d52393c: Add tenant context to signup codes.
Jun 14 2024, 11:03 AM
machniak closed D4752: Make CLI commands tenant independent.
Jun 14 2024, 11:02 AM
machniak committed rK19a6ff6ffdcf: Make CLI commands tenant independent.
Jun 14 2024, 11:02 AM
machniak closed D4716: Password tokens for user proxy authentication.
Jun 14 2024, 11:02 AM
machniak committed rKbd9dbb06ff2d: Password tokens for user proxy authentication.
Jun 14 2024, 11:02 AM
machniak accepted D4776: Setup all a tenant needs in a single command.
Jun 14 2024, 10:41 AM
machniak requested changes to D4776: Setup all a tenant needs in a single command.
Jun 14 2024, 6:30 AM
machniak accepted D4782: Allow creating users in public domains.
Jun 14 2024, 6:13 AM

Jun 13 2024

machniak committed rKcb18e6205eaf: Add test for Domain::assignPackage(), also throw exception in a sanity check.
Jun 13 2024, 12:39 PM
machniak abandoned D4755: Multitenant ready signup mail.

See D4791: Add tenant context to signup codes

Jun 13 2024, 10:57 AM
machniak requested review of D4791: Add tenant context to signup codes.
Jun 13 2024, 10:56 AM
machniak added inline comments to D4776: Setup all a tenant needs in a single command.
Jun 13 2024, 10:06 AM
machniak accepted D4731: Update mediasoup-client.
Jun 13 2024, 7:58 AM
machniak requested changes to D4782: Allow creating users in public domains.
Jun 13 2024, 7:58 AM
machniak closed D4749: Make scheduled commands to work for all tenants (not the configured one).
Jun 13 2024, 7:54 AM
machniak committed rKc5edae74b47b: Make scheduled commands to work for all tenants (not the configured one).
Jun 13 2024, 7:53 AM

Jun 12 2024

machniak updated the diff for D4752: Make CLI commands tenant independent.
  • Complete tenant-independence in CLI commands
  • Fix regression, cleanup
Jun 12 2024, 1:05 PM
machniak accepted D4788: APP_NAME independent redis prefixes.

Be careful when deploying this. Make sure the queue is empty.

Jun 12 2024, 12:07 PM
machniak accepted D4773: We use this from the admin seeder.
Jun 12 2024, 11:05 AM
machniak requested changes to D4776: Setup all a tenant needs in a single command.
Jun 12 2024, 8:24 AM
machniak added a comment to D4755: Multitenant ready signup mail.

This changes nothing if we run the jobs on the main system. But I agree we need a tenant context. See T264 in Phorge.

Jun 12 2024, 7:00 AM
machniak requested changes to D4773: We use this from the admin seeder.

This make app.passphrase to be used only on production, which is wrong.

Jun 12 2024, 6:56 AM
machniak accepted D4779: Configure logging based on the debug flag not the environment.
Jun 12 2024, 6:54 AM
machniak added a comment to D4785: Make user:create multi-tenant compatible.

I don't think this makes sense, because the same is done by the observer already.

Jun 12 2024, 6:53 AM

Jun 11 2024

machniak requested review of D4752: Make CLI commands tenant independent.
Jun 11 2024, 1:17 PM
machniak closed D4740: Improve domain:set-wallet.
Jun 11 2024, 10:44 AM
machniak closed D4746: Add email address to body of a mail notification.
Jun 11 2024, 10:43 AM
machniak committed rK2bf8d7f49f82: Improve domain:set-wallet.
Jun 11 2024, 10:43 AM
machniak committed rK78de5dca7158: Add email address to body of a mail notification.
Jun 11 2024, 10:43 AM
machniak requested review of D4749: Make scheduled commands to work for all tenants (not the configured one).
Jun 11 2024, 10:24 AM
machniak added a comment to D4725: Fold WalletCharge and WalletCheck into one.

One more note. Currently if topUpWallet() throws exception (for any reason, e.g. Mollie connection issues) the WalletCharge job will try to top up the wallet again. Here it won't happen, so it will be more fragile to temporary issues with the payment provider. Catching the exception and invoking a separate WalletCharge job might make sense.

Jun 11 2024, 8:44 AM

Jun 10 2024

machniak updated the diff for D4746: Add email address to body of a mail notification.
  • Update French localization
Jun 10 2024, 1:50 PM
machniak requested review of D4746: Add email address to body of a mail notification.
Jun 10 2024, 12:55 PM
machniak accepted D4743: CompanionApp commands.
Jun 10 2024, 7:59 AM

Jun 5 2024

machniak requested review of D4740: Improve domain:set-wallet.
Jun 5 2024, 1:14 PM
machniak added a comment to D4737: Only start rate-limiting once balance goes below -10.

10 here is 0.10 CHF, is this the intention?

Jun 5 2024, 8:15 AM

Jun 4 2024

machniak accepted D4734: npm update.

This most likely conflicts on master.

Jun 4 2024, 12:47 PM
machniak abandoned D4713: Laravel Passport v12.

Merged in rK17dc669efeb3af

Jun 4 2024, 12:45 PM
machniak closed D4728: Update Bootstrap and other npm dependencies (fixes security issues).
Jun 4 2024, 12:43 PM
machniak committed rK804c9497c412: Update Bootstrap and other npm dependencies (fixes security issues).
Jun 4 2024, 12:43 PM
machniak closed D4704: Wait for user record in UpdateJob.
Jun 4 2024, 12:42 PM
machniak committed rK1a564c464615: Wait for user record in UpdateJob.
Jun 4 2024, 12:42 PM
machniak closed D4710: User search API.
Jun 4 2024, 11:37 AM
machniak committed rK01824683efa4: User search API.
Jun 4 2024, 11:37 AM
machniak updated the diff for D4710: User search API.
  • Disable user search route for now
Jun 4 2024, 11:37 AM
machniak committed rK693109455d05: Make sure entitlements aren't charged to a wrong wallet.
Jun 4 2024, 8:14 AM
machniak planned changes to D4713: Laravel Passport v12.

We need to figure out how to use it without ext-sodium

Jun 4 2024, 6:28 AM
machniak reopened D4713: Laravel Passport v12.
Jun 4 2024, 6:28 AM

Jun 3 2024

machniak committed rKbc1d3c36a571: Add test case for chargeEntitlements().
Jun 3 2024, 2:19 PM
machniak committed rK5684cc2fada6: Fix SQL query in Wallet::chargeEntitlements().
Jun 3 2024, 1:38 PM
machniak closed D4707: CLI improvements for reseller system setup.
Jun 3 2024, 12:20 PM
machniak committed rK31bcd0817ddf: CLI improvements for reseller system setup.
Jun 3 2024, 12:20 PM
machniak closed D4713: Laravel Passport v12.
Jun 3 2024, 12:19 PM
machniak committed rK7ea42bc4f65a: Laravel Passport v12.
Jun 3 2024, 12:19 PM
machniak closed D4722: Performance improvements in user info request handler.
Jun 3 2024, 11:46 AM
machniak committed rKcac432ce5c67: Performance improvements in user info request handler.
Jun 3 2024, 11:46 AM
machniak requested review of D4728: Update Bootstrap and other npm dependencies (fixes security issues).
Jun 3 2024, 10:43 AM
machniak added a comment to D4725: Fold WalletCharge and WalletCheck into one.

Maybe it makes sense, if huge number of jobs is not an issue. Also we should probably do dispatch($wallet->id) instead of dispatch($wallet) (and do find() instead of refresh()).

Jun 3 2024, 9:41 AM

May 31 2024

machniak committed rK7d578a8f51e9: Allow bin/regen-certs to generate certs for a specified domain.
May 31 2024, 3:05 PM

May 30 2024

machniak accepted D4719: Match default folders by regex with the dav backend.
May 30 2024, 7:14 AM
machniak requested changes to D4719: Match default folders by regex with the dav backend.

A better place to do this is in the libkolab plugin. See https://git.kolab.org/rRPK905644dc6c5e256c42f3a6a422601759ea0a47cd

May 30 2024, 6:36 AM
machniak committed rRPK905644dc6c5e: Default DAV folder detection.
May 30 2024, 6:34 AM

May 29 2024

machniak requested review of D4722: Performance improvements in user info request handler.
May 29 2024, 6:54 PM
machniak added a comment to rK999845469133: Create the default tenant.

@mollekopf, This is kinda strange. You have to know tenant ID (to put it in config) before creating any record. Is this working? It might be better to create the default tenant in migration (where we create the tenants table) instead of seeder.

May 29 2024, 6:52 AM

May 28 2024

machniak requested review of D4716: Password tokens for user proxy authentication.
May 28 2024, 1:18 PM
machniak committed rKaab7f409bea7: CS fixes.
May 28 2024, 9:36 AM
machniak requested review of D4713: Laravel Passport v12.
May 28 2024, 9:03 AM

May 24 2024

machniak requested review of D4710: User search API.
May 24 2024, 1:43 PM

May 23 2024

machniak committed rRPK2cedf86201e0: Log error and do not throw when an iTip body is unset.
May 23 2024, 1:30 PM
machniak committed rRPK6575f2690081: Fix phpstan error.
May 23 2024, 1:30 PM
machniak requested changes to D4594: 15 messages / minute rate-limit for paying users.
May 23 2024, 8:43 AM

May 22 2024

machniak added inline comments to rK916233959aaf: Use IMAP_HOST for managesieve.
May 22 2024, 1:37 PM
machniak updated the diff for D4707: CLI improvements for reseller system setup.
  • Add 'tenants' command
  • Update doc
May 22 2024, 11:44 AM
machniak requested review of D4707: CLI improvements for reseller system setup.
May 22 2024, 10:10 AM
machniak committed R113:545365ccf7fb: Makefile: Fix PHP 5.5 support.
May 22 2024, 7:04 AM
machniak committed R113:9d93e7d222bb: CI: config-test.inc.php is the correct name.
May 22 2024, 7:04 AM
machniak committed R113:4be9dbf0790e: CI: Bring back config-test.inc.php.
May 22 2024, 7:04 AM
machniak committed R113:5c0fbde1683f: Fix PHP8 warnings.
May 22 2024, 7:04 AM
machniak committed R113:b3c51ee09d29: Fix test regression.
May 22 2024, 7:04 AM
machniak committed R113:a8e2477dbe08: CI: Remove unreliable browser tests.
May 22 2024, 7:04 AM
machniak committed R113:52a8da481a9f: CI: Temp. fix for https://github.com/roundcube/plugin-installer/issues/56.
May 22 2024, 7:04 AM
machniak committed R113:4da20eb1d113: Fix cross-site scripting (XSS) vulnerability in handling SVG animate attributes.
May 22 2024, 7:04 AM
machniak committed R113:0d0bc61b139d: Fix cross-site scripting (XSS) vulnerability in handling list columns from user….
May 22 2024, 7:04 AM
machniak committed R113:8a88c8cc16f0: Makefile: Use phpDocumentor v3.4 for the Framework docs (#9313).
May 22 2024, 7:04 AM
machniak committed R113:61a3c9aa8938: Fix command injection via crafted im_convert_path/im_identify_path on Windows.
May 22 2024, 7:04 AM

May 21 2024

machniak requested changes to D3866: [Python 3] setup-ldap reduce code overhead / make compatibel to dscreate beta packages.
May 21 2024, 8:52 AM
machniak accepted D4217: Log spf failure reasons.
May 21 2024, 8:49 AM
machniak committed rKe5e6d9fa8589: Start documenting the Reseller system.
May 21 2024, 8:12 AM