Only start rate-limiting once balance goes below -10
AbandonedPublic
Actions

Authored by mollekopf on Jun 4 2024, 5:06 PM.

Tags

None

Referenced Files

	F14003364: D4737.id.diff
	Fri, Jul 26, 2:22 PM

	Unknown Object (File)
	Wed, Jul 24, 7:36 AM

	Unknown Object (File)
	Wed, Jul 17, 7:21 PM

	Unknown Object (File)
	Tue, Jul 16, 5:48 PM

	Unknown Object (File)
	Tue, Jul 16, 3:22 PM

	Unknown Object (File)
	Mon, Jul 15, 1:57 PM

	Unknown Object (File)
	Mon, Jul 15, 8:46 AM

	Unknown Object (File)
	Sat, Jul 13, 3:55 PM

View All 34 Files

Subscribers

machniak

Details

Reviewers

None

Group Reviewers

Restricted Project

Summary

Since we keep the balance around 0 (this is when payments are triggered
etc), I think it would make sense to give some leeway so we don't have
to deal with rate-limiting questions in support.

Diff Detail

Repository

rK kolab

Branch

master

Lint

Lint Skipped

Unit

No Test Coverage

Build Status

Buildable 47610
Build 18033: arc lint + arc unit

Event Timeline

mollekopf created this revision.Jun 4 2024, 5:06 PM

Harbormaster completed remote builds in B47610: Diff 13617.Jun 4 2024, 5:06 PM

mollekopf requested review of this revision.Jun 4 2024, 5:06 PM

mollekopf added a reviewer: Restricted Project.Jun 4 2024, 5:21 PM

10 here is 0.10 CHF, is this the intention?

it's not, and I'm also not sure if this really solves anything since we actually try to keep the balance around 10 CHF (I think?). Maybe the better solution would be to just prominently display a warning that the user is being rate limited.

https://phorge.apps.ocp04.ait-msp-infra.net/T265

Revision Contents
Changeset List

Path

Size

src/

app/

Http/

Controllers/

API/

V4/

PolicyController.php

4 lines

Diff 13617

View Options

src/app/Http/Controllers/API/V4/PolicyController.php

Only start rate-limiting once balance goes below -10AbandonedPublicActions