Page MenuHomePhorge
Differential D4737

Only start rate-limiting once balance goes below -10
AbandonedPublic
Actions

Authored by mollekopf on Tue, Jun 4, 5:06 PM.
Tags
None
Referenced Files
F12990450: D4737.diff
Wed, Jun 26, 1:52 AM
F12986379: D4737.diff
Tue, Jun 25, 3:17 PM
Unknown Object (File)
Sat, Jun 22, 5:15 PM
Unknown Object (File)
Thu, Jun 20, 9:19 PM
Unknown Object (File)
Thu, Jun 20, 3:38 PM
Unknown Object (File)
Wed, Jun 19, 12:16 AM
Unknown Object (File)
Mon, Jun 17, 5:23 AM
Unknown Object (File)
Sun, Jun 16, 12:27 PM
View All 21 Files
Subscribers
machniak

Details

Reviewers
None
Group Reviewers
Restricted Project
Summary

Since we keep the balance around 0 (this is when payments are triggered
etc), I think it would make sense to give some leeway so we don't have
to deal with rate-limiting questions in support.

Diff Detail

Repository
rK kolab
Branch
master
Lint
Lint Skipped
Unit
No Test Coverage
Build Status
Buildable 47610
Build 18033: arc lint + arc unit

Event Timeline

mollekopf created this revision.Tue, Jun 4, 5:06 PM
Harbormaster completed remote builds in B47610: Diff 13617.Tue, Jun 4, 5:06 PM
mollekopf requested review of this revision.Tue, Jun 4, 5:06 PM
mollekopf added a reviewer: Restricted Project.Tue, Jun 4, 5:21 PM
machniak subscribed.Wed, Jun 5, 10:15 AM

10 here is 0.10 CHF, is this the intention?

mollekopf added a comment.Wed, Jun 12, 3:42 PM

it's not, and I'm also not sure if this really solves anything since we actually try to keep the balance around 10 CHF (I think?). Maybe the better solution would be to just prominently display a warning that the user is being rate limited.

mollekopf abandoned this revision.Wed, Jun 12, 3:42 PM

https://phorge.apps.ocp04.ait-msp-infra.net/T265

Revision Contents
Changeset List

PathSize
src/
app/
Http/
Controllers/
API/
V4/
4 lines

Diff 13617

View Options

src/app/Http/Controllers/API/V4/PolicyController.php

Loading...