Page MenuHomePhorge

CompanionApp commands
ClosedPublic

Authored by mollekopf on Mon, Jun 10, 9:48 AM.
Tags
None
Referenced Files
F12831408: D4743.id13623.diff
Fri, Jun 14, 12:32 AM
F12829983: D4743.id13626.diff
Thu, Jun 13, 10:07 PM
Unknown Object (File)
Wed, Jun 12, 7:03 PM
Subscribers

Details

Reviewers
machniak
Group Reviewers
Restricted Project
Commits
rK560ef604802d: CompanionApp commands

Diff Detail

Repository
rK kolab
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

mollekopf created this revision.
mollekopf added a reviewer: Restricted Project.Mon, Jun 10, 9:49 AM
machniak subscribed.
machniak added inline comments.
src/app/Console/Commands/CompanionApp/DeleteCommand.php
15

I think $objectTitle should be null.

src/app/Console/Commands/CompanionApp/ListCommand.php
36

The use of JSON is something new, there's only one command that does this. I think this whole command should just use ObjectListCommand. authattempt:list too.

This revision is now accepted and ready to land.Mon, Jun 10, 9:59 AM
This revision was automatically updated to reflect the committed changes.