Page MenuHomePhorge
Differential D4743

CompanionApp commands
ClosedPublic
Actions

Authored by mollekopf on Mon, Jun 10, 9:48 AM.
Tags
None
Referenced Files
F12990462: D4743.diff
Wed, Jun 26, 1:53 AM
F12989673: D4743.id13623.diff
Tue, Jun 25, 11:27 PM
F12989622: D4743.id13626.diff
Tue, Jun 25, 11:25 PM
F12989619: D4743.id.diff
Tue, Jun 25, 11:25 PM
F12988698: D4743.diff
Tue, Jun 25, 9:20 PM
F12985974: D4743.diff
Tue, Jun 25, 2:18 PM
Unknown Object (File)
Wed, Jun 19, 5:32 AM
Unknown Object (File)
Wed, Jun 19, 12:52 AM
View All 19 Files
Subscribers
machniak

Details

Reviewers
machniak
Group Reviewers
Restricted Project
Commits
rK560ef604802d: CompanionApp commands

Diff Detail

Repository
rK kolab
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

mollekopf requested review of this revision.Mon, Jun 10, 9:48 AM
mollekopf created this revision.
Harbormaster completed remote builds in B47616: Diff 13623.Mon, Jun 10, 9:48 AM
mollekopf added a reviewer: Restricted Project.Mon, Jun 10, 9:49 AM
machniak accepted this revision.Mon, Jun 10, 9:59 AM
machniak subscribed.
machniak added inline comments.
src/app/Console/Commands/CompanionApp/DeleteCommand.php
15

I think $objectTitle should be null.

src/app/Console/Commands/CompanionApp/ListCommand.php
36

The use of JSON is something new, there's only one command that does this. I think this whole command should just use ObjectListCommand. authattempt:list too.

This revision is now accepted and ready to land.Mon, Jun 10, 9:59 AM
Closed by commit rK560ef604802d: CompanionApp commands (authored by mollekopf). · Explain WhyMon, Jun 10, 10:30 AM
This revision was automatically updated to reflect the committed changes.
mollekopf added a commit: rK560ef604802d: CompanionApp commands.

Revision Contents
Changeset List

PathSize
src/
app/
Console/
Commands/
CompanionApp/
15 lines
12 lines
User/
13 lines
10 lines

Diff 13626

View Options

src/app/Console/Commands/CompanionApp/DeleteCommand.php

Loading...
View Options

src/app/Console/Commands/CompanionApp/ListCommand.php

Loading...
View Options

src/app/Console/Commands/User/CompanionAppsCommand.php

Loading...
View Options

src/app/User.php

Loading...