Differential D4743

CompanionApp commands
ClosedPublic
Actions

Authored by mollekopf on Jun 10 2024, 9:48 AM.

Tags

None

Referenced Files

	F14006463: D4743.diff
	Fri, Jul 26, 8:38 PM

	Unknown Object (File)
	Thu, Jul 25, 10:46 AM

	Unknown Object (File)
	Tue, Jul 23, 3:11 AM

	Unknown Object (File)
	Sat, Jul 20, 2:48 AM

	Unknown Object (File)
	Fri, Jun 28, 3:44 PM

	Unknown Object (File)
	Fri, Jun 28, 9:07 AM

	Unknown Object (File)
	Jun 26 2024, 1:53 AM

	Unknown Object (File)
	Jun 25 2024, 11:27 PM

View All 25 Files

Subscribers

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rK560ef604802d: CompanionApp commands

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

mollekopf requested review of this revision.Jun 10 2024, 9:48 AM

mollekopf created this revision.

Harbormaster completed remote builds in B47616: Diff 13623.Jun 10 2024, 9:48 AM

mollekopf added a reviewer: Restricted Project.Jun 10 2024, 9:49 AM

machniak accepted this revision.Jun 10 2024, 9:59 AM

machniak subscribed.

machniak added inline comments.

src/app/Console/Commands/CompanionApp/DeleteCommand.php
15	I think $objectTitle should be null.
src/app/Console/Commands/CompanionApp/ListCommand.php
36	The use of JSON is something new, there's only one command that does this. I think this whole command should just use ObjectListCommand. authattempt:list too.

This revision is now accepted and ready to land.Jun 10 2024, 9:59 AM

Closed by commit rK560ef604802d: CompanionApp commands (authored by mollekopf). · Explain WhyJun 10 2024, 10:30 AM

This revision was automatically updated to reflect the committed changes.

mollekopf added a commit: rK560ef604802d: CompanionApp commands.

Revision Contents
Changeset List

Path

Size

src/

app/

Console/

Commands/

CompanionApp/

DeleteCommand.php

15 lines

ListCommand.php

12 lines

User/

CompanionAppsCommand.php

13 lines

10 lines

Diff 13626

src/app/Console/Commands/CompanionApp/DeleteCommand.php

Loading...

src/app/Console/Commands/CompanionApp/ListCommand.php

Loading...

src/app/Console/Commands/User/CompanionAppsCommand.php

Loading...

src/app/User.php

Loading...