Page MenuHomePhorge

15 messages / minute rate-limit for paying users
Needs ReviewPublic

Authored by mollekopf on Nov 28 2023, 7:54 AM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Apr 24, 6:08 AM
Unknown Object (File)
Wed, Apr 17, 11:05 AM
Unknown Object (File)
Wed, Apr 17, 11:05 AM
Unknown Object (File)
Wed, Apr 17, 11:05 AM
Unknown Object (File)
Wed, Apr 17, 11:05 AM
Unknown Object (File)
Mon, Apr 15, 10:55 AM
Unknown Object (File)
Mon, Apr 15, 4:30 AM
Unknown Object (File)
Fri, Apr 12, 10:43 PM
Subscribers

Details

Reviewers
None
Group Reviewers
Restricted Project

Diff Detail

Repository
rK kolab
Branch
dev/mollekopf
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 45880
Build 17755: arc lint + arc unit

Event Timeline

mollekopf created this revision.
mollekopf added a reviewer: Restricted Project.Nov 28 2023, 8:03 AM
machniak added inline comments.
src/app/Http/Controllers/API/V4/PolicyController.php
148

This will make the 100%-discounted users also being limited. I'm not sure it's intentional.

149

This way the limit is shared by all users in an account. Might be too small for bigger accounts. How about where('user_id', $user->id) instead?

151

No need for $count variable.

src/app/Wallet.php
754

The argument is not documented. And maybe it should be $minPaymentsCount.