Page MenuHomePhorge

15 messages / minute rate-limit for paying users
Needs RevisionPublic

Authored by mollekopf on Nov 28 2023, 7:54 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Oct 20, 6:50 PM
Unknown Object (File)
Sun, Oct 20, 4:07 AM
Unknown Object (File)
Fri, Oct 18, 6:26 AM
Unknown Object (File)
Fri, Oct 4, 4:14 PM
Unknown Object (File)
Fri, Oct 4, 8:53 AM
Unknown Object (File)
Sep 30 2024, 9:14 AM
Unknown Object (File)
Sep 21 2024, 4:40 PM
Unknown Object (File)
Sep 17 2024, 8:07 AM
Subscribers

Details

Reviewers
machniak
Group Reviewers
Restricted Project

Diff Detail

Repository
rK kolab
Branch
dev/mollekopf
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 45880
Build 17755: arc lint + arc unit

Event Timeline

mollekopf created this revision.
mollekopf added a reviewer: Restricted Project.Nov 28 2023, 8:03 AM
machniak added inline comments.
src/app/Http/Controllers/API/V4/PolicyController.php
148

This will make the 100%-discounted users also being limited. I'm not sure it's intentional.

149

This way the limit is shared by all users in an account. Might be too small for bigger accounts. How about where('user_id', $user->id) instead?

151

No need for $count variable.

src/app/Wallet.php
754

The argument is not documented. And maybe it should be $minPaymentsCount.

This revision now requires changes to proceed.May 23 2024, 10:43 AM