Details
Details
- Reviewers
machniak - Group Reviewers
Restricted Project
Diff Detail
Diff Detail
- Repository
- rK kolab
- Branch
- dev/mollekopf
- Lint
Lint Warnings Severity Location Code Message Warning src/app/Wallet.php:749 PHPCS.W.Generic.Files.LineLength.TooLong Generic.Files.LineLength.TooLong - Unit
No Test Coverage - Build Status
Buildable 45874 Build 17749: arc lint + arc unit
Event Timeline
| src/app/Http/Controllers/API/V4/PolicyController.php | ||
|---|---|---|
| 148 | This will make the 100%-discounted users also being limited. I'm not sure it's intentional. | |
| 149 | This way the limit is shared by all users in an account. Might be too small for bigger accounts. How about where('user_id', $user->id) instead? | |
| 151–157 | No need for $count variable. | |
| src/app/Wallet.php | ||
| 754 | The argument is not documented. And maybe it should be $minPaymentsCount. | |