Details
- Reviewers
machniak - Group Reviewers
Restricted Project - Commits
- rKd2771e8d54fd: Setup all a tenant needs in a single command
Diff Detail
- Repository
- rK kolab
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
| src/app/Console/Commands/Tenant/CreateCommand.php | ||
|---|---|---|
| 38 | There might be a soft-deleted user with this email, we should validate that. Also we probably should validate the email address itself. | |
| 162 | What if the domain isn't public? I think we should bail out. | |
| 167 | If it existed before it's not "created". | |
| 173 | These have to be URLs. I.e. https:// prefix needs to be added. | |
| src/app/Console/Commands/Tenant/CreateCommand.php | ||
|---|---|---|
| 174 | These are mail.* options. | |
To be able to validate things we now just validate first, and then create everything, and bail out if user or domain are preexisting.
There's doesn't seem to really be a point in converting existing users.
| src/app/Console/Commands/Tenant/CreateCommand.php | ||
|---|---|---|
| 140–141 | This part made sense with an existing user. Useless now. | |
| src/tests/Feature/Console/Tenant/CreateTest.php | ||
| 20 | test-tenant@kolabnow.com is not used anymore in the test | |
| 41 | test-tenant@kolabnow.com is not used anymore in the test. | |
| 74 | I suppose you planned to use that userId in tearDown(), but it's not really needed. | |