- Disable jsnlog's error handlers added in OpenVidu 2.18
- Feed Queries
- All Stories
- Search
- Feed Search
- Transactions
- Transaction Logs
Jun 12 2021
Jun 11 2021
Jun 10 2021
- Add test for localization in getWalletNotice()
Jun 9 2021
Jun 8 2021
Jun 4 2021
Jun 1 2021
- Simplify again
- Simplify/Unify
- Couple of fixes, tenant-condition for wallets
May 27 2021
To sum up the current state:
- All tests pass!
- Tokens refresh request is fast now, but /auth/login is still 0.3-0.4 sec. I didn't investigate how much of that is passport.
- We should probably add some code to Kernel as in https://laravel.com/docs/6.x/passport#purging-tokens
- @vanmeeuwen, should take a look at this regarding deployment of the oauth keys and client secret (and ./artisan passport:keys --force) - we need the same keys on every Kolab4 host.
On the other hand, maybe %dms format would be better for query time.
May 26 2021
- Add exportPublicKey() use
- Use Laravel's Storage functionality
May 25 2021
- Switch new keypair algorithms to RSA
May 21 2021
I did another run of tests and got the same result as above. I.e. I run vendor/bin/phpunit tests/Browser/Admin twice on master and all is green. Then I run the same on this diff and I got three tests failing. Looks like the problem is with refreshing the token. I see this in console dump:
https:\/\/admin.alec.dev.kolab.io\/api\/auth\/info?refresh=1 - Failed to load resource: the server responded with a status of 401 ()
I see C: POST https://admin.alec.dev.kolab.io/api/auth/info?refresh=1 [5M]: 0.0055 sec in the log and this is strange because it's too fast and there are no sql queries for this request logged.
May 20 2021
phpstan errors:
Line app/Http/Controllers/API/AuthController.php ------ ------------------------------------------------------------- 157 Access to an undefined property object::$error_description. ------ -------------------------------------------------------------
May 19 2021
There was 1 error:
May 18 2021
May 14 2021
May 13 2021
- Add tests
- Debit reseller's wallet on user deletion (for the negative balance value)
- Credit/debit reseller's wallet on Penalize/Award action
May 12 2021
- Migration fixes, tests fixes, added some simple tests
May 11 2021
May 8 2021
May 7 2021
May 5 2021
May 4 2021
- See inline comments
- When logging into the user UI I see this in the log:
[2021-05-04 09:27:08] local.DEBUG: [SQL] select * from `oauth_clients` where `id` = ? limit 1 [array ( 0 => '1', )] [2021-05-04 09:27:08] local.DEBUG: [SQL] select * from `oauth_clients` where `id` = ? limit 1 [array ( 0 => '1', )]
I.e. a duplicated query. Would be good to investigate why it is done twice.
- Token refresh does not work. A scenario:
- set token_expiry_minutes = 1 minute,
- log in to the UI, and wait a minute,
- you'll see that the refresh request returns 401 Unauthorized.
- in log: The resource owner or authorization server denied the request. {"exception":"[object] (League\\OAuth2\\Server\\Exception\\OAuthServerException(code: 9): The resource owner or authorization server denied the request. at /home/alec/repos/kolab/src/vendor/league/oauth2-server/src/Exception/OAuthServerException.php:243).
- I guess you just have to add refresh_token to the request in line 166 of app.js.
- When runing Feature suite tests I got 3 errors:
1) Tests\Feature\Controller\PasswordResetTest::testPasswordResetValidInput ErrorException: Undefined property: stdClass::$access_token 2) Tests\Feature\Controller\SignupTest::testSignupValidInput ErrorException: Undefined property: stdClass::$access_token 3) Tests\Feature\Controller\SignupTest::testSignupGroupAccount ErrorException: Undefined property: stdClass::$access_token
- Look like a few browser test failures are also related to Undefined property: stdClass::$access_token.
- We should think how deploy encryption keys across multiple hosts.
- Could https://github.com/laravel/passport/issues/379 be a problem for us in any way considering our future use of Passport?
May 3 2021
Apr 30 2021
Apr 28 2021
Apr 27 2021
@mollekopf Ready for the final review.
- Add wording for the invitation email
- Don't process csv if any email address is invalid
- Cleanup
Apr 26 2021
- Small css improvements to the page menu
- Store user language in a cookie, always load English
- Small code cleanup
- Update tests
- Small linting fixes
- Browser test for the language selector
Apr 23 2021
- Rebase
- Improve language selector
- Store UI localization in php file
- Remove unused Laravel localization files
Just code review. I didn't look closer to this yet.
Apr 21 2021
I don't like that output format. How did you get to the problem? Maybe you should use Carbon objects instead.