Page MenuHomePhorge
Feed Search

Mar 22 2021

machniak requested review of D2395: Localization with vue-i18n.
Mar 22 2021, 12:59 PM
machniak added inline comments to D2383: Convert to foreign currencies using openexchangerates.org.
Mar 22 2021, 10:45 AM
machniak requested changes to D2389: update copyright info.

BTW, It would be nice to use COMPANY_NAME (app.company.name) setting here. I.e. you have to modify App\Utils::uiEnv() to include it.

Mar 22 2021, 10:15 AM
machniak requested changes to D2383: Convert to foreign currencies using openexchangerates.org.
Mar 22 2021, 9:26 AM
machniak requested changes to D2239: New Payment dialog structure.
Mar 22 2021, 8:58 AM
machniak committed rK6e713f8d557b: Attempt to fix all users chart.
Mar 22 2021, 8:48 AM

Mar 21 2021

machniak committed rRPK315c6ec7a0d5: Tasklist: Fix list scrolling in Elastic on touch devices.
Mar 21 2021, 10:34 AM
machniak committed rRPK39bf64e680c0: Fix 'complete' status of new tasks when using DB driver.
Mar 21 2021, 10:16 AM

Mar 19 2021

machniak committed rRPK54f34fa71e91: Fix logging XML.
Mar 19 2021, 11:30 AM
machniak committed rRPKd886a3bdfc4f: Fix fatal error introduced with 'kolab_format_error_log'.
Mar 19 2021, 8:02 AM

Mar 18 2021

machniak added a comment to D2239: New Payment dialog structure.

@mollekopf, it looks good. Please, fix phpstan/phpcs issues and we're good to go.

Mar 18 2021, 1:24 PM
machniak requested review of D2377: [WIP] Resellers: Signup with approval.
Mar 18 2021, 12:40 PM
machniak committed rK83a4a4f1731b: Make Reseller/UsersController more complete.
Mar 18 2021, 9:05 AM

Mar 17 2021

machniak committed rK0cd56e7edfea: Remove redundant code that sets tenant_id on signup.
Mar 17 2021, 1:47 PM
machniak updated the diff for D2371: Degraded accounts.
  • Simplify
Mar 17 2021, 1:17 PM
machniak committed rRPK5e3b3c455a33: Add a way to log xml payload on kolab format error.
Mar 17 2021, 12:39 PM
machniak requested changes to D2239: New Payment dialog structure.
Mar 17 2021, 10:30 AM

Mar 15 2021

machniak updated the diff for D2371: Degraded accounts.
  • Add periodic reminder mail to degraded accounts
Mar 15 2021, 11:51 AM
machniak committed rK6c977059d6e2: Fix error found by phpstan.
Mar 15 2021, 6:59 AM

Mar 12 2021

machniak committed rKd9047561a2c3: Fix discounts command test.
Mar 12 2021, 1:01 PM
machniak committed rK1dba5a20f970: withEnvTenant and withUserTenant macros.
Mar 12 2021, 12:56 PM
machniak committed rK6b4d908f2c5a: Revert "Add degraded status to user:status command".
Mar 12 2021, 11:16 AM
machniak added a reverting change for rKc441d3ca2090: Add degraded status to user:status command: rK6b4d908f2c5a: Revert "Add degraded status to user:status command".
Mar 12 2021, 11:16 AM
machniak updated the diff for D2371: Degraded accounts.
  • Add degraded status to user:status command
  • Add degraded status to some cli commands
Mar 12 2021, 11:15 AM
machniak committed rKaa548e2a3eff: Lock wallet:check to the current tenant.
Mar 12 2021, 11:08 AM
machniak committed rKc441d3ca2090: Add degraded status to user:status command.
Mar 12 2021, 8:32 AM
machniak committed rK7d26f715e5ad: Add some reseller tests.
Mar 12 2021, 8:19 AM

Mar 11 2021

machniak committed rK36ca71b22847: Reseller app engine.
Mar 11 2021, 1:29 PM
machniak committed rI10ba0ec3c67d: Make sure to not respond with invalid data (skip invalid event objects).
Mar 11 2021, 9:16 AM
machniak updated the diff for D2371: Degraded accounts.
  • Fix quota/roles of a degraded user
Mar 11 2021, 8:18 AM

Mar 10 2021

machniak retitled D2371: Degraded accounts from [WIP] Degraded accounts
Mar 10 2021, 1:53 PM
machniak updated the diff for D2371: Degraded accounts.
  • Browser tests
Mar 10 2021, 1:42 PM

Mar 9 2021

machniak updated the diff for D2371: Degraded accounts.
  • Tests
Mar 9 2021, 3:08 PM

Mar 8 2021

machniak committed rRPK2129b4e2c0e1: Fix PHP warnings.
Mar 8 2021, 1:31 PM
machniak retitled D2371: Degraded accounts from {WIP] Degraded accounts to [WIP] Degraded accounts.
Mar 8 2021, 12:35 PM
machniak requested review of D2371: Degraded accounts.
Mar 8 2021, 12:19 PM

Mar 5 2021

machniak requested changes to D2239: New Payment dialog structure.
Mar 5 2021, 9:19 AM
machniak requested review of D2365: Fix invalid period in a wallet notice text.
Mar 5 2021, 8:07 AM

Mar 3 2021

machniak added inline comments to D2239: New Payment dialog structure.
Mar 3 2021, 7:43 PM
machniak requested review of D2359: Fix jobs resilience to db replication delay.
Mar 3 2021, 2:44 PM

Mar 2 2021

machniak added a comment to D2239: New Payment dialog structure.

Also, because it's likely that user will open both Add credit and Setup auto-payment dialogs. It would make sense to fetch the list of payment methods only once. I.e. it could return all methods with some type flag so we could filter it client-side.

Mar 2 2021, 11:32 AM
machniak requested changes to D2239: New Payment dialog structure.
Mar 2 2021, 10:57 AM

Feb 26 2021

machniak updated the diff for D2341: Meet: Ignore 'nomedia' option when acting as a room owner.
  • Fix disappearing subscribers list
Feb 26 2021, 1:16 PM
machniak requested review of D2347: Meet: Dark toolbar in fullscreen mode.
Feb 26 2021, 12:58 PM
machniak requested review of D2341: Meet: Ignore 'nomedia' option when acting as a room owner.
Feb 26 2021, 10:00 AM
machniak committed rK8395368f26a9: Fix chart issue (T417650).
Feb 26 2021, 8:33 AM

Feb 25 2021

machniak committed rK1a566292dc60: Stats: Fix inconsistent week period formatting in SQL query.
Feb 25 2021, 1:16 PM

Feb 24 2021

machniak requested review of D2335: Meet: Various fixes for mobile.
Feb 24 2021, 12:21 PM
machniak requested changes to D2239: New Payment dialog structure.
Feb 24 2021, 10:09 AM

Feb 23 2021

machniak updated the diff for D2329: Meet: Fix toolbar regressions.
  • Add participants counter
Feb 23 2021, 3:22 PM
machniak committed rFcc9b4af1e996: Fix allow_token=true mode.
Feb 23 2021, 8:53 AM

Feb 22 2021

machniak requested changes to D2239: New Payment dialog structure.
Feb 22 2021, 5:42 PM
machniak requested review of D2329: Meet: Fix toolbar regressions.
Feb 22 2021, 3:09 PM
machniak abandoned D2293: room color overhaul.
Feb 22 2021, 1:35 PM

Feb 19 2021

machniak committed rK5c8b1bbe2ff3: Fix linting issues.
Feb 19 2021, 12:57 PM
machniak requested review of D2311: Store wallet transaction's amount with a sign.
Feb 19 2021, 12:44 PM
machniak requested review of D2305: Meet: Remove header/footer in the room.
Feb 19 2021, 10:12 AM

Feb 18 2021

machniak requested changes to D2293: room color overhaul.
  • The grey status icons without the slash, do not indicate the muted state properly. Use red background here or icons with expunction element.
  • Enabled (muted) sound and video buttons have different size, which is not nice.
  • Screen sharing and hand button do not work. Some code still uses .text-danger to get the button state.
  • Browser tests need to be modified (.text-danger class)
  • Shouldn't the chat button also have the switched-on state when the chat widget is visible? The same as the hand or mute buttons.
  • I think there's too many elements in gray scale, the UI looks sad.
  • The chat background is too dark, the textarea does not look great with such a background.
  • If you join the room as a subscriber, the mute buttons are html-disabled, but have the background set, this looks strange. I don't know maybe the buttons (not icons) should be smaller, or just should not indicate switched-on state when disabled.
Feb 18 2021, 11:40 AM
machniak requested changes to D2239: New Payment dialog structure.
Feb 18 2021, 10:04 AM
machniak updated the diff for D2299: Meet: Display shared screen bigger.
  • Fix subscribers list height when there's no publishers in the room
Feb 18 2021, 9:25 AM
machniak requested review of D2299: Meet: Display shared screen bigger.
Feb 18 2021, 9:17 AM
machniak requested changes to D2287: moderator is no king but gets a cowboy hat.

Fine with me. If this does not break any browser test assertions, then we should add some. Search for assertUserIcon

Feb 18 2021, 6:45 AM

Feb 17 2021

machniak added a comment to D2269: hide menubar when in rooms.

Is this what you want instead: https://git.kolab.org/D2281 ?

Feb 17 2021, 9:47 AM

Feb 16 2021

machniak committed rK4d569e002b64: OpenVidu: Store join request identifier in localStorage.
Feb 16 2021, 2:54 PM
machniak closed D2068: OpenVidu: Store join request identifier in localStorage.
Feb 16 2021, 2:54 PM
machniak committed rKb3cb2a9bad2b: Meet: Fix javascript error when leaving a room.
Feb 16 2021, 2:54 PM
machniak closed D2263: Meet: Fix javascript error when leaving a room.
Feb 16 2021, 2:54 PM
machniak added a comment to D2275: improve room icons.

Maybe we should apply it anyway, and revisit again now that we have even more buttons (hand and channels) in the toolbar.

Feb 16 2021, 2:27 PM
machniak added a comment to D2275: improve room icons.

As for the chat icon and status icons change I'm ok with this. But I'm not sure about the rest.

Feb 16 2021, 2:22 PM
machniak added a comment to D2269: hide menubar when in rooms.

The idea was to hide the menu/footer inside the room, i.e. after joining in, but room setup screen should have the menu as usual. I also don't like making component/page specific exceptions in the Menu widget. I would probably do it with css. Also the code added in Room.vue asks for some deduplication, i.e. we need a method on the $root component that could be re-used as we have the same code in at least two places now. Not to mention that in this state some browser tests will fail (but I didn't check yet).

Feb 16 2021, 2:17 PM
machniak requested review of D2263: Meet: Fix javascript error when leaving a room.
Feb 16 2021, 12:36 PM

Feb 15 2021

machniak committed rKe808cfecc263: Fix js error after merge(s).
Feb 15 2021, 12:28 PM

Feb 12 2021

machniak updated the diff for D2257: Meet: A room config option to force all to join as subscribers.
  • Add forgotten component
Feb 12 2021, 1:36 PM
machniak requested review of D2257: Meet: A room config option to force all to join as subscribers.
Feb 12 2021, 1:34 PM
machniak requested review of D2251: Meet: Mute microphone with M key.
Feb 12 2021, 12:03 PM
machniak updated the summary of D2245: Meet: Language interpreters.
Feb 12 2021, 11:05 AM
machniak requested review of D2245: Meet: Language interpreters.
Feb 12 2021, 10:56 AM

Feb 8 2021

machniak requested review of D2233: Meet: Q&A queue (raise hand feature).
Feb 8 2021, 11:55 AM

Feb 5 2021

machniak requested review of D2227: Meet: Fix replaceTrack() bug.
Feb 5 2021, 1:24 PM

Feb 4 2021

machniak added inline comments to D1924: Restoring a user/domain.
Feb 4 2021, 1:41 PM
machniak updated the diff for D2068: OpenVidu: Store join request identifier in localStorage.

Rebase

Feb 4 2021, 9:11 AM
machniak committed rKbb7c64d867f6: De-deuplicate some tests code.
Feb 4 2021, 9:05 AM
machniak committed rKe4a2e7060d30: Meet: Improved error handling.
Feb 4 2021, 7:30 AM
machniak closed D2203: Meet: Improved error handling.
Feb 4 2021, 7:30 AM
machniak committed rKaa1418383a70: Meet: Fix chat scrolling.
Feb 4 2021, 7:30 AM
machniak closed D2209: Meet: Fix chat scrolling.
Feb 4 2021, 7:30 AM

Feb 3 2021

machniak added inline comments to D2221: On promotion to publisher display the media setup dialog.
Feb 3 2021, 3:18 PM
machniak updated the diff for D2203: Meet: Improved error handling.
  • Remove redundant condition
Feb 3 2021, 2:21 PM
machniak requested review of D2221: On promotion to publisher display the media setup dialog.
Feb 3 2021, 2:16 PM
machniak accepted D2215: If the refund amount is positive, we need to turn that frown upside down.
Feb 3 2021, 1:55 PM
machniak planned changes to D2203: Meet: Improved error handling.

I'll review this again regarding 422 handling.

Feb 3 2021, 1:42 PM
machniak added inline comments to D2203: Meet: Improved error handling.
Feb 3 2021, 1:04 PM

Feb 2 2021

machniak requested changes to D1954: ux cleanup. move 'delete account' button to the top.

A couple of browser tests need to be modified in tests/Browser/UsersTest.php

Feb 2 2021, 12:49 PM
machniak requested review of D2209: Meet: Fix chat scrolling.
Feb 2 2021, 10:51 AM
machniak requested review of D2203: Meet: Improved error handling.
Feb 2 2021, 10:49 AM

Feb 1 2021

machniak added a comment to D2137: add charge period to transactions.

And of course some tests will be needed.

Feb 1 2021, 11:45 AM
machniak requested changes to D2137: add charge period to transactions.
Feb 1 2021, 11:34 AM
machniak committed rKe4bb4f88f6e1: Fix type hint.
Feb 1 2021, 10:47 AM
machniak committed rKe968a6ccf02d: Improve handling of screen-sharing connection tokens.
Feb 1 2021, 10:47 AM
machniak committed rK345ce72e058c: OpenVidu: Moderators.
Feb 1 2021, 10:47 AM