Page MenuHomePhorge

room color overhaul
AbandonedPublic

Authored by bohlender on Feb 17 2021, 5:56 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Nov 28, 9:23 PM
Unknown Object (File)
Fri, Nov 17, 3:15 AM
Unknown Object (File)
Sat, Nov 4, 9:47 AM
Unknown Object (File)
Nov 1 2023, 7:24 AM
Unknown Object (File)
Oct 31 2023, 4:35 PM
Unknown Object (File)
Oct 17 2023, 10:08 AM
Unknown Object (File)
Oct 5 2023, 7:30 AM
Unknown Object (File)
Oct 1 2023, 1:59 AM
Subscribers

Details

Reviewers
machniak
Group Reviewers
Restricted Project

Diff Detail

Repository
rK kolab
Branch
colors
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 33274
Build 13048: arc lint + arc unit

Event Timeline

bohlender created this revision.
bohlender added a reviewer: Restricted Project.Feb 17 2021, 5:57 PM
machniak subscribed.
  • The grey status icons without the slash, do not indicate the muted state properly. Use red background here or icons with expunction element.
  • Enabled (muted) sound and video buttons have different size, which is not nice.
  • Screen sharing and hand button do not work. Some code still uses .text-danger to get the button state.
  • Browser tests need to be modified (.text-danger class)
  • Shouldn't the chat button also have the switched-on state when the chat widget is visible? The same as the hand or mute buttons.
  • I think there's too many elements in gray scale, the UI looks sad.
  • The chat background is too dark, the textarea does not look great with such a background.
  • If you join the room as a subscriber, the mute buttons are html-disabled, but have the background set, this looks strange. I don't know maybe the buttons (not icons) should be smaller, or just should not indicate switched-on state when disabled.
This revision now requires changes to proceed.Feb 18 2021, 12:40 PM