Page MenuHomekolab.org

room color overhaul
AbandonedPublic

Authored by bohlender on Feb 17 2021, 5:56 PM.

Details

Reviewers
machniak
Group Reviewers
Restricted Project

Diff Detail

Repository
rK kolab
Branch
colors
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 33274
Build 13048: arc lint + arc unit

Event Timeline

bohlender requested review of this revision.Feb 17 2021, 5:56 PM
bohlender created this revision.
bohlender added a reviewer: Restricted Project.Feb 17 2021, 5:57 PM
machniak requested changes to this revision.Feb 18 2021, 12:40 PM
machniak added a subscriber: machniak.
  • The grey status icons without the slash, do not indicate the muted state properly. Use red background here or icons with expunction element.
  • Enabled (muted) sound and video buttons have different size, which is not nice.
  • Screen sharing and hand button do not work. Some code still uses .text-danger to get the button state.
  • Browser tests need to be modified (.text-danger class)
  • Shouldn't the chat button also have the switched-on state when the chat widget is visible? The same as the hand or mute buttons.
  • I think there's too many elements in gray scale, the UI looks sad.
  • The chat background is too dark, the textarea does not look great with such a background.
  • If you join the room as a subscriber, the mute buttons are html-disabled, but have the background set, this looks strange. I don't know maybe the buttons (not icons) should be smaller, or just should not indicate switched-on state when disabled.
This revision now requires changes to proceed.Feb 18 2021, 12:40 PM
machniak abandoned this revision.Feb 22 2021, 2:35 PM