Page MenuHomekolab.org

Fix invalid period in a wallet notice text
ClosedPublic

Authored by machniak on Mar 5 2021, 9:07 AM.

Details

Reviewers
vanmeeuwen
Group Reviewers
Restricted Project
Commits
rKb8639bdf84cc: Fix invalid period in a wallet notice text
Summary

According to one test assertion on 2021-03-05 we expect "... will last until about 2021-04-02 (4 weeks)."
This test was failing occasionally.

I found that one of the dates we were comparing was N microseconds ahead.
So, the period was less than a second shorter. Carbon didn't round this.

A solution is to just use the same time on both compared dates.

Test Plan

./phpunit

Diff Detail

Repository
rK kolab
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

machniak created this revision.Mar 5 2021, 9:07 AM
machniak requested review of this revision.Mar 5 2021, 9:07 AM
vanmeeuwen accepted this revision.Mar 13 2021, 9:33 AM
This revision is now accepted and ready to land.Mar 13 2021, 9:33 AM
This revision was automatically updated to reflect the committed changes.