Page MenuHomePhorge

Fix invalid period in a wallet notice text
ClosedPublic

Authored by machniak on Mar 5 2021, 9:07 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Apr 13, 3:01 AM
Unknown Object (File)
Thu, Apr 11, 5:35 AM
Unknown Object (File)
Thu, Apr 4, 9:03 PM
Unknown Object (File)
Mar 17 2024, 4:00 AM
Unknown Object (File)
Mar 12 2024, 12:34 PM
Unknown Object (File)
Feb 23 2024, 6:27 PM
Unknown Object (File)
Jan 24 2024, 2:17 PM
Unknown Object (File)
Jan 24 2024, 2:15 PM
Subscribers
Restricted Project

Details

Reviewers
vanmeeuwen
Group Reviewers
Restricted Project
Commits
rKb8639bdf84cc: Fix invalid period in a wallet notice text
Summary

According to one test assertion on 2021-03-05 we expect "... will last until about 2021-04-02 (4 weeks)."
This test was failing occasionally.

I found that one of the dates we were comparing was N microseconds ahead.
So, the period was less than a second shorter. Carbon didn't round this.

A solution is to just use the same time on both compared dates.

Test Plan

./phpunit

Diff Detail

Repository
rK kolab
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision is now accepted and ready to land.Mar 13 2021, 9:33 AM
This revision was automatically updated to reflect the committed changes.