Page MenuHomekolab.org

Meet: Display shared screen bigger
ClosedPublic

Authored by machniak on Thu, Feb 18, 10:17 AM.

Details

Reviewers
vanmeeuwen
Group Reviewers
Restricted Project
Commits
rK784f45f56b33: Meet: Display shared screen bigger
Summary

The (first) shared screen element will take up to 2/3 of the
matrix's width and 100% of its height. Other publishers (including other
shared screens) will fill the rest.

Also fixes small bug with too-big subscribers list height in some cases.

Future scope:

  1. Display the shared screen publisher inside the shared screen tile.
  2. Add a button to increase size of any publisher tile. Still, I think there should be only one big tile at a time. Anything more sophisticated requires a much harder algorithm.
Test Plan

./phpunit --group=openvidu

Diff Detail

Repository
rK kolab
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

machniak created this revision.Thu, Feb 18, 10:17 AM
machniak requested review of this revision.Thu, Feb 18, 10:17 AM
machniak updated this revision to Diff 6409.Thu, Feb 18, 10:25 AM
  • Fix subscribers list height when there's no publishers in the room
vanmeeuwen accepted this revision.Fri, Feb 19, 1:12 PM
This revision is now accepted and ready to land.Fri, Feb 19, 1:12 PM
This revision was automatically updated to reflect the committed changes.