Page MenuHomePhorge
Feed All Stories

Jun 13 2024

mollekopf accepted D4791: Add tenant context to signup codes.
Jun 13 2024, 7:28 PM
mollekopf abandoned D4785: Make user:create multi-tenant compatible.
Jun 13 2024, 7:23 PM
mollekopf updated the diff for D4782: Allow creating users in public domains.

Removed print statement

Jun 13 2024, 7:23 PM
mollekopf updated the diff for D4776: Setup all a tenant needs in a single command.

To be able to validate things we now just validate first, and then create everything, and bail out if user or domain are preexisting.
There's doesn't seem to really be a point in converting existing users.

Jun 13 2024, 2:32 PM
mollekopf accepted D4752: Make CLI commands tenant independent.
Jun 13 2024, 2:21 PM
machniak committed rKcb18e6205eaf: Add test for Domain::assignPackage(), also throw exception in a sanity check.
Jun 13 2024, 12:39 PM
mollekopf updated the diff for D4776: Setup all a tenant needs in a single command.

Fixed mail options

Jun 13 2024, 11:44 AM
machniak abandoned D4755: Multitenant ready signup mail.

See D4791: Add tenant context to signup codes

Jun 13 2024, 10:57 AM
machniak requested review of D4791: Add tenant context to signup codes.
Jun 13 2024, 10:56 AM
mollekopf updated the diff for D4755: Multitenant ready signup mail.

Adapt to recent changes

Jun 13 2024, 10:43 AM
machniak added inline comments to D4776: Setup all a tenant needs in a single command.
Jun 13 2024, 10:06 AM
machniak accepted D4731: Update mediasoup-client.
Jun 13 2024, 7:58 AM
machniak requested changes to D4782: Allow creating users in public domains.
Jun 13 2024, 7:58 AM
machniak closed D4749: Make scheduled commands to work for all tenants (not the configured one).
Jun 13 2024, 7:54 AM
machniak committed rKc5edae74b47b: Make scheduled commands to work for all tenants (not the configured one).
Jun 13 2024, 7:53 AM
mollekopf committed rK197a6f0e9f40: Fixed WalletTest.
Jun 13 2024, 7:36 AM
mollekopf closed T8370: Certificate of https://obs.kolabsys.com has expired as Resolved.

Fixed, sorry about the downtime.

Jun 13 2024, 6:45 AM

Jun 12 2024

mollekopf abandoned D4737: Only start rate-limiting once balance goes below -10.

https://phorge.apps.ocp04.ait-msp-infra.net/T265

Jun 12 2024, 1:42 PM
mollekopf added a comment to D4737: Only start rate-limiting once balance goes below -10.

it's not, and I'm also not sure if this really solves anything since we actually try to keep the balance around 10 CHF (I think?). Maybe the better solution would be to just prominently display a warning that the user is being rate limited.

Jun 12 2024, 1:42 PM
mollekopf closed D4788: APP_NAME independent redis prefixes.
Jun 12 2024, 1:25 PM
machniak updated the diff for D4752: Make CLI commands tenant independent.
  • Complete tenant-independence in CLI commands
  • Fix regression, cleanup
Jun 12 2024, 1:05 PM
mollekopf closed D4217: Log spf failure reasons.
Jun 12 2024, 12:34 PM
mollekopf committed rK3cae85929a7a: Log spf failure reasons.
Jun 12 2024, 12:34 PM
mollekopf closed D4779: Configure logging based on the debug flag not the environment.
Jun 12 2024, 12:34 PM
mollekopf closed D4773: We use this from the admin seeder.
Jun 12 2024, 12:34 PM
mollekopf committed rK930ff0eab429: We use this from the admin seeder.
Jun 12 2024, 12:34 PM
mollekopf committed rKbce992ed61fb: Configure logging based on the debug flag not the environment.
Jun 12 2024, 12:34 PM
mollekopf committed rK06aaedc7bfd8: APP_NAME independent redis prefixes.
Jun 12 2024, 12:34 PM
machniak accepted D4788: APP_NAME independent redis prefixes.

Be careful when deploying this. Make sure the queue is empty.

Jun 12 2024, 12:07 PM
machniak accepted D4773: We use this from the admin seeder.
Jun 12 2024, 11:05 AM
mollekopf updated the diff for D4773: We use this from the admin seeder.

We want to use app.password only when *not* in production of course

Jun 12 2024, 11:02 AM
mollekopf requested review of D4788: APP_NAME independent redis prefixes.
Jun 12 2024, 10:42 AM
machniak requested changes to D4776: Setup all a tenant needs in a single command.
Jun 12 2024, 8:24 AM
machniak added a comment to D4755: Multitenant ready signup mail.

This changes nothing if we run the jobs on the main system. But I agree we need a tenant context. See T264 in Phorge.

Jun 12 2024, 7:00 AM
machniak requested changes to D4773: We use this from the admin seeder.

This make app.passphrase to be used only on production, which is wrong.

Jun 12 2024, 6:56 AM
machniak accepted D4779: Configure logging based on the debug flag not the environment.
Jun 12 2024, 6:54 AM
machniak added a comment to D4785: Make user:create multi-tenant compatible.

I don't think this makes sense, because the same is done by the observer already.

Jun 12 2024, 6:53 AM

Jun 11 2024

mollekopf abandoned D4767: Allow creating users in public domains.
Jun 11 2024, 8:25 PM
mollekopf added a reviewer for D4782: Allow creating users in public domains: Restricted Project.

I used this to create new users on demoresller.kolab.klab.cc and I don't see why not.

Jun 11 2024, 8:24 PM
mollekopf added a reviewer for D4785: Make user:create multi-tenant compatible: Restricted Project.
Jun 11 2024, 8:24 PM
mollekopf added a reviewer for D4779: Configure logging based on the debug flag not the environment: Restricted Project.
Jun 11 2024, 8:23 PM
mollekopf added a reviewer for D4776: Setup all a tenant needs in a single command: Restricted Project.
Jun 11 2024, 8:23 PM
mollekopf added a comment to D4773: We use this from the admin seeder.

I guess not setting a password would be an alternative if that works... The random password is just there until somebody sets one that somebody knows.

Jun 11 2024, 8:22 PM
mollekopf added a reviewer for D4773: We use this from the admin seeder: Restricted Project.
Jun 11 2024, 8:21 PM
mollekopf added a reviewer for D4755: Multitenant ready signup mail: Restricted Project.
Jun 11 2024, 8:20 PM
mollekopf abandoned D4764: Configure logging based on the debug flag not the environment.
Jun 11 2024, 8:20 PM
mollekopf abandoned D4770: Make user:create multi-tenant compatible.
Jun 11 2024, 8:19 PM
mollekopf abandoned D4761: Setup all a tenant needs in a single command.
Jun 11 2024, 8:19 PM
mollekopf abandoned D4758: We use this from the admin seeder.
Jun 11 2024, 8:19 PM
mollekopf updated the diff for D4755: Multitenant ready signup mail.

No changes

Jun 11 2024, 8:18 PM
mollekopf requested review of D4785: Make user:create multi-tenant compatible.
Jun 11 2024, 8:18 PM
mollekopf requested review of D4782: Allow creating users in public domains.
Jun 11 2024, 8:18 PM
mollekopf requested review of D4779: Configure logging based on the debug flag not the environment.
Jun 11 2024, 8:18 PM
mollekopf requested review of D4776: Setup all a tenant needs in a single command.
Jun 11 2024, 8:18 PM
mollekopf requested review of D4773: We use this from the admin seeder.
Jun 11 2024, 8:18 PM
mollekopf requested review of D4770: Make user:create multi-tenant compatible.
Jun 11 2024, 8:16 PM
mollekopf requested review of D4767: Allow creating users in public domains.
Jun 11 2024, 8:16 PM
mollekopf requested review of D4764: Configure logging based on the debug flag not the environment.
Jun 11 2024, 8:15 PM
mollekopf requested review of D4761: Setup all a tenant needs in a single command.
Jun 11 2024, 8:15 PM
mollekopf requested review of D4758: We use this from the admin seeder.
Jun 11 2024, 8:15 PM
mollekopf requested review of D4755: Multitenant ready signup mail.
Jun 11 2024, 8:13 PM
machniak requested review of D4752: Make CLI commands tenant independent.
Jun 11 2024, 1:17 PM
mollekopf accepted D4749: Make scheduled commands to work for all tenants (not the configured one).
Jun 11 2024, 12:08 PM
machniak closed D4740: Improve domain:set-wallet.
Jun 11 2024, 10:44 AM
machniak closed D4746: Add email address to body of a mail notification.
Jun 11 2024, 10:43 AM
machniak committed rK2bf8d7f49f82: Improve domain:set-wallet.
Jun 11 2024, 10:43 AM
machniak committed rK78de5dca7158: Add email address to body of a mail notification.
Jun 11 2024, 10:43 AM
machniak requested review of D4749: Make scheduled commands to work for all tenants (not the configured one).
Jun 11 2024, 10:24 AM
machniak added a comment to D4725: Fold WalletCharge and WalletCheck into one.

One more note. Currently if topUpWallet() throws exception (for any reason, e.g. Mollie connection issues) the WalletCharge job will try to top up the wallet again. Here it won't happen, so it will be more fragile to temporary issues with the payment provider. Catching the exception and invoking a separate WalletCharge job might make sense.

Jun 11 2024, 8:44 AM
mollekopf accepted D4740: Improve domain:set-wallet.
Jun 11 2024, 8:21 AM
mollekopf accepted D4746: Add email address to body of a mail notification.
Jun 11 2024, 7:23 AM

Jun 10 2024

machniak updated the diff for D4746: Add email address to body of a mail notification.
  • Update French localization
Jun 10 2024, 1:50 PM
machniak requested review of D4746: Add email address to body of a mail notification.
Jun 10 2024, 12:55 PM
mollekopf committed rKcb10adc231c3: It's kolab-proxy.
Jun 10 2024, 12:11 PM
mollekopf committed rKdc99c6312b1c: Build swoole 5.1.2.
Jun 10 2024, 8:32 AM
mollekopf closed D4743: CompanionApp commands.
Jun 10 2024, 8:30 AM
mollekopf committed rK560ef604802d: CompanionApp commands.
Jun 10 2024, 8:30 AM
machniak accepted D4743: CompanionApp commands.
Jun 10 2024, 7:59 AM
mollekopf added a reviewer for D4743: CompanionApp commands: Restricted Project.
Jun 10 2024, 7:49 AM
mollekopf requested review of D4743: CompanionApp commands.
Jun 10 2024, 7:48 AM

Jun 5 2024

machniak requested review of D4740: Improve domain:set-wallet.
Jun 5 2024, 1:14 PM
machniak added a comment to D4737: Only start rate-limiting once balance goes below -10.

10 here is 0.10 CHF, is this the intention?

Jun 5 2024, 8:15 AM

Jun 4 2024

mollekopf added a reviewer for D4737: Only start rate-limiting once balance goes below -10: Restricted Project.
Jun 4 2024, 3:21 PM
mollekopf requested review of D4737: Only start rate-limiting once balance goes below -10.
Jun 4 2024, 3:06 PM
mollekopf abandoned D4734: npm update.
Jun 4 2024, 1:50 PM
mollekopf added a reviewer for D4731: Update mediasoup-client: Restricted Project.
Jun 4 2024, 1:48 PM
machniak accepted D4734: npm update.

This most likely conflicts on master.

Jun 4 2024, 12:47 PM
machniak abandoned D4713: Laravel Passport v12.

Merged in rK17dc669efeb3af

Jun 4 2024, 12:45 PM
machniak closed D4728: Update Bootstrap and other npm dependencies (fixes security issues).
Jun 4 2024, 12:43 PM
machniak committed rK804c9497c412: Update Bootstrap and other npm dependencies (fixes security issues).
Jun 4 2024, 12:43 PM
machniak closed D4704: Wait for user record in UpdateJob.
Jun 4 2024, 12:42 PM
machniak committed rK1a564c464615: Wait for user record in UpdateJob.
Jun 4 2024, 12:42 PM
mollekopf requested review of D4734: npm update.
Jun 4 2024, 12:34 PM
mollekopf requested review of D4731: Update mediasoup-client.
Jun 4 2024, 12:34 PM
mollekopf committed rK88b133571e27: Make php-sodium available again.
Jun 4 2024, 12:30 PM
mollekopf committed rK17dc669efeb3: Reapply "Laravel Passport v12".
Jun 4 2024, 12:30 PM
mollekopf added a reverting change for rK1e7d7cf82a5b: Revert "Laravel Passport v12": rK17dc669efeb3: Reapply "Laravel Passport v12".
Jun 4 2024, 12:30 PM
mollekopf accepted D4704: Wait for user record in UpdateJob.

A note on why would be good in the commit message.

Jun 4 2024, 12:25 PM
mollekopf planned changes to D4725: Fold WalletCharge and WalletCheck into one.
Jun 4 2024, 12:25 PM
mollekopf accepted D4728: Update Bootstrap and other npm dependencies (fixes security issues).
Jun 4 2024, 12:24 PM