Page MenuHomePhorge
Feed Advanced Search

Mar 24 2021

machniak committed rKd1efae7b8acd: Fix error found by phpstan (authored by machniak).
Fix error found by phpstan
Mar 24 2021, 12:06 PM
machniak committed rKd56a728c84ea: Fix discounts command test (authored by machniak).
Fix discounts command test
Mar 24 2021, 12:06 PM
machniak committed rKa87b08b55ee6: withEnvTenant and withUserTenant macros (authored by machniak).
withEnvTenant and withUserTenant macros
Mar 24 2021, 12:06 PM
machniak committed rKa9e9b6ace234: domain:add -> domain:create, update observer to handle restore() (authored by vanmeeuwen).
domain:add -> domain:create, update observer to handle restore()
Mar 24 2021, 12:06 PM
machniak committed rK27720581f54f: This is in effect an abstract class (authored by vanmeeuwen).
This is in effect an abstract class
Mar 24 2021, 12:06 PM
machniak committed rK80a0a3a80522: Update ObjectDelete and ObjectUpdate commands, and move the dangerous test to… (authored by vanmeeuwen).
Update ObjectDelete and ObjectUpdate commands, and move the dangerous test to…
Mar 24 2021, 12:06 PM
machniak committed rK931e340f02f4: Hide the scalpel commands from the list of artisan commands (authored by vanmeeuwen).
Hide the scalpel commands from the list of artisan commands
Mar 24 2021, 12:06 PM
machniak committed rK681cbaf95011: These are just completely not needed, since there are no direct effects to… (authored by vanmeeuwen).
These are just completely not needed, since there are no direct effects to…
Mar 24 2021, 12:06 PM
machniak committed rK0fe02c32ead6: Transfer commit (authored by vanmeeuwen).
Transfer commit
Mar 24 2021, 12:06 PM
machniak committed rKcb118ee92055: scalpel:discount:merge -> discount:merge (authored by vanmeeuwen).
scalpel:discount:merge -> discount:merge
Mar 24 2021, 12:06 PM
machniak committed rKb26dd227f31d: More complete commands, show-case dangerous delete command in scalpel (authored by vanmeeuwen).
More complete commands, show-case dangerous delete command in scalpel
Mar 24 2021, 12:06 PM
machniak committed rKec8efb4b5c22: Some additional command logic (authored by vanmeeuwen).
Some additional command logic
Mar 24 2021, 12:06 PM
machniak added a reverting change for rKc441d3ca2090: Add degraded status to user:status command: rK1eb51b3c336f: Revert "Add degraded status to user:status command".
Mar 24 2021, 12:06 PM
machniak committed rK1eb51b3c336f: Revert "Add degraded status to user:status command" (authored by machniak).
Revert "Add degraded status to user:status command"
Mar 24 2021, 12:06 PM
machniak committed rK8430974814aa: Lock wallet:check to the current tenant (authored by machniak).
Lock wallet:check to the current tenant
Mar 24 2021, 12:06 PM
machniak committed rKaca52c6d8e13: Add degraded status to user:status command (authored by machniak).
Add degraded status to user:status command
Mar 24 2021, 12:06 PM
machniak committed rK9cc286cfbedd: Add some reseller tests (authored by machniak).
Add some reseller tests
Mar 24 2021, 12:06 PM
machniak committed rKaf4971170e27: Reseller app engine (authored by machniak).
Reseller app engine
Mar 24 2021, 12:06 PM
machniak committed rK06a3d8688152: More changes for the work in progress (authored by vanmeeuwen).
More changes for the work in progress
Mar 24 2021, 12:06 PM
machniak committed rKe4022cc48826: Rebase on master (authored by vanmeeuwen).
Rebase on master
Mar 24 2021, 12:06 PM

Mar 23 2021

machniak updated the summary of D2395: Localization with vue-i18n.
Mar 23 2021, 3:46 PM
machniak updated the summary of D2395: Localization with vue-i18n.
Mar 23 2021, 3:43 PM
machniak updated the diff for D2395: Localization with vue-i18n.
  • Localization engine for theme files
Mar 23 2021, 3:40 PM
machniak updated the summary of D2395: Localization with vue-i18n.
Mar 23 2021, 2:26 PM
machniak updated the diff for D2395: Localization with vue-i18n.
  • Upgrade to laravel-mix v6 (webpack v5) and other js dependencies
  • Don't preload English
Mar 23 2021, 2:24 PM
machniak requested changes to D2239: New Payment dialog structure.

When executing some tests for Stripe:

Mar 23 2021, 12:25 PM
machniak requested changes to D2383: Convert to foreign currencies using openexchangerates.org.

Looks good to me. Two things:

  1. Some tests would be nice.
  2. In bin/quickstart.php we should probably run the command if the api key is set somewhere. And/or maybe we should check-in some already fetched data into the repository. It will be needed for tests.
Mar 23 2021, 11:46 AM
machniak requested review of D2401: Upgrade to laravel-mix v6 (webpack v5) and other js dependencies.
Mar 23 2021, 11:34 AM

Mar 22 2021

machniak requested review of D2395: Localization with vue-i18n.
Mar 22 2021, 1:59 PM
machniak added inline comments to D2383: Convert to foreign currencies using openexchangerates.org.
Mar 22 2021, 11:45 AM
machniak requested changes to D2389: update copyright info.

BTW, It would be nice to use COMPANY_NAME (app.company.name) setting here. I.e. you have to modify App\Utils::uiEnv() to include it.

Mar 22 2021, 11:15 AM
machniak requested changes to D2383: Convert to foreign currencies using openexchangerates.org.
Mar 22 2021, 10:26 AM
machniak requested changes to D2239: New Payment dialog structure.
Mar 22 2021, 9:58 AM
machniak committed rK6e713f8d557b: Attempt to fix all users chart (authored by machniak).
Attempt to fix all users chart
Mar 22 2021, 9:48 AM

Mar 21 2021

machniak committed rRPK315c6ec7a0d5: Tasklist: Fix list scrolling in Elastic on touch devices (authored by machniak).
Tasklist: Fix list scrolling in Elastic on touch devices
Mar 21 2021, 11:34 AM
machniak committed rRPK39bf64e680c0: Fix 'complete' status of new tasks when using DB driver (authored by machniak).
Fix 'complete' status of new tasks when using DB driver
Mar 21 2021, 11:16 AM

Mar 19 2021

machniak committed rRPK54f34fa71e91: Fix logging XML (authored by machniak).
Fix logging XML
Mar 19 2021, 12:30 PM
machniak committed rRPKd886a3bdfc4f: Fix fatal error introduced with 'kolab_format_error_log' (authored by machniak).
Fix fatal error introduced with 'kolab_format_error_log'
Mar 19 2021, 9:02 AM

Mar 18 2021

machniak added a comment to D2239: New Payment dialog structure.

@mollekopf, it looks good. Please, fix phpstan/phpcs issues and we're good to go.

Mar 18 2021, 2:24 PM
machniak requested review of D2377: [WIP] Resellers: Signup with approval.
Mar 18 2021, 1:40 PM
machniak committed rK83a4a4f1731b: Make Reseller/UsersController more complete (authored by machniak).
Make Reseller/UsersController more complete
Mar 18 2021, 10:05 AM

Mar 17 2021

machniak committed rK0cd56e7edfea: Remove redundant code that sets tenant_id on signup (authored by machniak).
Remove redundant code that sets tenant_id on signup
Mar 17 2021, 2:47 PM
machniak updated the diff for D2371: Degraded accounts.
  • Simplify
Mar 17 2021, 2:17 PM
machniak committed rRPK5e3b3c455a33: Add a way to log xml payload on kolab format error (authored by machniak).
Add a way to log xml payload on kolab format error
Mar 17 2021, 1:39 PM
machniak requested changes to D2239: New Payment dialog structure.
Mar 17 2021, 11:30 AM

Mar 15 2021

machniak updated the diff for D2371: Degraded accounts.
  • Add periodic reminder mail to degraded accounts
Mar 15 2021, 12:51 PM
machniak committed rK6c977059d6e2: Fix error found by phpstan (authored by machniak).
Fix error found by phpstan
Mar 15 2021, 7:59 AM

Mar 12 2021

machniak committed rKd9047561a2c3: Fix discounts command test (authored by machniak).
Fix discounts command test
Mar 12 2021, 2:01 PM
machniak committed rK1dba5a20f970: withEnvTenant and withUserTenant macros (authored by machniak).
withEnvTenant and withUserTenant macros
Mar 12 2021, 1:56 PM
machniak committed rK6b4d908f2c5a: Revert "Add degraded status to user:status command" (authored by machniak).
Revert "Add degraded status to user:status command"
Mar 12 2021, 12:16 PM
machniak added a reverting change for rKc441d3ca2090: Add degraded status to user:status command: rK6b4d908f2c5a: Revert "Add degraded status to user:status command".
Mar 12 2021, 12:16 PM
machniak updated the diff for D2371: Degraded accounts.
  • Add degraded status to user:status command
  • Add degraded status to some cli commands
Mar 12 2021, 12:15 PM
machniak committed rKaa548e2a3eff: Lock wallet:check to the current tenant (authored by machniak).
Lock wallet:check to the current tenant
Mar 12 2021, 12:08 PM
machniak committed rKc441d3ca2090: Add degraded status to user:status command (authored by machniak).
Add degraded status to user:status command
Mar 12 2021, 9:32 AM
machniak committed rK7d26f715e5ad: Add some reseller tests (authored by machniak).
Add some reseller tests
Mar 12 2021, 9:19 AM

Mar 11 2021

machniak committed rK36ca71b22847: Reseller app engine (authored by machniak).
Reseller app engine
Mar 11 2021, 2:29 PM
machniak committed rI10ba0ec3c67d: Make sure to not respond with invalid data (skip invalid event objects) (authored by machniak).
Make sure to not respond with invalid data (skip invalid event objects)
Mar 11 2021, 10:16 AM
machniak updated the diff for D2371: Degraded accounts.
  • Fix quota/roles of a degraded user
Mar 11 2021, 9:18 AM

Mar 10 2021

machniak retitled D2371: Degraded accounts from [WIP] Degraded accounts
Mar 10 2021, 2:53 PM
machniak updated the diff for D2371: Degraded accounts.
  • Browser tests
Mar 10 2021, 2:42 PM

Mar 9 2021

machniak updated the diff for D2371: Degraded accounts.
  • Tests
Mar 9 2021, 4:08 PM

Mar 8 2021

machniak committed rRPK2129b4e2c0e1: Fix PHP warnings (authored by machniak).
Fix PHP warnings
Mar 8 2021, 2:31 PM
machniak retitled D2371: Degraded accounts from {WIP] Degraded accounts to [WIP] Degraded accounts.
Mar 8 2021, 1:35 PM
machniak requested review of D2371: Degraded accounts.
Mar 8 2021, 1:19 PM

Mar 5 2021

machniak requested changes to D2239: New Payment dialog structure.
Mar 5 2021, 10:19 AM
machniak requested review of D2365: Fix invalid period in a wallet notice text.
Mar 5 2021, 9:07 AM

Mar 3 2021

machniak added inline comments to D2239: New Payment dialog structure.
Mar 3 2021, 8:43 PM
machniak requested review of D2359: Fix jobs resilience to db replication delay.
Mar 3 2021, 3:44 PM

Mar 2 2021

machniak added a comment to D2239: New Payment dialog structure.

Also, because it's likely that user will open both Add credit and Setup auto-payment dialogs. It would make sense to fetch the list of payment methods only once. I.e. it could return all methods with some type flag so we could filter it client-side.

Mar 2 2021, 12:32 PM
machniak requested changes to D2239: New Payment dialog structure.
Mar 2 2021, 11:57 AM

Feb 26 2021

machniak updated the diff for D2341: Meet: Ignore 'nomedia' option when acting as a room owner.
  • Fix disappearing subscribers list
Feb 26 2021, 2:16 PM
machniak requested review of D2347: Meet: Dark toolbar in fullscreen mode.
Feb 26 2021, 1:58 PM
machniak requested review of D2341: Meet: Ignore 'nomedia' option when acting as a room owner.
Feb 26 2021, 11:00 AM
machniak committed rK8395368f26a9: Fix chart issue (T417650) (authored by machniak).
Fix chart issue (T417650)
Feb 26 2021, 9:33 AM

Feb 25 2021

machniak committed rK1a566292dc60: Stats: Fix inconsistent week period formatting in SQL query (authored by machniak).
Stats: Fix inconsistent week period formatting in SQL query
Feb 25 2021, 2:16 PM

Feb 24 2021

machniak requested review of D2335: Meet: Various fixes for mobile.
Feb 24 2021, 1:21 PM
machniak requested changes to D2239: New Payment dialog structure.
Feb 24 2021, 11:09 AM

Feb 23 2021

machniak updated the diff for D2329: Meet: Fix toolbar regressions.
  • Add participants counter
Feb 23 2021, 4:22 PM
machniak committed rFcc9b4af1e996: Fix allow_token=true mode (authored by machniak).
Fix allow_token=true mode
Feb 23 2021, 9:53 AM

Feb 22 2021

machniak requested changes to D2239: New Payment dialog structure.
Feb 22 2021, 6:42 PM
machniak requested review of D2329: Meet: Fix toolbar regressions.
Feb 22 2021, 4:09 PM
machniak abandoned D2293: room color overhaul.
Feb 22 2021, 2:35 PM

Feb 19 2021

machniak committed rK5c8b1bbe2ff3: Fix linting issues (authored by machniak).
Fix linting issues
Feb 19 2021, 1:57 PM
machniak requested review of D2311: Store wallet transaction's amount with a sign.
Feb 19 2021, 1:44 PM
machniak requested review of D2305: Meet: Remove header/footer in the room.
Feb 19 2021, 11:12 AM

Feb 18 2021

machniak requested changes to D2293: room color overhaul.
  • The grey status icons without the slash, do not indicate the muted state properly. Use red background here or icons with expunction element.
  • Enabled (muted) sound and video buttons have different size, which is not nice.
  • Screen sharing and hand button do not work. Some code still uses .text-danger to get the button state.
  • Browser tests need to be modified (.text-danger class)
  • Shouldn't the chat button also have the switched-on state when the chat widget is visible? The same as the hand or mute buttons.
  • I think there's too many elements in gray scale, the UI looks sad.
  • The chat background is too dark, the textarea does not look great with such a background.
  • If you join the room as a subscriber, the mute buttons are html-disabled, but have the background set, this looks strange. I don't know maybe the buttons (not icons) should be smaller, or just should not indicate switched-on state when disabled.
Feb 18 2021, 12:40 PM
machniak requested changes to D2239: New Payment dialog structure.
Feb 18 2021, 11:04 AM
machniak updated the diff for D2299: Meet: Display shared screen bigger.
  • Fix subscribers list height when there's no publishers in the room
Feb 18 2021, 10:25 AM
machniak requested review of D2299: Meet: Display shared screen bigger.
Feb 18 2021, 10:17 AM
machniak requested changes to D2287: moderator is no king but gets a cowboy hat.

Fine with me. If this does not break any browser test assertions, then we should add some. Search for assertUserIcon

Feb 18 2021, 7:45 AM

Feb 17 2021

machniak added a comment to D2269: hide menubar when in rooms.

Is this what you want instead: https://git.kolab.org/D2281 ?

Feb 17 2021, 10:47 AM

Feb 16 2021

machniak committed rK4d569e002b64: OpenVidu: Store join request identifier in localStorage (authored by machniak).
OpenVidu: Store join request identifier in localStorage
Feb 16 2021, 3:54 PM
machniak closed D2068: OpenVidu: Store join request identifier in localStorage.
Feb 16 2021, 3:54 PM
machniak committed rKb3cb2a9bad2b: Meet: Fix javascript error when leaving a room (authored by machniak).
Meet: Fix javascript error when leaving a room
Feb 16 2021, 3:54 PM
machniak closed D2263: Meet: Fix javascript error when leaving a room.
Feb 16 2021, 3:54 PM
machniak added a comment to D2275: improve room icons.

Maybe we should apply it anyway, and revisit again now that we have even more buttons (hand and channels) in the toolbar.

Feb 16 2021, 3:27 PM
machniak added a comment to D2275: improve room icons.

As for the chat icon and status icons change I'm ok with this. But I'm not sure about the rest.

Feb 16 2021, 3:22 PM
machniak added a comment to D2269: hide menubar when in rooms.

The idea was to hide the menu/footer inside the room, i.e. after joining in, but room setup screen should have the menu as usual. I also don't like making component/page specific exceptions in the Menu widget. I would probably do it with css. Also the code added in Room.vue asks for some deduplication, i.e. we need a method on the $root component that could be re-used as we have the same code in at least two places now. Not to mention that in this state some browser tests will fail (but I didn't check yet).

Feb 16 2021, 3:17 PM
machniak requested review of D2263: Meet: Fix javascript error when leaving a room.
Feb 16 2021, 1:36 PM

Feb 15 2021

machniak committed rKe808cfecc263: Fix js error after merge(s) (authored by machniak).
Fix js error after merge(s)
Feb 15 2021, 1:28 PM