Perhaps drop the temporary table again, but looks reasonable otherwise.

I'm wondering whether there is a cleaner solution to relying on constants being defined in the class from the trait and the objectState function, both seems a bit magic. But since the object states do not mean the same thing between different objects, I can't think of a better solution either.

Thanks for the review! I tried to arc land the changes but seem to lack permission to do so:

Exception: You do not have permission to push to this repository.
fatal: Could not read from remote repository.

Thanks for the excellent work @sicherha!

I don't think the performance impact matters for the uses we have here.

This requires python >= 2.6, which is fine I think.

I have abandoned D3190 and submitted the individual commits in D3223, D3226, D3229, D3232, D3235, D3241 and D3244.

Superseded by D3223, D3226, D3229, D3232, D3235, D3241 and D3244.

Rebased

Rebased

Rebased

Rebased

Rebased and run horizon in the background as well

Various changes

• Small fixes

• Errors/warnings, more tests

Fixed - better late than never.

Submitted D3190, which has ended up being sort of... bulky. There are several commits in this differential; does Phabricator offer no option to review these commits individually like Git{Hu,La}b do, without the author having to create a separate differential per commit?