Page MenuHomePhorge
Differential D3244

[Python 3] Use .items() instead of .iteritems()
ClosedPublic
Actions

Authored by sicherha on Jan 8 2022, 11:39 AM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Jul 22, 2:12 PM
Unknown Object (File)
Fri, Jul 19, 8:22 PM
Unknown Object (File)
Thu, Jul 18, 8:25 PM
Unknown Object (File)
Mon, Jul 15, 5:16 PM
Unknown Object (File)
Sun, Jul 14, 10:36 PM
Unknown Object (File)
Sat, Jul 13, 10:23 PM
Unknown Object (File)
Thu, Jul 4, 3:53 AM
Unknown Object (File)
Fri, Jun 28, 11:47 PM
View All 55 Files
Subscribers
mollekopf

Details

Reviewers
machniak
mollekopf
Commits
rPcfdb3e4f7f15: [Python 3] Use .items() instead of .iteritems()
Summary

.iteritems() was dropped in Python 3.0.

This commit may have a negative performance impact on Python 2 since
.items() returns a copy of the dictionary's item list. In Python 3,
.items() returns a view object, so no performance drop should be
noticeable there.

Diff Detail

Repository
rP pykolab
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

sicherha requested review of this revision.Jan 8 2022, 11:39 AM
sicherha created this revision.
Harbormaster completed remote builds in B37795: Diff 9208.Jan 8 2022, 11:39 AM
sicherha mentioned this in D3190: Python 3 compatibility.Jan 8 2022, 11:42 AM
sicherha mentioned this in T6805: Port pykolab to Python 3.Jan 8 2022, 11:45 AM
mollekopf accepted this revision.Jan 10 2022, 10:14 AM
mollekopf subscribed.

I don't think the performance impact matters for the uses we have here.

This revision is now accepted and ready to land.Jan 10 2022, 10:14 AM
This revision was landed with ongoing or failed builds.Jan 10 2022, 8:51 PM
Closed by commit rPcfdb3e4f7f15: [Python 3] Use .items() instead of .iteritems() (authored by sicherha). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
pykolab/
cli/
2 lines
wap_client/
8 lines
xml/
4 lines
16 lines
2 lines
14 lines
4 lines
4 lines
2 lines
tests/
unit/
40 lines
wallace/
4 lines
2 lines

Diff 9262

View Options

pykolab/cli/cmd_user_info.py

Loading...
View Options

pykolab/wap_client/__init__.py

Loading...
View Options

pykolab/xml/attendee.py

Loading...
View Options

pykolab/xml/contact.py

Loading...
View Options

pykolab/xml/contact_reference.py

Loading...
View Options

pykolab/xml/event.py

Loading...
View Options

pykolab/xml/note.py

Loading...
View Options

pykolab/xml/recurrence_rule.py

Loading...
View Options

pykolab/xml/utils.py

Loading...
View Options

tests/unit/test-002-attendee.py

Loading...
View Options

wallace/module_invitationpolicy.py

Loading...
View Options

wallace/module_signature.py

Loading...