Page MenuHomekolab.org

[Python 3] Use .items() instead of .iteritems()
ClosedPublic

Authored by sicherha on Sat, Jan 8, 11:39 AM.

Details

Summary

.iteritems() was dropped in Python 3.0.

This commit may have a negative performance impact on Python 2 since
.items() returns a copy of the dictionary's item list. In Python 3,
.items() returns a view object, so no performance drop should be
noticeable there.

Diff Detail

Repository
rP pykolab
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

sicherha requested review of this revision.Sat, Jan 8, 11:39 AM
sicherha created this revision.
mollekopf accepted this revision.Mon, Jan 10, 10:14 AM
mollekopf added a subscriber: mollekopf.

I don't think the performance impact matters for the uses we have here.

This revision is now accepted and ready to land.Mon, Jan 10, 10:14 AM
This revision was landed with ongoing or failed builds.Mon, Jan 10, 8:51 PM
This revision was automatically updated to reflect the committed changes.