Page MenuHomePhorge

[Python 3] Use .items() instead of .iteritems()
ClosedPublic

Authored by sicherha on Jan 8 2022, 11:39 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Feb 10, 11:22 AM
Unknown Object (File)
Mon, Jan 29, 11:51 PM
Unknown Object (File)
Jan 16 2024, 6:43 AM
Unknown Object (File)
Jan 14 2024, 12:03 PM
Unknown Object (File)
Jan 1 2024, 6:55 AM
Unknown Object (File)
Dec 5 2023, 12:23 AM
Unknown Object (File)
Dec 1 2023, 1:54 PM
Unknown Object (File)
Dec 1 2023, 6:31 AM
Subscribers

Details

Summary

.iteritems() was dropped in Python 3.0.

This commit may have a negative performance impact on Python 2 since
.items() returns a copy of the dictionary's item list. In Python 3,
.items() returns a view object, so no performance drop should be
noticeable there.

Diff Detail

Repository
rP pykolab
Branch
07-items
Lint
Lint Errors
SeverityLocationCodeMessage
Errorpykolab/wap_client/__init__.py:608E203PEP8 E203
Unit
No Test Coverage
Build Status
Buildable 37795
Build 15241: arc lint + arc unit

Event Timeline

sicherha created this revision.
mollekopf subscribed.

I don't think the performance impact matters for the uses we have here.

This revision is now accepted and ready to land.Jan 10 2022, 10:14 AM
This revision was landed with ongoing or failed builds.Jan 10 2022, 8:51 PM
This revision was automatically updated to reflect the committed changes.