[Python 3] Use .items() instead of .iteritems()
ClosedPublic
Actions

Authored by sicherha on Jan 8 2022, 11:39 AM.

Details

Reviewers

machniak
mollekopf

Commits

rPcfdb3e4f7f15: [Python 3] Use .items() instead of .iteritems()

Summary

.iteritems() was dropped in Python 3.0.

This commit may have a negative performance impact on Python 2 since
.items() returns a copy of the dictionary's item list. In Python 3,
.items() returns a view object, so no performance drop should be
noticeable there.

Diff Detail

Repository

rP pykolab

Branch

07-items

Lint

Lint Errors

Severity	Location	Code	Message
Error	pykolab/wap_client/__init__.py:608	E203	PEP8 E203

Unit

No Unit Test Coverage

Build Status

Buildable 37795
Build 15241: arc lint + arc unit

Event Timeline

sicherha requested review of this revision.Jan 8 2022, 11:39 AM

sicherha created this revision.

Harbormaster completed remote builds in B37795: Diff 9208.Jan 8 2022, 11:39 AM

sicherha mentioned this in D3190: Python 3 compatibility.Jan 8 2022, 11:42 AM

sicherha mentioned this in T6805: Port pykolab to Python 3.Jan 8 2022, 11:45 AM

I don't think the performance impact matters for the uses we have here.

This revision is now accepted and ready to land.Jan 10 2022, 10:14 AM

This revision was landed with ongoing or failed builds.Jan 10 2022, 8:51 PM

Closed by commit rPcfdb3e4f7f15: [Python 3] Use .items() instead of .iteritems() (authored by sicherha). · Explain Why

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			pykolab/cli/cmd_user_info.py (2 lines)
M			pykolab/wap_client/__init__.py (8 lines)
M			pykolab/xml/attendee.py (4 lines)
M			pykolab/xml/contact.py (16 lines)
M			pykolab/xml/contact_reference.py (2 lines)
M			pykolab/xml/event.py (14 lines)
M			pykolab/xml/note.py (4 lines)
M			pykolab/xml/recurrence_rule.py (4 lines)
M			pykolab/xml/utils.py (2 lines)
M			tests/unit/test-002-attendee.py (40 lines)
M			wallace/module_invitationpolicy.py (4 lines)
M			wallace/module_signature.py (2 lines)