Page MenuHomePhorge

[Python 3] Use .items() instead of .iteritems()

Authored by sicherha on Jan 8 2022, 11:39 AM.
Referenced Files
Unknown Object (File)
Thu, Nov 23, 9:49 AM
Unknown Object (File)
Sun, Nov 12, 7:33 AM
Unknown Object (File)
Mon, Nov 6, 6:59 AM
Unknown Object (File)
Oct 26 2023, 10:59 PM
Unknown Object (File)
Oct 15 2023, 1:19 AM
Unknown Object (File)
Oct 7 2023, 8:19 PM
Unknown Object (File)
Oct 7 2023, 12:22 AM
Unknown Object (File)
Oct 4 2023, 5:45 AM



.iteritems() was dropped in Python 3.0.

This commit may have a negative performance impact on Python 2 since
.items() returns a copy of the dictionary's item list. In Python 3,
.items() returns a view object, so no performance drop should be
noticeable there.

Diff Detail

rP pykolab
Lint Not Applicable
Tests Not Applicable

Event Timeline

sicherha created this revision.
mollekopf subscribed.

I don't think the performance impact matters for the uses we have here.

This revision is now accepted and ready to land.Jan 10 2022, 10:14 AM
This revision was landed with ongoing or failed builds.Jan 10 2022, 8:51 PM
This revision was automatically updated to reflect the committed changes.