Page MenuHomePhorge
Differential D3235

[Python 3] Remove unnecessary occurrences of .keys()
ClosedPublic
Actions

Authored by sicherha on Jan 8 2022, 11:38 AM.
Tags
None
Referenced Files
F16550967: D3235.id9256.diff
Tue, Oct 29, 2:07 PM
F16550964: D3235.id9202.diff
Tue, Oct 29, 2:07 PM
F16550709: D3235.id.diff
Tue, Oct 29, 1:42 PM
Unknown Object (File)
Mon, Oct 21, 8:22 AM
Unknown Object (File)
Fri, Oct 18, 4:40 PM
Unknown Object (File)
Fri, Oct 18, 8:35 AM
Unknown Object (File)
Wed, Oct 9, 8:15 AM
Unknown Object (File)
Sep 8 2024, 2:59 AM
View All 96 Files
Subscribers
None

Details

Reviewers
machniak
mollekopf
Commits
rPc3b9d5557161: [Python 3] Remove unnecessary occurrences of .keys()
Summary

The following cases are covered:

  • for key in dict
  • if key in dict
  • len(dict)

This will make life easier for futurize.

Diff Detail

Repository
rP pykolab
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

sicherha requested review of this revision.Jan 8 2022, 11:38 AM
sicherha created this revision.
Harbormaster completed remote builds in B37786: Diff 9202.Jan 8 2022, 11:38 AM
sicherha mentioned this in D3190: Python 3 compatibility.Jan 8 2022, 11:42 AM
sicherha mentioned this in T6805: Port pykolab to Python 3.Jan 8 2022, 11:45 AM
mollekopf accepted this revision.Jan 10 2022, 10:00 AM
This revision is now accepted and ready to land.Jan 10 2022, 10:00 AM
This revision was landed with ongoing or failed builds.Jan 10 2022, 8:48 PM
Closed by commit rPc3b9d5557161: [Python 3] Remove unnecessary occurrences of .keys() (authored by sicherha). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
bin/
6 lines
ext/
python/
Tools/
freeze/
2 lines
2 lines
kolabd/
4 lines
pykolab/
auth/
ldap/
16 lines
2 lines
cli/
6 lines
4 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
wap/
4 lines
conf/
12 lines
2 lines
imap/
16 lines
plugins/
recipientpolicy/
4 lines
sievemgmt/
2 lines
setup/
4 lines
6 lines
4 lines
8 lines
6 lines
wap_client/
18 lines
xml/
6 lines
16 lines
2 lines
2 lines
4 lines
tests/
functional/
6 lines
test_kolabd/
4 lines
test_wap_client/
2 lines
6 lines
unit/
8 lines
ucs/
6 lines
6 lines
wallace/
4 lines
2 lines
2 lines

Diff 9256

View Options

bin/kolab_smtp_access_policy.py

Loading...
View Options

ext/python/Tools/freeze/checkextensions.py

Loading...
View Options

ext/python/Tools/freeze/freeze.py

Loading...
View Options

kolabd/__init__.py

Loading...
View Options

pykolab/auth/ldap/__init__.py

Loading...
View Options

pykolab/auth/ldap/syncrepl.py

Loading...
View Options

pykolab/cli/cmd_acl_cleanup.py

Loading...
View Options

pykolab/cli/cmd_add_alias.py

Loading...
View Options

pykolab/cli/cmd_check_quota.py

Loading...
View Options

pykolab/cli/cmd_count_domain_mailboxes.py

Loading...
View Options

pykolab/cli/cmd_list_domains.py

Loading...
View Options

pykolab/cli/cmd_list_mailbox_acls.py

Loading...
View Options

pykolab/cli/cmd_list_mailbox_metadata.py

Loading...
View Options

pykolab/cli/cmd_mailbox_cleanup.py

Loading...
View Options

pykolab/cli/cmd_remove_mailaddress.py

Loading...
View Options

pykolab/cli/cmd_sync_mailhost_attrs.py

Loading...
View Options

pykolab/cli/commands.py

Loading...
View Options

pykolab/cli/wap/cmd_system_capabilities.py

Loading...
View Options

pykolab/conf/__init__.py

Loading...
View Options

pykolab/conf/entitlement.py

Loading...
View Options

pykolab/imap/__init__.py

Loading...
View Options

pykolab/plugins/recipientpolicy/__init__.py

Loading...
View Options

pykolab/plugins/sievemgmt/__init__.py

Loading...
View Options

pykolab/setup/components.py

Loading...
View Options

pykolab/setup/setup_freebusy.py

Loading...
View Options

pykolab/setup/setup_mta.py

Loading...
View Options

pykolab/translit.py

Loading...
View Options

pykolab/utils.py

Loading...
View Options

pykolab/wap_client/__init__.py

Loading...
View Options

pykolab/xml/attendee.py

Loading...
View Options

pykolab/xml/event.py

Loading...
View Options

pykolab/xml/note.py

Loading...
View Options

pykolab/xml/recurrence_rule.py

Loading...
View Options

pykolab/xml/utils.py

Loading...
View Options

tests/functional/resource_func.py

Loading...
View Options

tests/functional/test_kolabd/test_001_user_sync.py

Loading...
View Options

tests/functional/test_wap_client/test_002_user_add.py

Loading...
View Options

tests/functional/user_add.py

Loading...
View Options

tests/unit/test-002-attendee.py

Loading...
View Options

ucs/kolab_sieve.py

Loading...
View Options

ucs/listener.py

Loading...
View Options

wallace/module_optout.py

Loading...
View Options

wallace/module_resources.py

Loading...
View Options

wallace/modules.py

Loading...