Differential D3235

[Python 3] Remove unnecessary occurrences of .keys()
ClosedPublic
Actions

Authored by sicherha on Jan 8 2022, 11:38 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Mon, Jul 22, 9:03 AM

	Unknown Object (File)
	Wed, Jul 10, 9:44 AM

	Unknown Object (File)
	Fri, Jul 5, 8:45 PM

	Unknown Object (File)
	Jun 26 2024, 8:55 PM

	Unknown Object (File)
	Jun 26 2024, 8:55 PM

	Unknown Object (File)
	Jun 22 2024, 6:56 PM

	Unknown Object (File)
	Jun 21 2024, 9:27 AM

	Unknown Object (File)
	Jun 20 2024, 2:03 PM

View All 64 Files

Subscribers

None

Details

Reviewers

machniak
mollekopf

Commits

rPc3b9d5557161: [Python 3] Remove unnecessary occurrences of .keys()

Summary

The following cases are covered:

for key in dict
if key in dict
len(dict)

This will make life easier for futurize.

Diff Detail

Repository

Branch

05-remove-keys

Lint

Lint Errors

Severity	Location	Code	Message
Error	ext/python/Tools/freeze/freeze.py:126	E701	PEP8 E701
Error	ext/python/Tools/freeze/freeze.py:329	E701	PEP8 E701
Error	ext/python/Tools/freeze/freeze.py:435	E401	PEP8 E401
Error	ext/python/Tools/freeze/freeze.py:476	E222	PEP8 E222
Error	pykolab/auth/ldap/syncrepl.py:75	E701	PEP8 E701
Error	pykolab/auth/ldap/syncrepl.py:76	E701	PEP8 E701
Error	pykolab/imap/__init__.py:559	E714	PEP8 E714
Error	pykolab/imap/__init__.py:606	E714	PEP8 E714
Error	pykolab/imap/__init__.py:858	E714	PEP8 E714
Error	pykolab/plugins/sievemgmt/__init__.py:387	E203	PEP8 E203
Error	pykolab/setup/setup_mta.py:403	E111	PEP8 E111
Error	pykolab/setup/setup_mta.py:404	E111	PEP8 E111
Error	pykolab/wap_client/__init__.py:608	E203	PEP8 E203
Error	wallace/module_optout.py:169	E116	PEP8 E116
Error	wallace/module_optout.py:170	E116	PEP8 E116
Error	wallace/module_optout.py:171	E116	PEP8 E116
Warning	pykolab/plugins/sievemgmt/__init__.py:50	W601	PEP8 W601

Unit

No Test Coverage

Build Status

Buildable 37786
Build 15235: arc lint + arc unit

Event Timeline

sicherha requested review of this revision.Jan 8 2022, 11:38 AM

sicherha created this revision.

Harbormaster completed remote builds in B37786: Diff 9202.Jan 8 2022, 11:38 AM

sicherha mentioned this in D3190: Python 3 compatibility.Jan 8 2022, 11:42 AM

sicherha mentioned this in T6805: Port pykolab to Python 3.Jan 8 2022, 11:45 AM

mollekopf accepted this revision.Jan 10 2022, 10:00 AM

This revision is now accepted and ready to land.Jan 10 2022, 10:00 AM

This revision was landed with ongoing or failed builds.Jan 10 2022, 8:48 PM

Closed by commit rPc3b9d5557161: [Python 3] Remove unnecessary occurrences of .keys() (authored by sicherha). · Explain Why

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

bin/

kolab_smtp_access_policy.py

6 lines

ext/

python/

Tools/

freeze/

checkextensions.py

2 lines

2 lines

kolabd/

4 lines

pykolab/

auth/

ldap/

16 lines

2 lines

cli/

cmd_acl_cleanup.py

6 lines

cmd_add_alias.py

4 lines

cmd_check_quota.py

2 lines

cmd_count_domain_mailboxes.py

2 lines

cmd_list_domains.py

2 lines

cmd_list_mailbox_acls.py

2 lines

cmd_list_mailbox_metadata.py

2 lines

cmd_mailbox_cleanup.py

2 lines

cmd_remove_mailaddress.py

2 lines

cmd_sync_mailhost_attrs.py

2 lines

2 lines

wap/

cmd_system_capabilities.py

4 lines

conf/

12 lines

2 lines

imap/

16 lines

plugins/

recipientpolicy/

4 lines

sievemgmt/

2 lines

setup/

4 lines

setup_freebusy.py

6 lines

4 lines

8 lines

6 lines

wap_client/

18 lines

xml/

6 lines

16 lines

2 lines

recurrence_rule.py

2 lines

4 lines

tests/

functional/

resource_func.py

6 lines

test_kolabd/

test_001_user_sync.py

4 lines

test_wap_client/

test_002_user_add.py

2 lines

6 lines

unit/

test-002-attendee.py

8 lines

ucs/

6 lines

6 lines

wallace/

module_optout.py

4 lines

module_resources.py

2 lines

2 lines

Diff 9202

bin/kolab_smtp_access_policy.py

Loading...

ext/python/Tools/freeze/checkextensions.py

Loading...

ext/python/Tools/freeze/freeze.py

Loading...

kolabd/init.py

Loading...

pykolab/auth/ldap/init.py

Loading...

pykolab/auth/ldap/syncrepl.py

Loading...

pykolab/cli/cmd_acl_cleanup.py

Loading...

pykolab/cli/cmd_add_alias.py

Loading...

pykolab/cli/cmd_check_quota.py

Loading...

pykolab/cli/cmd_count_domain_mailboxes.py

Loading...

pykolab/cli/cmd_list_domains.py

Loading...

pykolab/cli/cmd_list_mailbox_acls.py

Loading...

pykolab/cli/cmd_list_mailbox_metadata.py

Loading...

pykolab/cli/cmd_mailbox_cleanup.py

Loading...

pykolab/cli/cmd_remove_mailaddress.py

Loading...

pykolab/cli/cmd_sync_mailhost_attrs.py

Loading...

pykolab/cli/commands.py

Loading...

pykolab/cli/wap/cmd_system_capabilities.py

Loading...

pykolab/conf/init.py

Loading...

pykolab/conf/entitlement.py

Loading...

pykolab/imap/init.py

Loading...

pykolab/plugins/recipientpolicy/init.py

Loading...

pykolab/plugins/sievemgmt/init.py

Loading...

pykolab/setup/components.py

Loading...

pykolab/setup/setup_freebusy.py

Loading...

pykolab/setup/setup_mta.py

Loading...

pykolab/translit.py

Loading...

pykolab/utils.py

Loading...

pykolab/wap_client/init.py

Loading...

pykolab/xml/attendee.py

Loading...

pykolab/xml/event.py

Loading...

pykolab/xml/note.py

Loading...

pykolab/xml/recurrence_rule.py

Loading...

pykolab/xml/utils.py

Loading...

tests/functional/resource_func.py

Loading...

tests/functional/test_kolabd/test_001_user_sync.py

Loading...

tests/functional/test_wap_client/test_002_user_add.py

Loading...

tests/functional/user_add.py

Loading...

tests/unit/test-002-attendee.py

Loading...

ucs/kolab_sieve.py

Loading...

ucs/listener.py

Loading...

wallace/module_optout.py

Loading...

wallace/module_resources.py

Loading...

wallace/modules.py

Loading...