[Python 3] Remove unnecessary occurrences of .keys()
ClosedPublic
Actions

Authored by sicherha on Jan 8 2022, 11:38 AM.

Details

Reviewers

machniak
mollekopf

Commits

rPc3b9d5557161: [Python 3] Remove unnecessary occurrences of .keys()

Summary

The following cases are covered:

for key in dict
if key in dict
len(dict)

This will make life easier for futurize.

Diff Detail

Repository

rP pykolab

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

sicherha requested review of this revision.Jan 8 2022, 11:38 AM

sicherha created this revision.

Harbormaster completed remote builds in B37786: Diff 9202.Jan 8 2022, 11:38 AM

sicherha mentioned this in D3190: Python 3 compatibility.Jan 8 2022, 11:42 AM

sicherha mentioned this in T6805: Port pykolab to Python 3.Jan 8 2022, 11:45 AM

mollekopf accepted this revision.Jan 10 2022, 10:00 AM

This revision is now accepted and ready to land.Jan 10 2022, 10:00 AM

This revision was landed with ongoing or failed builds.Jan 10 2022, 8:48 PM

Closed by commit rPc3b9d5557161: [Python 3] Remove unnecessary occurrences of .keys() (authored by sicherha). · Explain Why

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			bin/kolab_smtp_access_policy.py (6 lines)
M			ext/python/Tools/freeze/checkextensions.py (2 lines)
M			ext/python/Tools/freeze/freeze.py (2 lines)
M			kolabd/__init__.py (4 lines)
M			pykolab/auth/ldap/__init__.py (16 lines)
M			pykolab/auth/ldap/syncrepl.py (2 lines)
M			pykolab/cli/cmd_acl_cleanup.py (6 lines)
M			pykolab/cli/cmd_add_alias.py (4 lines)
M			pykolab/cli/cmd_check_quota.py (2 lines)
M			pykolab/cli/cmd_count_domain_mailboxes.py (2 lines)
M			pykolab/cli/cmd_list_domains.py (2 lines)
M			pykolab/cli/cmd_list_mailbox_acls.py (2 lines)
M			pykolab/cli/cmd_list_mailbox_metadata.py (2 lines)
M			pykolab/cli/cmd_mailbox_cleanup.py (2 lines)
M			pykolab/cli/cmd_remove_mailaddress.py (2 lines)
M			pykolab/cli/cmd_sync_mailhost_attrs.py (2 lines)
M			pykolab/cli/commands.py (2 lines)
M			pykolab/cli/wap/cmd_system_capabilities.py (4 lines)
M			pykolab/conf/__init__.py (12 lines)
M			pykolab/conf/entitlement.py (2 lines)
M			pykolab/imap/__init__.py (16 lines)
M			pykolab/plugins/recipientpolicy/__init__.py (4 lines)
M			pykolab/plugins/sievemgmt/__init__.py (2 lines)
M			pykolab/setup/components.py (4 lines)
M			pykolab/setup/setup_freebusy.py (6 lines)
M			pykolab/setup/setup_mta.py (4 lines)
M			pykolab/translit.py (8 lines)
M			pykolab/utils.py (6 lines)
M			pykolab/wap_client/__init__.py (18 lines)
M			pykolab/xml/attendee.py (6 lines)
M			pykolab/xml/event.py (16 lines)
M			pykolab/xml/note.py (2 lines)
M			pykolab/xml/recurrence_rule.py (2 lines)
M			pykolab/xml/utils.py (4 lines)
M			tests/functional/resource_func.py (6 lines)
M			tests/functional/test_kolabd/test_001_user_sync.py (4 lines)
M			tests/functional/test_wap_client/test_002_user_add.py (2 lines)
M			tests/functional/user_add.py (6 lines)
M			tests/unit/test-002-attendee.py (8 lines)
M			ucs/kolab_sieve.py (6 lines)
M			ucs/listener.py (6 lines)
M			wallace/module_optout.py (4 lines)
M			wallace/module_resources.py (2 lines)
M			wallace/modules.py (2 lines)