Page MenuHomePhorge
Feed Search

May 28 2020

vanmeeuwen updated the diff for D1297: Make sure we bill for entitlements that are deleted.
  • Additional tests
  • Correct how many SKUs to add at zero cost, beyond existing ones
  • With doc
  • Improve finding the entitleable object
  • Adjust tests
  • Avoid unintentional changes
  • Fix phpstan issues
  • Add testUpdateEntitlements
  • Feedback
  • Use counting on the sql server side
May 28 2020, 10:31 AM
vanmeeuwen committed rKad257f28b608: An initial implementation of transactions..
May 28 2020, 10:08 AM
vanmeeuwen closed D1102: An initial implementation of transactions..
May 28 2020, 10:08 AM
vanmeeuwen updated the diff for D1102: An initial implementation of transactions..
  • Uncomment
  • Rebase on current master
May 28 2020, 10:06 AM
vanmeeuwen committed rKe177a2f419e7: Make the id for a user fillable.
May 28 2020, 9:58 AM
vanmeeuwen closed D1219: Make the id for a user fillable.
May 28 2020, 9:58 AM
vanmeeuwen requested changes to D1273: Support: Unsuspending/Suspending a user (Bifrost#T315890).

Needs rebasing for resources/sass/_variables.scss, then can be accepted I think.

May 28 2020, 9:52 AM
vanmeeuwen accepted D1303: Add command to render mail templates.
May 28 2020, 9:45 AM
vanmeeuwen updated the diff for D1297: Make sure we bill for entitlements that are deleted.
  • Feedback
May 28 2020, 9:28 AM
vanmeeuwen added inline comments to D1297: Make sure we bill for entitlements that are deleted.
May 28 2020, 9:28 AM
vanmeeuwen added inline comments to D1291: Cherry-picked contents from hkccp-import.
May 28 2020, 9:23 AM
vanmeeuwen updated the diff for D1291: Cherry-picked contents from hkccp-import.
  • Simplify getting to the actual wallet
  • Simplify getting to the wallet
  • Fix test to meet expectations
May 28 2020, 9:22 AM
vanmeeuwen updated the diff for D1219: Make the id for a user fillable.
  • Set new and active outside the user id test
  • Rebase on master
May 28 2020, 9:06 AM
vanmeeuwen updated the diff for D1297: Make sure we bill for entitlements that are deleted.
  • Add testUpdateEntitlements
May 28 2020, 8:30 AM
vanmeeuwen added a comment to D1297: Make sure we bill for entitlements that are deleted.

Looking at the code in context of removing entitlements, I see we might not handle removing storage entitlements properly. We have to add some tests to tests/Feature/Controller/UsersTest::testUpdateEntitlements().

May 28 2020, 6:35 AM

May 27 2020

vanmeeuwen updated the diff for D1297: Make sure we bill for entitlements that are deleted.
  • Fix phpstan issues
May 27 2020, 12:38 PM
vanmeeuwen updated the diff for D1297: Make sure we bill for entitlements that are deleted.
  • Avoid unintentional changes
May 27 2020, 12:20 PM
vanmeeuwen updated the diff for D1297: Make sure we bill for entitlements that are deleted.
  • Additional tests
  • Correct how many SKUs to add at zero cost, beyond existing ones
  • With doc
  • Improve finding the entitleable object
  • Adjust tests
May 27 2020, 12:18 PM
vanmeeuwen committed rK86f37d40ef58: Add a command db:ping and then use it.
May 27 2020, 10:42 AM
vanmeeuwen closed D1285: Add a command db:ping and then use it.
May 27 2020, 10:42 AM
vanmeeuwen added a comment to D1297: Make sure we bill for entitlements that are deleted.

So far so good. I have two stories to consider:

  1. User is deleting and adding the same SKU every 13 days - got it for free.
  2. (After 14 days of using his account) user raises quota, then in 14 days he lowers it - got the "rised quota period" for free.
May 27 2020, 10:26 AM
vanmeeuwen planned changes to D1297: Make sure we bill for entitlements that are deleted.

This will need to be rebased on top of an accepted D1102.

May 27 2020, 9:37 AM
vanmeeuwen requested review of D1297: Make sure we bill for entitlements that are deleted.
May 27 2020, 9:36 AM
vanmeeuwen requested review of D1291: Cherry-picked contents from hkccp-import.
May 27 2020, 7:50 AM

May 26 2020

vanmeeuwen added inline comments to D1102: An initial implementation of transactions..
May 26 2020, 12:53 PM
vanmeeuwen updated the diff for D1102: An initial implementation of transactions..
  • Use the $entitleable variable
  • Use initialized variable
May 26 2020, 12:51 PM
vanmeeuwen requested review of D1285: Add a command db:ping and then use it.
May 26 2020, 11:47 AM
vanmeeuwen updated the diff for D1102: An initial implementation of transactions..
  • The $id parameter is supposed to be a string
  • A second proposal to transactions
  • Update for D1102 review
  • Resolve some comments for D1102
  • Use constants
  • Remove unintentional commenting out
  • Add some tests
May 26 2020, 10:54 AM
vanmeeuwen committed rK2b1d422c9dd4: Ensure that these directories exist.
May 26 2020, 10:44 AM
vanmeeuwen planned changes to D1102: An initial implementation of transactions..
May 26 2020, 10:43 AM
vanmeeuwen updated the diff for D1102: An initial implementation of transactions..

Rebase on current master;

May 26 2020, 10:43 AM

May 25 2020

vanmeeuwen added inline comments to D1102: An initial implementation of transactions..
May 25 2020, 9:44 PM
vanmeeuwen requested review of D1102: An initial implementation of transactions..

Let us review the one single line item for the moment.

May 25 2020, 9:06 PM
vanmeeuwen updated the diff for D1102: An initial implementation of transactions..
  • Update for D1102 review
May 25 2020, 2:29 PM
vanmeeuwen planned changes to D1102: An initial implementation of transactions..

OK, I read no objections against the principles underpinning this implementation, but there are a few things that need fixing.

May 25 2020, 8:27 AM

May 22 2020

vanmeeuwen updated the diff for D1102: An initial implementation of transactions..
  • The $id parameter is supposed to be a string
  • A second proposal to transactions
May 22 2020, 12:44 PM

May 11 2020

vanmeeuwen committed rK6170ff2e3654: Strip superfluous snippets.
May 11 2020, 11:55 AM
vanmeeuwen committed rK9f31ca4f950f: Demo of not setting turn/stun.
May 11 2020, 10:57 AM
vanmeeuwen committed rKca3a60557dfc: Remove tmpfs mounts.
May 11 2020, 10:57 AM

May 9 2020

vanmeeuwen committed rKaeea82482868: Authenticate migrated LDAP passwords correctly.
May 9 2020, 11:15 AM

May 8 2020

vanmeeuwen committed rK919c1b9aa7a8: Remove ssl-dhparams.conf again.
May 8 2020, 3:00 PM
vanmeeuwen committed rK55791e1a2870: Correct linting issue.
May 8 2020, 1:42 PM
vanmeeuwen committed rK8ece08852738: A room has an owner.
May 8 2020, 1:42 PM
vanmeeuwen committed rK09ec1495740f: Additional information for sessions.
May 8 2020, 1:42 PM
vanmeeuwen committed rK4c7b564ab2d2: Provide and use a random string generator for room names.
May 8 2020, 11:35 AM
vanmeeuwen committed rK329233613b3d: Differentiate between the room and the session.
May 8 2020, 11:35 AM
vanmeeuwen committed rK35aa6a9922f4: Also publish APP_DOMAIN to openvidu.
May 8 2020, 11:35 AM
vanmeeuwen committed rKb122e16bdeaa: Correct ssl dhparams.
May 8 2020, 11:35 AM
vanmeeuwen committed rK9d7b89071570: Separate meet. from the main app.
May 8 2020, 9:31 AM
vanmeeuwen committed rK253c05c6921e: Ensure that the .env file as used with docker-compose is amended before we….
May 8 2020, 9:31 AM

May 4 2020

vanmeeuwen added a member for Syncroton Developers: mollekopf.
May 4 2020, 9:26 AM

May 1 2020

vanmeeuwen committed rKf9cdf71a417f: Adjust the default for the coturn redis database number.
May 1 2020, 10:19 AM
vanmeeuwen committed rKfbcbf99c3ec4: Docker environment enhancements.
May 1 2020, 10:02 AM
vanmeeuwen committed rK640bc0f377df: Basic openvidu meet controller.
May 1 2020, 9:44 AM

Apr 30 2020

vanmeeuwen committed rK8cb331ae0018: An initial stab at what it could mean to provide WebRTC through the new HKCCP.
Apr 30 2020, 12:20 PM
vanmeeuwen requested changes to D1231: Custom payments, auto-payments, Stripe support.
Apr 30 2020, 10:30 AM
vanmeeuwen requested changes to D1225: Update phpstan/larastan.
Apr 30 2020, 10:29 AM

Apr 21 2020

vanmeeuwen requested review of D1219: Make the id for a user fillable.
Apr 21 2020, 3:12 PM
vanmeeuwen accepted D1189: Support: External email editing.
Apr 21 2020, 2:33 PM
vanmeeuwen accepted D1207: T332120: Status widget improvements.
Apr 21 2020, 2:31 PM
vanmeeuwen accepted D1213: T332912: Users table cleanup.
Apr 21 2020, 2:28 PM

Apr 14 2020

vanmeeuwen accepted D1177: Menu and Toast improvements.
Apr 14 2020, 11:33 AM
vanmeeuwen accepted D1174: Store email aliases in LDAP.
Apr 14 2020, 11:15 AM
vanmeeuwen requested changes to D1174: Store email aliases in LDAP.
Apr 14 2020, 11:12 AM

Apr 10 2020

vanmeeuwen accepted D1162: Signup: Vouchers.
Apr 10 2020, 12:53 PM
vanmeeuwen accepted D1156: Dispatch DomainVerify job after domain creation in LDAP.
Apr 10 2020, 12:24 PM
vanmeeuwen accepted D1168: Support: Editing a wallet discount.
Apr 10 2020, 12:20 PM
vanmeeuwen accepted D1135: Support: User/Domain info pages.
Apr 10 2020, 11:15 AM

Apr 9 2020

vanmeeuwen resigned from D1135: Support: User/Domain info pages.

I was being stupid and not using the admin URL ;-)

Apr 9 2020, 1:35 AM

Apr 8 2020

vanmeeuwen requested changes to D1135: Support: User/Domain info pages.

I'm not getting it. I apply this differential, and it doesn't yield any of what you describe.

Apr 8 2020, 6:19 PM
vanmeeuwen updated the test plan for D1150: Wallet magic.
Apr 8 2020, 3:52 PM
vanmeeuwen planned changes to D1150: Wallet magic.
Apr 8 2020, 3:42 PM
vanmeeuwen requested review of D1150: Wallet magic.
Apr 8 2020, 3:17 PM
vanmeeuwen committed rK5271e0e8f7ef: Support Dashboard.
Apr 8 2020, 11:43 AM
vanmeeuwen closed D1123: Support Dashboard.
Apr 8 2020, 11:43 AM
vanmeeuwen accepted D1123: Support Dashboard.
Apr 8 2020, 11:42 AM
vanmeeuwen updated the diff for D1123: Support Dashboard.
  • Fix merge problem
  • New .gitignore public/js/ entries
  • Also ignore tests/report
  • Duplicate domain addition
  • Correct namespace, correct wallet to use in function wallet() on Domain
  • Increase resolution of desktop version
  • ActiveSync <-> 2FA switched position
  • Guarantee the ordering is as expected
Apr 8 2020, 11:15 AM
vanmeeuwen committed rKd5bc73798c23: Split user and admin interfaces.
Apr 8 2020, 9:04 AM
vanmeeuwen closed D1129: Split user and admin interfaces.
Apr 8 2020, 9:04 AM
vanmeeuwen committed rK093aae7a8123: Improve list-input widget (authored by machniak).
Apr 8 2020, 8:54 AM
vanmeeuwen closed D1120: Improve list-input widget.
Apr 8 2020, 8:54 AM
vanmeeuwen accepted D1120: Improve list-input widget.
Apr 8 2020, 8:54 AM
vanmeeuwen committed rK4cabb1da0add: Split user and admin interfaces.
Apr 8 2020, 7:34 AM
vanmeeuwen committed rK7a4f7e061705: Rename Controllers/API/Admin/V4 -> Controllers/API/V4/Admin.
Apr 8 2020, 7:34 AM
vanmeeuwen committed rK14c9b4c67ce9: Add simple test for admin API (authored by machniak).
Apr 8 2020, 7:34 AM
vanmeeuwen committed rKadd2bc358656: Add simple browser tests for admin UI (authored by machniak).
Apr 8 2020, 7:34 AM
vanmeeuwen committed rKdc8dae51b9a2: Define middleware in routes not controller (authored by machniak).
Apr 8 2020, 7:34 AM
vanmeeuwen committed rKfe1aa5abe21b: Move /api/auth/info test to AuthTest (authored by machniak).
Apr 8 2020, 7:34 AM
vanmeeuwen committed rK1289c3edc1a4: De-duplicate Auth/User controller, fix all tests (authored by machniak).
Apr 8 2020, 7:34 AM
vanmeeuwen committed rK0c6b50e49004: Include joe@.
Apr 8 2020, 7:34 AM
vanmeeuwen committed rK930937562316: Fix domain dns verification (authored by machniak).
Apr 8 2020, 7:34 AM
vanmeeuwen committed rKb90b2789771f: Fix the confusion about the roles and whatnot.
Apr 8 2020, 7:34 AM
vanmeeuwen committed rK73961c76d6e7: Correct unduly propagating nsroledn attribute values.
Apr 8 2020, 7:34 AM
vanmeeuwen committed rK2902715f3626: Correct creation of roles.
Apr 8 2020, 7:34 AM
vanmeeuwen committed rKf85963db8c2f: Correct the path to validateEmail.
Apr 8 2020, 7:34 AM
vanmeeuwen committed rK832159f86a12: Seed the app.domain as if it were public, if it wasn't already.
Apr 8 2020, 7:34 AM
vanmeeuwen committed rK321b2cffc5e3: Clear phpstan issues.
Apr 8 2020, 7:34 AM
vanmeeuwen committed rK41314e7f8a6e: Structuring /api/admin/v4 controllers separate from /api/v4 for consumers, with….
Apr 8 2020, 7:34 AM
vanmeeuwen committed rK3a27c114161d: Wallet discounts.
Apr 8 2020, 7:34 AM
vanmeeuwen committed rKd38533b16257: 2FA - initial, non-working code (authored by machniak).
Apr 8 2020, 7:33 AM