Page MenuHomekolab.org

Store email aliases in LDAP
ClosedPublic

Authored by machniak on Apr 13 2020, 10:16 AM.

Details

Reviewers
vanmeeuwen
Group Reviewers
Restricted Project
Commits
rK2bb66aba770d: Store email aliases in LDAP
Summary

Use 'alias' attribute in LDAP for user aliases.

Fixes aliases update, added proper tests.

Test Plan

./phpunit

Diff Detail

Repository
rK kolab
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

machniak requested review of this revision.Apr 13 2020, 10:16 AM
machniak created this revision.
vanmeeuwen requested changes to this revision.Apr 14 2020, 1:12 PM
vanmeeuwen added a subscriber: vanmeeuwen.
vanmeeuwen added inline comments.
src/app/Traits/UserAliasesTrait.php
28

Would this also benefit from ->pluck('alias')?

This revision now requires changes to proceed.Apr 14 2020, 1:12 PM
machniak added inline comments.Apr 14 2020, 1:14 PM
src/app/Traits/UserAliasesTrait.php
28

Not here. Because we need a UserALias object to call ->delete() on it. That's the most efficient way (if we want to make use of observers).

vanmeeuwen accepted this revision.Apr 14 2020, 1:15 PM
This revision is now accepted and ready to land.Apr 14 2020, 1:15 PM
This revision was automatically updated to reflect the committed changes.