- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Advanced Search
Oct 17 2017
Oct 13 2017
Oct 9 2017
Oct 6 2017
Oct 4 2017
I believe the issue has been fixed by https://git.kolab.org/rACb2fdd4828985a07e6f715ecbe789bf4fa5102ec3. It looks that this old commit wasn't packaged yet.
Oct 3 2017
Sep 29 2017
Sep 27 2017
Sep 14 2017
Sep 12 2017
Sep 7 2017
Aug 30 2017
Aug 29 2017
Done.
Aug 28 2017
Actually a cancelled event has text-decoration:line-through on the title, but when the event's height takes only one time slot that title is not visible. I don't think we should display them "in white" as we do for pending/declined events, so I propose to just add opacity:0.6.
Aug 25 2017
Aug 24 2017
Aug 23 2017
Aug 22 2017
Aug 21 2017
Aug 19 2017
Just before I review this on Monday I'd like to point you to https://git.kolab.org/rS409371a7cf4fe25bf902595d79423120b65326e9
Aug 7 2017
Aug 4 2017
Aug 3 2017
Aug 2 2017
The first error is something internal to composer. In my CentOS system I have composer-1.0.0-3.1.el7.kolab_wf and I have /usr/share/php/Psr/Log/LoggerInterface.php file.
Maybe the composer version is too old. Many dependencies require phpunit using version constraint "^4" or similar. I think you can solve this simply by excluding developer dependencies. Use composer with --no-dev argument.
Aug 1 2017
Jul 30 2017
Since Roundcube 1.3 external javascript libraries are not anymore in the git repository. There's a script to download them and install in bin/install-jsdeps.sh (it uses jsdeps.json file in root folder). So, either we use -complete tarball (not /vendor folder there) or fetch js deps in package create stage. Or maybe in post-install script?
Jul 24 2017
Jul 21 2017
Reference to the ticket: T2009.
A low hanging fruit. Patch in my comment above.
Jul 20 2017
@vanmeeuwen Does https://git.kolab.org/rP0e8a8276f60b4cf99ef37d9e3b413153d80bcd98 fix this or we plan another solution?
@bruederli Do you remember what's the reason for https://git.kolab.org/source/iRony/browse/master/lib/Kolab/CalDAV/CalendarBackend.php;ead6159e01eb2b44b9f90665d17168cd14f5ce3b$91 to be not active?
ps. there's possible performance optimization in find_user_folders: don't use imap.list_folders('*'), instead depend on imap.get_metadata('*'), which we do anyway. But of course we should ask for the metadata we need, not all of them.
Now I see where's the problem:
- @vanmeeuwen, a side of the main reason of the issue (see below). There must be some bug somewhere because imap SELECT on a folder that has 'lr' for anyone should not fail.
- If you consider this code
# exclude shared and other user's namespace if ns_other is not None and folder.startswith(ns_other) and '_delegated_mailboxes' in user_rec: # allow shared folders from delegators if len([_mailbox for _mailbox in user_rec['_delegated_mailboxes'] if folder.startswith(ns_other + _mailbox + '/')]) = continue # TODO: list shared folders the user has write privileges ? if ns_shared is not None and len([_ns for _ns in ns_shared if folder.startswith(_ns)]) > 0: continue
You will see that if user_rec['_delegated_mailboxes'] is not set (which is the case here) no other user folders will be excluded. So, my proposed fix is:
--- a/wallace/module_invitationpolicy.py +++ b/wallace/module_invitationpolicy.py @@ -796,7 +796,9 @@ def list_user_folders(user_rec, type):
Or to be more precise (according to the traceback). It does not even tries to write to the folder, but just tries to select it (and then search for an object). I'm not sure why select fails while the folder is 'lr'.
Is there delegation setup between these users? For me it looks like there is, but delagtor's calendar folder is non writable and the code does not check that trying to write to it.