Page MenuHomePhorge
Feed Advanced Search

Oct 17 2017

machniak committed rRPKd331f73d01b6: Fix performance issue in custom_displayname() when imap_cache is disabled… (authored by machniak).
Fix performance issue in custom_displayname() when imap_cache is disabled…
Oct 17 2017, 9:06 AM

Oct 13 2017

machniak added a watcher for Copenhagen: machniak.
Oct 13 2017, 12:55 PM

Oct 9 2017

machniak committed rRPK7422273f89c4: Fix PHP Warning: Missing argument 2 for kolab_auth_ldap::get_user_record()… (authored by machniak).
Fix PHP Warning: Missing argument 2 for kolab_auth_ldap::get_user_record()…
Oct 9 2017, 8:27 AM

Oct 6 2017

machniak committed rS888badf441a0: Configurable limit of number of folders in a single Sync/Ping request… (authored by machniak).
Configurable limit of number of folders in a single Sync/Ping request…
Oct 6 2017, 10:53 AM
machniak committed rRPKddf188b73b95: Workaround libkolabxml error on Etc/UTC timezone (Bifrost#T43830) (authored by machniak).
Workaround libkolabxml error on Etc/UTC timezone (Bifrost#T43830)
Oct 6 2017, 8:34 AM
machniak committed rRPK02d375972470: Workaround libkolabxml error on Etc/UTC timezone (Bifrost#T43830) (authored by machniak).
Workaround libkolabxml error on Etc/UTC timezone (Bifrost#T43830)
Oct 6 2017, 8:33 AM

Oct 4 2017

machniak added a comment to T2654: autodiscover does not work with Outlook.

I believe the issue has been fixed by https://git.kolab.org/rACb2fdd4828985a07e6f715ecbe789bf4fa5102ec3. It looks that this old commit wasn't packaged yet.

Oct 4 2017, 12:34 PM · Autoconf, Bug Reports
machniak committed rAC6dabcd3bccec: Fix finding domain root dn so inetdomainbasedn is not ignored (authored by machniak).
Fix finding domain root dn so inetdomainbasedn is not ignored
Oct 4 2017, 11:50 AM

Oct 3 2017

machniak committed rRPK1abc73cf345e: Fix regression when startup() method of some "by role plugins" could be called… (authored by machniak).
Fix regression when startup() method of some "by role plugins" could be called…
Oct 3 2017, 10:14 AM

Sep 29 2017

machniak committed rRPKf48823ae623d: Default timeout is 120 (authored by machniak).
Default timeout is 120
Sep 29 2017, 12:06 PM

Sep 27 2017

machniak closed T606: Adding/Removing a multi-auth factor does not refresh the list of current factors as Resolved.
Sep 27 2017, 1:39 PM · Roundcube Kolab Plugins
machniak closed T606: Adding/Removing a multi-auth factor does not refresh the list of current factors, a subtask of T414: OTP authentication for Roundcube, as Resolved.
Sep 27 2017, 1:39 PM · Roundcube
machniak committed rRPK7c81d3f1dd3f: T606: Fix refreshing list of auth factors after adding/removing them (authored by machniak).
T606: Fix refreshing list of auth factors after adding/removing them
Sep 27 2017, 1:38 PM
machniak committed rRPK68477e014dce: Fix enabling kolab_2fa plugin via kolab_auth_role_plugins (authored by machniak).
Fix enabling kolab_2fa plugin via kolab_auth_role_plugins
Sep 27 2017, 1:02 PM

Sep 14 2017

machniak committed rRPK74ee354f85d3: Style needs-action/declined events with opacity when invitation calendars are… (authored by machniak).
Style needs-action/declined events with opacity when invitation calendars are…
Sep 14 2017, 3:36 PM
machniak committed rRPK16a71fccdccd: Allow an event updates on iTip request without SEQUENCE bump (Bifrost#T27883) (authored by machniak).
Allow an event updates on iTip request without SEQUENCE bump (Bifrost#T27883)
Sep 14 2017, 1:22 PM

Sep 12 2017

machniak committed rRPKa1cd95152c1f: Align event start date with the first occurrence (authored by machniak).
Align event start date with the first occurrence
Sep 12 2017, 1:54 PM
machniak closed D536: Align event start date with the first occurrence by committing rRPKa1cd95152c1f: Align event start date with the first occurrence.
Sep 12 2017, 1:54 PM
machniak closed T2630: Kolab Winterfell: PHP Fatal error: Uncaught Error: [] operator not supported for strings in Fedora 26 as Resolved.
Sep 12 2017, 1:50 PM · Web Administration Panel Developers, Bug Reports
machniak committed rWAP9f4605eae5f0: fix issue with PHP 7.1 (authored by machniak).
fix issue with PHP 7.1
Sep 12 2017, 1:48 PM
machniak closed D542: fix issue with PHP 7.1 by committing rWAP9f4605eae5f0: fix issue with PHP 7.1.
Sep 12 2017, 1:48 PM · Web Administration Panel
machniak accepted D542: fix issue with PHP 7.1.
Sep 12 2017, 1:16 PM · Web Administration Panel

Sep 7 2017

machniak committed rS348b1c664c86: Prevent redundant sync after meeting response (authored by machniak).
Prevent redundant sync after meeting response
Sep 7 2017, 5:34 PM

Aug 30 2017

machniak added a reviewer for D536: Align event start date with the first occurrence: vanmeeuwen.
Aug 30 2017, 9:30 AM
machniak created D536: Align event start date with the first occurrence.
Aug 30 2017, 9:30 AM

Aug 29 2017

machniak closed T2507: Make canceled events more distiguishable in calendar view as Resolved.

Done.

Aug 29 2017, 3:24 PM · Roundcube Kolab Plugins , Architecture & Design
machniak committed rRPK6b3ac66afc4c: T2507: Display cancelled event box with some transparency (authored by machniak).
T2507: Display cancelled event box with some transparency
Aug 29 2017, 3:24 PM

Aug 28 2017

machniak added a comment to T2507: Make canceled events more distiguishable in calendar view.

Actually a cancelled event has text-decoration:line-through on the title, but when the event's height takes only one time slot that title is not visible. I don't think we should display them "in white" as we do for pending/declined events, so I propose to just add opacity:0.6.

Aug 28 2017, 3:46 PM · Roundcube Kolab Plugins , Architecture & Design

Aug 25 2017

machniak committed rSb8369c9f224c: T2483: MeetingResponse support (authored by machniak).
T2483: MeetingResponse support
Aug 25 2017, 1:23 PM
machniak committed rS3be69e5d9ca9: Improve SEQUENCE bumping, fix object identifier in MeetingResponse response (authored by machniak).
Improve SEQUENCE bumping, fix object identifier in MeetingResponse response
Aug 25 2017, 1:20 PM

Aug 24 2017

machniak committed rSa0bf61b8bb0e: Add documentation about forcing re-synchronization of data. (authored by machniak).
Add documentation about forcing re-synchronization of data.
Aug 24 2017, 3:49 PM

Aug 23 2017

machniak committed rRPKefb455426743: Fix "PHP Warning: Illegal string offset 'BYDAY'" when moving a non-recurring… (authored by machniak).
Fix "PHP Warning: Illegal string offset 'BYDAY'" when moving a non-recurring…
Aug 23 2017, 1:55 PM
machniak committed rSd1e60a370fe5: Make sure Attendee.Name element is not empty (Bifrost#T39345) (authored by machniak).
Make sure Attendee.Name element is not empty (Bifrost#T39345)
Aug 23 2017, 1:38 PM
machniak committed rS6342bece03ba: Make sure Attendee.Name element is not empty (Bifrost#T39345) (authored by machniak).
Make sure Attendee.Name element is not empty (Bifrost#T39345)
Aug 23 2017, 1:38 PM
machniak committed rS34f38959d33c: Fix detecting if the user is an organizer of a meeting (authored by machniak).
Fix detecting if the user is an organizer of a meeting
Aug 23 2017, 1:38 PM
machniak committed rSb1be2e76f30f: MeetingResponse: Throw exception on event exception (authored by machniak).
MeetingResponse: Throw exception on event exception
Aug 23 2017, 12:33 PM
machniak committed rS99eea6ae9442: MeetingResponse: Get rid of dummy exception (authored by machniak).
MeetingResponse: Get rid of dummy exception
Aug 23 2017, 11:12 AM
machniak committed rSf91b768eff4e: MeetingResponse: Fixed event updates (authored by machniak).
MeetingResponse: Fixed event updates
Aug 23 2017, 11:11 AM
machniak committed rS8debf167a6e4: Fix BusyStatus=0 synchronization (authored by machniak).
Fix BusyStatus=0 synchronization
Aug 23 2017, 9:39 AM

Aug 22 2017

machniak committed rS0e8d38592351: Set free/busy status on MeetingResponse (authored by machniak).
Set free/busy status on MeetingResponse
Aug 22 2017, 1:25 PM
machniak committed rRPK5e5aac91a4dd: Skip command/location field if it contains only whitespace charaters (authored by machniak).
Skip command/location field if it contains only whitespace charaters
Aug 22 2017, 12:27 PM
machniak committed rRPKae69d586c211: Fix redundant scrollbar on .event-line element in Chrome (authored by machniak).
Fix redundant scrollbar on .event-line element in Chrome
Aug 22 2017, 12:04 PM

Aug 21 2017

machniak committed rSfe632fc8ce6b: Improvements and cleanup in MeetingResponse handling (authored by machniak).
Improvements and cleanup in MeetingResponse handling
Aug 21 2017, 6:44 PM
machniak committed rS847056c84bdb: Merge branch 'master' into feature/meeting-request (authored by machniak).
Merge branch 'master' into feature/meeting-request
Aug 21 2017, 6:43 PM
machniak committed rSc8ce13669ab8: Fix setting attendee status when syncing event from a device to the server… (authored by machniak).
Fix setting attendee status when syncing event from a device to the server…
Aug 21 2017, 1:07 PM
machniak added inline comments to D515: Implement setAttendeeStatus.
Aug 21 2017, 11:05 AM
machniak committed rRPK68d065a399bf: Fix some js errors when attendee status is unset (authored by machniak).
Fix some js errors when attendee status is unset
Aug 21 2017, 9:59 AM

Aug 19 2017

machniak added a comment to D515: Implement setAttendeeStatus.

Just before I review this on Monday I'd like to point you to https://git.kolab.org/rS409371a7cf4fe25bf902595d79423120b65326e9

Aug 19 2017, 6:50 AM

Aug 7 2017

machniak committed rPNL4c21bdebaa62: Bump version number (authored by machniak).
Bump version number
Aug 7 2017, 2:48 PM

Aug 4 2017

machniak committed rSd32b2289c65d: Return "Invalid item" (6) status on SMS entries instead of "Server error" (5) (authored by machniak).
Return "Invalid item" (6) status on SMS entries instead of "Server error" (5)
Aug 4 2017, 4:59 PM
machniak committed rSa68e0428fdb0: Bump SEQUENCE number on update (Outlook only). (authored by machniak).
Bump SEQUENCE number on update (Outlook only).
Aug 4 2017, 12:10 PM

Aug 3 2017

machniak updated the task description for T969: Update Roundcube package dependencies.
Aug 3 2017, 8:38 AM · Roundcube, Kolab 16

Aug 2 2017

machniak closed T2594: Visual issue on attachment added "from cloud..." as Resolved.
Aug 2 2017, 3:36 PM · Roundcube Kolab Plugins
machniak committed rRPKf7c9b896821f: T2594: Fix issues when attaching files from cloud in Roundcube 1.3 (authored by machniak).
T2594: Fix issues when attaching files from cloud in Roundcube 1.3
Aug 2 2017, 2:57 PM
machniak created T2594: Visual issue on attachment added "from cloud...".
Aug 2 2017, 2:32 PM · Roundcube Kolab Plugins
machniak committed rSca089e32a5de: Fix LDAP connection errors in Ping when using activesync_gal_sync (authored by machniak).
Fix LDAP connection errors in Ping when using activesync_gal_sync
Aug 2 2017, 2:15 PM
machniak committed rRPK3bbc4c24c45b: Ignore displayname annotation for folder list in activesync/delegation (authored by machniak).
Ignore displayname annotation for folder list in activesync/delegation
Aug 2 2017, 1:38 PM
machniak added a comment to T2588: Roundcube 1.3 in Winterfell is missing jquery.min.js.

The first error is something internal to composer. In my CentOS system I have composer-1.0.0-3.1.el7.kolab_wf and I have /usr/share/php/Psr/Log/LoggerInterface.php file.

Aug 2 2017, 10:18 AM · Roundcube, Bug Reports
machniak added a comment to T2588: Roundcube 1.3 in Winterfell is missing jquery.min.js.

Maybe the composer version is too old. Many dependencies require phpunit using version constraint "^4" or similar. I think you can solve this simply by excluding developer dependencies. Use composer with --no-dev argument.

Aug 2 2017, 8:07 AM · Roundcube, Bug Reports

Aug 1 2017

machniak committed rRPK3747531f320c: Fix typo (authored by machniak).
Fix typo
Aug 1 2017, 1:17 PM
machniak committed rS945eeaf741bd: Add 'ready' hook for Kolab plugins (Bifrost#T36327) (authored by machniak).
Add 'ready' hook for Kolab plugins (Bifrost#T36327)
Aug 1 2017, 1:14 PM
machniak committed rI980541a2d503: Add 'ready' hook for Kolab plugins (Bifrost#T36327) (authored by machniak).
Add 'ready' hook for Kolab plugins (Bifrost#T36327)
Aug 1 2017, 1:08 PM
machniak committed rF7f26a06271a5: Safe Unauthenticated Free/Busy for Roaming Users (Bifrost#T36327) (authored by machniak).
Safe Unauthenticated Free/Busy for Roaming Users (Bifrost#T36327)
Aug 1 2017, 1:01 PM
machniak committed rRPK2586d83fa152: Merge branch 'master' of ssh://git.kolab.org/diffusion/RPK/roundcubemail… (authored by machniak).
Merge branch 'master' of ssh://git.kolab.org/diffusion/RPK/roundcubemail…
Aug 1 2017, 12:55 PM
machniak committed rRPKa2a1d5e99d23: Safe Unauthenticated Free/Busy for Roaming Users (Bifrost#T36327) - display the… (authored by machniak).
Safe Unauthenticated Free/Busy for Roaming Users (Bifrost#T36327) - display the…
Aug 1 2017, 12:55 PM
machniak committed rRPKbd7fe38996f8: Safe Unauthenticated Free/Busy for Roaming Users (Bifrost#T36327) (authored by machniak).
Safe Unauthenticated Free/Busy for Roaming Users (Bifrost#T36327)
Aug 1 2017, 12:55 PM

Jul 30 2017

machniak committed rRPK5ef54c3706b4: Load missing 'showmore' label localization (authored by machniak).
Load missing 'showmore' label localization
Jul 30 2017, 12:43 PM
machniak committed rRPK1ea20a65c2bc: Load missing 'showmore' label localization (authored by machniak).
Load missing 'showmore' label localization
Jul 30 2017, 12:42 PM
machniak committed rRPKf8e751d1cfd6: Disable tagging functionality in contextmenu for Roundcube < 1.4… (authored by machniak).
Disable tagging functionality in contextmenu for Roundcube < 1.4…
Jul 30 2017, 12:24 PM
machniak committed rRPKb8894f5ab28e: Disable tagging functionality in contextmenu for Roundcube < 1.4… (authored by machniak).
Disable tagging functionality in contextmenu for Roundcube < 1.4…
Jul 30 2017, 12:20 PM
machniak added a comment to T2588: Roundcube 1.3 in Winterfell is missing jquery.min.js.

Since Roundcube 1.3 external javascript libraries are not anymore in the git repository. There's a script to download them and install in bin/install-jsdeps.sh (it uses jsdeps.json file in root folder). So, either we use -complete tarball (not /vendor folder there) or fetch js deps in package create stage. Or maybe in post-install script?

Jul 30 2017, 8:23 AM · Roundcube, Bug Reports

Jul 24 2017

machniak committed rC85a75e825664: Make sure to load kolab_auth when supported mimetypes is requested… (authored by machniak).
Make sure to load kolab_auth when supported mimetypes is requested…
Jul 24 2017, 11:59 AM
machniak committed rC629f5ecfaef9: Fill userlogins log with entries indicating Collabora Online use (authored by machniak).
Fill userlogins log with entries indicating Collabora Online use
Jul 24 2017, 11:36 AM
machniak committed rRPK978b7535edce: Add some missing localization labels, fix some labels use (authored by machniak).
Add some missing localization labels, fix some labels use
Jul 24 2017, 11:05 AM
machniak committed rRSCa9e635139108: Fix Close button in Roundcube 1.4 (authored by machniak).
Fix Close button in Roundcube 1.4
Jul 24 2017, 10:42 AM

Jul 21 2017

machniak committed rPf38e67c7c143: Support unicode characters in event location field (Bifrost#T29104) (authored by machniak).
Support unicode characters in event location field (Bifrost#T29104)
Jul 21 2017, 2:12 PM
machniak committed rP8702bfa0661a: Fix error on CLASS:X-PERSONAL (authored by machniak).
Fix error on CLASS:X-PERSONAL
Jul 21 2017, 2:12 PM
machniak committed rPe522f9e05add: Fix error on CLASS:X-PERSONAL (authored by machniak).
Fix error on CLASS:X-PERSONAL
Jul 21 2017, 2:10 PM
machniak committed rP24da53112b65: Merge branch 'arcpatch-D479' (authored by machniak).
Merge branch 'arcpatch-D479'
Jul 21 2017, 2:10 PM
machniak closed D479: Fix error on CLASS:X-PERSONAL by committing rPe522f9e05add: Fix error on CLASS:X-PERSONAL.
Jul 21 2017, 2:10 PM
machniak committed rP7f347ae804be: Support unicode characters in event location field (Bifrost#T29104) (authored by machniak).
Support unicode characters in event location field (Bifrost#T29104)
Jul 21 2017, 2:09 PM
machniak committed rRSCd4440d86e07a: Fix some contextmenu icons (folders list, addressbook list, groups list) (authored by machniak).
Fix some contextmenu icons (folders list, addressbook list, groups list)
Jul 21 2017, 1:17 PM
machniak accepted D290: replaces spaces in givenname when enforcing daemon recipient policy. to avoid crate mailboxes with spaces.

Reference to the ticket: T2009.

Jul 21 2017, 12:53 PM
machniak reassigned T2187: 'bool' object has no attribute 'lower' from pykolab/imap/_init_.py", line 832 after "pykolab.imap ERROR Could not create ..." (MIGMAK-751) from petersen to vanmeeuwen.

A low hanging fruit. Patch in my comment above.

Jul 21 2017, 12:49 PM · PyKolab, Bug Reports
machniak requested changes to D485: Address inefficiencies and possible misfunction over delegated mailboxes in other user namespace.
Jul 21 2017, 12:40 PM
machniak closed T1543: Undeliverable mail because of duplicated Sender header as Resolved.
Jul 21 2017, 10:58 AM · Winterfell, PyKolab

Jul 20 2017

machniak committed rRPKc5843388a8bb: Don't display Privacy (Classification) when set to X-* value in iTip (authored by machniak).
Don't display Privacy (Classification) when set to X-* value in iTip
Jul 20 2017, 4:43 PM
machniak created D479: Fix error on CLASS:X-PERSONAL.
Jul 20 2017, 4:29 PM
machniak committed rRSCd444fbeafd91: Fix compatibility with Roundcube 1.4 (task menu items) (authored by machniak).
Fix compatibility with Roundcube 1.4 (task menu items)
Jul 20 2017, 12:48 PM
machniak assigned T1543: Undeliverable mail because of duplicated Sender header to vanmeeuwen.

@vanmeeuwen Does https://git.kolab.org/rP0e8a8276f60b4cf99ef37d9e3b413153d80bcd98 fix this or we plan another solution?

Jul 20 2017, 11:57 AM · Winterfell, PyKolab
machniak updated subscribers of T2157: No support for read-only access in CalDAV-Sync (android).

@bruederli Do you remember what's the reason for https://git.kolab.org/source/iRony/browse/master/lib/Kolab/CalDAV/CalendarBackend.php;ead6159e01eb2b44b9f90665d17168cd14f5ce3b$91 to be not active?

Jul 20 2017, 10:13 AM · iRony
machniak added a comment to T2582: Possibly a bug with wallace finding user personal folders, that probably makes emails stuck in wallace queue.

ps. there's possible performance optimization in find_user_folders: don't use imap.list_folders('*'), instead depend on imap.get_metadata('*'), which we do anyway. But of course we should ask for the metadata we need, not all of them.

Jul 20 2017, 9:35 AM · PyKolab, Bug Reports
machniak assigned T2582: Possibly a bug with wallace finding user personal folders, that probably makes emails stuck in wallace queue to vanmeeuwen.
Jul 20 2017, 9:32 AM · PyKolab, Bug Reports
machniak updated subscribers of T2582: Possibly a bug with wallace finding user personal folders, that probably makes emails stuck in wallace queue.

Now I see where's the problem:

  1. @vanmeeuwen, a side of the main reason of the issue (see below). There must be some bug somewhere because imap SELECT on a folder that has 'lr' for anyone should not fail.
  2. If you consider this code
# exclude shared and other user's namespace
if ns_other is not None and folder.startswith(ns_other) and '_delegated_mailboxes' in user_rec:
    # allow shared folders from delegators
    if len([_mailbox for _mailbox in user_rec['_delegated_mailboxes'] if folder.startswith(ns_other + _mailbox + '/')]) =
        continue
# TODO: list shared folders the user has write privileges ?
if ns_shared is not None and len([_ns for _ns in ns_shared if folder.startswith(_ns)]) > 0:
    continue

You will see that if user_rec['_delegated_mailboxes'] is not set (which is the case here) no other user folders will be excluded. So, my proposed fix is:

--- a/wallace/module_invitationpolicy.py
+++ b/wallace/module_invitationpolicy.py
@@ -796,7 +796,9 @@ def list_user_folders(user_rec, type):
Jul 20 2017, 9:21 AM · PyKolab, Bug Reports
machniak added a comment to T2582: Possibly a bug with wallace finding user personal folders, that probably makes emails stuck in wallace queue.

Or to be more precise (according to the traceback). It does not even tries to write to the folder, but just tries to select it (and then search for an object). I'm not sure why select fails while the folder is 'lr'.

Jul 20 2017, 8:38 AM · PyKolab, Bug Reports
machniak added a comment to T2582: Possibly a bug with wallace finding user personal folders, that probably makes emails stuck in wallace queue.

Is there delegation setup between these users? For me it looks like there is, but delagtor's calendar folder is non writable and the code does not check that trying to write to it.

Jul 20 2017, 8:35 AM · PyKolab, Bug Reports

Jul 19 2017

machniak committed rS0a1b6c8987fe: Bifrost#T36198: Create non-conflicting ServerId for objects with non-unique or… (authored by machniak).
Bifrost#T36198: Create non-conflicting ServerId for objects with non-unique or…
Jul 19 2017, 4:03 PM
machniak closed D473: Bifrost#T36198: Create non-conflicting ServerId for objects with non-unique or long UID by committing rS0a1b6c8987fe: Bifrost#T36198: Create non-conflicting ServerId for objects with non-unique or….
Jul 19 2017, 4:03 PM
machniak requested review of D473: Bifrost#T36198: Create non-conflicting ServerId for objects with non-unique or long UID.
Jul 19 2017, 3:39 PM
machniak committed rRPKf50bb9bf2081: Support UIDs up to 512 characters (authored by machniak).
Support UIDs up to 512 characters
Jul 19 2017, 2:48 PM