Page MenuHomePhorge

Address inefficiencies and possible misfunction over delegated mailboxes in other user namespace
ClosedPublic

Authored by vanmeeuwen on Jul 21 2017, 12:16 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Nov 18, 7:47 PM
Unknown Object (File)
Mon, Nov 18, 6:27 AM
Unknown Object (File)
Mon, Nov 18, 6:26 AM
Unknown Object (File)
Mon, Nov 18, 4:42 AM
Unknown Object (File)
Oct 29 2024, 12:51 PM
Unknown Object (File)
Oct 21 2024, 9:42 PM
Unknown Object (File)
Oct 16 2024, 1:57 PM
Unknown Object (File)
Sep 27 2024, 4:51 AM

Diff Detail

Repository
rP pykolab
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

machniak subscribed.
machniak added inline comments.
wallace/module_invitationpolicy.py
792–801

We need only two annotations. Wouldn't be possible to extend get_metadata() to fetch only these?

817

I think we could just store the folder type (with subtype) here, giving the private annotation a prio over shared. Making all checks below much more simpler.

This revision now requires changes to proceed.Jul 21 2017, 12:40 PM
vanmeeuwen edited edge metadata.
vanmeeuwen added inline comments.
wallace/module_invitationpolicy.py
792–801

Yes it could, but that's an efficiency parameter that is otherwise unrelated to the particular ticket this attempts to resolve.

817

Changing the definition of what is stored, and how it is stored will be a cause of great confusion later down the line.

Note that we don't mutate data here, and we don't mutate the data structure either -- we're just filtering out irrelevant entries.

This revision is now accepted and ready to land.Jul 22 2017, 1:06 PM
This revision was automatically updated to reflect the committed changes.