Address inefficiencies and possible misfunction over delegated mailboxes in other user namespace
ClosedPublic
Actions

Authored by vanmeeuwen on Jul 21 2017, 12:16 PM.

Details

Reviewers

machniak
vanmeeuwen

Group Reviewers

PyKolab Developers

Maniphest Tasks

Commits

Summary

Resolves T2582

Test Plan

None

Repository

rP pykolab

Branch

dev/T2582

Lint

Lint Skipped

Unit

No Test Coverage

Build Status

Buildable 11309
Build 9221: arc lint + arc unit

machniak requested changes to this revision.Jul 21 2017, 12:40 PM

machniak subscribed.

machniak added inline comments.

wallace/module_invitationpolicy.py
792	We need only two annotations. Wouldn't be possible to extend get_metadata() to fetch only these?
817	I think we could just store the folder type (with subtype) here, giving the private annotation a prio over shared. Making all checks below much more simpler.

This revision now requires changes to proceed.Jul 21 2017, 12:40 PM

vanmeeuwen requested review of this revision.Jul 21 2017, 12:55 PM

vanmeeuwen edited edge metadata.

vanmeeuwen added inline comments.

wallace/module_invitationpolicy.py
792	Yes it could, but that's an efficiency parameter that is otherwise unrelated to the particular ticket this attempts to resolve.
817	Changing the definition of what is stored, and how it is stored will be a cause of great confusion later down the line. Note that we don't mutate data here, and we don't mutate the data structure either -- we're just filtering out irrelevant entries.