Page MenuHomePhorge
Feed All Stories

Dec 16 2024

mollekopf abandoned D5064: Disable fetching of attachments within calendar-query.

Smart.

Dec 16 2024, 9:26 AM
mollekopf added a reviewer for D5066: Avoid going OOM by pretending we're Lightning: Restricted Project.

Manually tested

Dec 16 2024, 9:25 AM
mollekopf requested review of D5066: Avoid going OOM by pretending we're Lightning.
Dec 16 2024, 9:25 AM
Spenneberg closed T8410: Almalinux Repo broken as Resolved.

Works now.

Dec 16 2024, 5:48 AM

Dec 15 2024

machniak added a comment to D5064: Disable fetching of attachments within calendar-query.

The client could send some HTTP header, e.g. X-Skip-Attachments: true. Since we control both sides this seems to be the best idea to me. From what I see the client could also advertise itself as "User-Agent: Lightning/1".

Dec 15 2024, 12:26 PM

Dec 13 2024

mollekopf committed rScb559a14cccc: Print deviceid on resync.php.
Dec 13 2024, 8:52 PM
mollekopf closed D5054: Error handling when querying sync-states.
Dec 13 2024, 8:52 PM
mollekopf committed rS6cb8695908a8: Error handling when querying sync-states.
Dec 13 2024, 8:52 PM
mollekopf closed D5044: Warning on FolderSync synckey reuse, but then don't try to create in the backend.
Dec 13 2024, 8:52 PM
mollekopf committed rSbda85c97af5a: Warning on FolderSync synckey reuse, but then don't try to create in the backend.
Dec 13 2024, 8:52 PM
mollekopf committed rSf7b5bfd79cc4: Print the device/folder id's that are in the xml as well.
Dec 13 2024, 8:52 PM
mollekopf added inline comments to D5044: Warning on FolderSync synckey reuse, but then don't try to create in the backend.
Dec 13 2024, 8:44 PM
mollekopf accepted D5062: Kolab4 tags support.
Dec 13 2024, 8:02 PM
mollekopf added a reviewer for D5064: Disable fetching of attachments within calendar-query: iRony Developers.
Dec 13 2024, 3:17 PM
mollekopf requested review of D5064: Disable fetching of attachments within calendar-query.
Dec 13 2024, 3:16 PM
machniak updated the diff for D5062: Kolab4 tags support.
  • Performance: Use lighter rcube_message_header instead of rcube_message
Dec 13 2024, 2:19 PM
Spenneberg triaged T8410: Almalinux Repo broken as High priority.
Dec 13 2024, 1:52 PM
Spenneberg created T8410: Almalinux Repo broken.
Dec 13 2024, 1:50 PM
mollekopf committed rI4b67b8c6ba44: PHP8 compat.
Dec 13 2024, 12:07 PM
mollekopf committed rIfdf1a18cb30c: Roundcube 1.6 compat.
Dec 13 2024, 12:07 PM
machniak requested changes to D5044: Warning on FolderSync synckey reuse, but then don't try to create in the backend.

Adding methods to backend interface implementation requires some more code. Phpstan says:

Line   lib/ext/Syncroton/Command/FolderSync.php                          
------ ------------------------------------------------------------------ 
 295    Call to an undefined method Syncroton_Backend_IFolder::exists().
Dec 13 2024, 10:27 AM
machniak requested review of D5062: Kolab4 tags support.
Dec 13 2024, 10:07 AM
machniak closed D5060: Tests: Various fixes.
Dec 13 2024, 10:00 AM
machniak committed rS3c23e5ae0414: Tests: Various fixes.
Dec 13 2024, 10:00 AM
mollekopf accepted D5060: Tests: Various fixes.
Dec 13 2024, 9:55 AM
machniak requested review of D5060: Tests: Various fixes.
Dec 13 2024, 9:49 AM

Dec 12 2024

machniak updated the summary of D5032: Kolab Tags SQL and ANNOTATE drivers.
Dec 12 2024, 12:50 PM
machniak updated the diff for D5032: Kolab Tags SQL and ANNOTATE drivers.
  • Fixes regarding syncroton API for tags
Dec 12 2024, 12:44 PM

Dec 11 2024

machniak updated the diff for D5032: Kolab Tags SQL and ANNOTATE drivers.
  • Small doc fix
Dec 11 2024, 2:20 PM
machniak retitled D5032: Kolab Tags SQL and ANNOTATE drivers from Kolab Tags SQL Database Driver
Dec 11 2024, 2:13 PM
machniak updated the diff for D5032: Kolab Tags SQL and ANNOTATE drivers.
  • CS fixes
  • ANNOTATE driver
  • Improvements
  • SQL driver fixes
Dec 11 2024, 2:12 PM
machniak committed rK16f50556c653: Fix localization for chargeback transactions description.
Dec 11 2024, 8:05 AM

Dec 10 2024

machniak requested changes to D5058: Always run the seeder when horizon starts.
Dec 10 2024, 2:43 PM
mollekopf planned changes to D5058: Always run the seeder when horizon starts.

TODO:

  • FIgure out if this is actually compatible with existing deployments
  • Do we have to use withEnvTenantContext in various places?
Dec 10 2024, 2:32 PM
mollekopf updated the diff for D5058: Always run the seeder when horizon starts.

Call the right command

Dec 10 2024, 2:12 PM
mollekopf updated the diff for D5058: Always run the seeder when horizon starts.

Missed something

Dec 10 2024, 2:09 PM
mollekopf added a reviewer for D5058: Always run the seeder when horizon starts: Restricted Project.
Dec 10 2024, 2:07 PM
mollekopf requested review of D5058: Always run the seeder when horizon starts.
Dec 10 2024, 2:06 PM
mollekopf abandoned D5046: Create a client for webmail sso via migration.

I suppose doing this during a migration is a bad idea because this also depends on the configuration to be available.

Dec 10 2024, 10:49 AM
mollekopf updated the diff for D5046: Create a client for webmail sso via migration.

Deduplicate the creation of the client

Dec 10 2024, 10:27 AM
mollekopf accepted D5056: WalletCheck cleanup.
Dec 10 2024, 10:08 AM
machniak requested review of D5056: WalletCheck cleanup.
Dec 10 2024, 9:48 AM
mollekopf committed rKbb7c423d2c8e: testctl improvements.
Dec 10 2024, 7:57 AM
mollekopf committed rK38a016cd34a9: User::SERVICE_ROLE for service accounts.
Dec 10 2024, 7:57 AM
mollekopf closed D5048: User::SERVICE_ROLE for service accounts.
Dec 10 2024, 7:57 AM
mollekopf closed D5052: Test the sasl auth hook.
Dec 10 2024, 7:57 AM
mollekopf committed rK4f6f41a9c889: Test the sasl auth hook.
Dec 10 2024, 7:57 AM
mollekopf committed rK864f71712765: Configure SSO client in kolabctl.
Dec 10 2024, 7:57 AM
mollekopf committed rK34feb41cf0c1: Calculate the delivery delay.
Dec 10 2024, 7:57 AM
mollekopf closed D5050: Explicitly mention that this is an automatically suspected spammer.
Dec 10 2024, 7:57 AM
mollekopf committed rK37d4eb4db122: Explicitly mention that this is an automatically suspected spammer.
Dec 10 2024, 7:56 AM
mollekopf committed rK21ec1a3cee82: Leave a 10% margin on the redis memory limit for overhead.
Dec 10 2024, 7:56 AM

Dec 9 2024

machniak accepted D5054: Error handling when querying sync-states.
Dec 9 2024, 5:40 PM
mollekopf added a reviewer for D5054: Error handling when querying sync-states: Syncroton Developers.
Dec 9 2024, 4:29 PM
mollekopf requested review of D5054: Error handling when querying sync-states.
Dec 9 2024, 4:29 PM
mollekopf updated the diff for D5052: Test the sasl auth hook.

Fix rebase error

Dec 9 2024, 1:37 PM
machniak accepted D5048: User::SERVICE_ROLE for service accounts.
Dec 9 2024, 1:35 PM
mollekopf updated the diff for D5052: Test the sasl auth hook.

Don't create the user, test the supposedly existing one instead

Dec 9 2024, 1:34 PM
machniak accepted D5050: Explicitly mention that this is an automatically suspected spammer.
Dec 9 2024, 1:06 PM
mollekopf updated the diff for D5048: User::SERVICE_ROLE for service accounts.

Addressed comments

Dec 9 2024, 12:48 PM
mollekopf added a comment to D5046: Create a client for webmail sso via migration.

BTW, none of the other registered passport clients are added via the migration. Maybe they should too. However, as all of them depend on existing-in-config client secrets and Ids, I'm still not sure migration is the correct place. Maybe we should have something like a "global seeder".

Dec 9 2024, 12:37 PM
machniak requested changes to D5052: Test the sasl auth hook.
Dec 9 2024, 12:17 PM
machniak requested changes to D5048: User::SERVICE_ROLE for service accounts.
Dec 9 2024, 12:10 PM
mollekopf added a reviewer for D5048: User::SERVICE_ROLE for service accounts: Restricted Project.
Dec 9 2024, 11:14 AM
machniak added a comment to D5046: Create a client for webmail sso via migration.

BTW, none of the other registered passport clients are added via the migration. Maybe they should too. However, as all of them depend on existing-in-config client secrets and Ids, I'm still not sure migration is the correct place. Maybe we should have something like a "global seeder".

Dec 9 2024, 11:05 AM
mollekopf added a reviewer for D5050: Explicitly mention that this is an automatically suspected spammer: Restricted Project.
Dec 9 2024, 11:00 AM
mollekopf added a reviewer for D5052: Test the sasl auth hook: Restricted Project.
Dec 9 2024, 10:59 AM
mollekopf requested review of D5050: Explicitly mention that this is an automatically suspected spammer.
Dec 9 2024, 10:58 AM
mollekopf requested review of D5052: Test the sasl auth hook.
Dec 9 2024, 10:58 AM
mollekopf updated the diff for D5046: Create a client for webmail sso via migration.

Check for existence first

Dec 9 2024, 10:58 AM
mollekopf requested review of D5048: User::SERVICE_ROLE for service accounts.
Dec 9 2024, 10:57 AM

Dec 5 2024

machniak requested changes to D5046: Create a client for webmail sso via migration.

We call the seeder after migration, so the seeder will fail because the record already exists.

Dec 5 2024, 2:03 PM
mollekopf added a reviewer for D5046: Create a client for webmail sso via migration: Restricted Project.

We should probably contemplate a standard mechanism for cases like this, so we don't copy paste these definitions around.

Dec 5 2024, 1:10 PM
mollekopf updated the diff for D5046: Create a client for webmail sso via migration.

move the migration to the environment specific overlay

Dec 5 2024, 11:57 AM
mollekopf requested review of D5046: Create a client for webmail sso via migration.
Dec 5 2024, 11:53 AM

Dec 4 2024

mollekopf committed rK51858db0e9b1: Make amavis aware of local domains via sql query.
Dec 4 2024, 10:56 AM
mollekopf committed rK4f9fc365df77: Entirely bypass virus checks without clamav.
Dec 4 2024, 10:56 AM
mollekopf committed rKda62f4b69114: Start OAUTH login when loading the roundcube login page.
Dec 4 2024, 10:56 AM
mollekopf committed rKa573bd1fb89e: Enable SQL_DEBUG.
Dec 4 2024, 10:56 AM
mollekopf committed rK1c01a437061c: function to regenerate certs.
Dec 4 2024, 10:56 AM
mollekopf committed rK2f13b7a07c49: Check dkim alignment on mailtransporttest.
Dec 4 2024, 10:56 AM
mollekopf committed rK40658e893f9b: SSO via oauth.
Dec 4 2024, 10:56 AM
mollekopf committed rKfa1007e45467: Switch to roundcube 1.6.
Dec 4 2024, 10:56 AM
mollekopf committed rK3d03520e1856: Regen expired certs.
Dec 4 2024, 10:56 AM
mollekopf committed rK1a16fba1ecc0: amavis reload script.
Dec 4 2024, 10:56 AM
mollekopf committed rK781dccf7675b: Amavis: Sign all mail with the same key for dkim alignment.
Dec 4 2024, 10:56 AM
mollekopf committed rK92a7898562b9: Validate mta-sts.
Dec 4 2024, 10:56 AM
mollekopf committed R113:09efc2c9921f: Log exceptions to stdout also with the logfmt driver.
Dec 4 2024, 9:14 AM
mollekopf committed R113:909e712b1b91: Avoid reparenting special folders..
Dec 4 2024, 9:14 AM
mollekopf committed R113:4da3c307d028: Support configuring the oauth redirect uri.
Dec 4 2024, 9:14 AM
mollekopf committed R113:20d8342e944d: logfmt stdout logger.
Dec 4 2024, 9:14 AM
mollekopf committed R113:d59be8f2cb5a: Add a backtrace when an exception is raised so we know where it.
Dec 4 2024, 9:14 AM
mollekopf committed R113:4ccd865510e5: per_user_logging for stdout logging.
Dec 4 2024, 9:14 AM
mollekopf committed R113:1be55aa8cd8c: php8 compat.
Dec 4 2024, 9:14 AM
mollekopf committed R113:5a8f7aef8d7d: Also print an error on E_COMPILE_ERROR.
Dec 4 2024, 9:14 AM
mollekopf committed R113:b9ec8fc01794: php8 warning.
Dec 4 2024, 9:14 AM
mollekopf committed R113:6488348fc63a: php8 compat.
Dec 4 2024, 9:14 AM
mollekopf committed R113:aa5992af1270: Do not log deprecation messages no production systems.
Dec 4 2024, 9:14 AM
mollekopf committed R113:f83f5c99edc4: Optimize fetchPartBody() for huge results w/o formatting and decoding (authored by machniak).
Dec 4 2024, 9:14 AM
mollekopf committed R113:b532fa8013f1: Don't log an imap authentication error when log_logins=true (authored by machniak).
Dec 4 2024, 9:14 AM