Paths

Table of Contentst

Differential D5048

User::SERVICE_ROLE for service accounts
ClosedPublic
Actions

Authored by mollekopf on Dec 9 2024, 10:57 AM.

Project Tags

None

Referenced Files

None

Subscribers

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rK38a016cd34a9: User::SERVICE_ROLE for service accounts

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

mollekopf requested review of this revision.Dec 9 2024, 10:57 AM

mollekopf created this revision.

Harbormaster completed remote builds in B52382: Diff 14448.Dec 9 2024, 10:57 AM

mollekopf added a reviewer: Restricted Project.Dec 9 2024, 11:14 AM

machniak requested changes to this revision.Dec 9 2024, 12:10 PM

machniak subscribed.

machniak added inline comments.

src/app/Console/Commands/User/SetRoleCommand.php
40–41	I'd remove this check as we have `User::setRoleAttribute()`.
src/app/Observers/UserObserver.php
122	I'd move it up, removeRelatedObjects() does not make much sense for a service account.
src/tests/Feature/Controller/AuthTest.php
212	We should test what happens with a valid password.

This revision now requires changes to proceed.Dec 9 2024, 12:10 PM

Addressed comments

Harbormaster completed remote builds in B52390: Diff 14456.Dec 9 2024, 12:48 PM

machniak accepted this revision.Dec 9 2024, 1:35 PM

machniak added inline comments.

src/tests/Feature/Controller/AuthTest.php
208	getTestUser() has a useful 2nd argument for user properties.

This revision is now accepted and ready to land.Dec 9 2024, 1:35 PM

Closed by commit rK38a016cd34a9: User::SERVICE_ROLE for service accounts. · Explain WhyDec 10 2024, 7:57 AM

This revision was automatically updated to reflect the committed changes.

mollekopf added a commit: rK38a016cd34a9: User::SERVICE_ROLE for service accounts.

Revision Contents
Changeset List

Path

Size

config.prod/

src/

database/

seeds/

ImapAdminSeeder.php

lines

src/

app/

Console/

Commands/

User/

CreateCommand.php

lines

ResyncCommand.php

lines

SetRoleCommand.php

lines

Http/

Controllers/

API/

AuthController.php

lines

Jobs/

User/

lines

Observers/

UserObserver.php

lines

lines

tests/

Feature/

Controller/

lines

Diff 14468

config.prod/src/database/seeds/ImapAdminSeeder.php

Loading...

src/app/Console/Commands/User/CreateCommand.php

Loading...

src/app/Console/Commands/User/ResyncCommand.php

Loading...

src/app/Console/Commands/User/SetRoleCommand.php

Loading...

src/app/Http/Controllers/API/AuthController.php

Loading...

src/app/Jobs/User/CreateJob.php

Loading...

src/app/Observers/UserObserver.php

Loading...

src/app/User.php

Loading...

src/tests/Feature/Controller/AuthTest.php

Loading...