Page MenuHomePhorge

Disable fetching of attachments within calendar-query
AbandonedPublic

Authored by mollekopf on Dec 13 2024, 4:16 PM.
Tags
None
Referenced Files
F18247282: D5064.id.diff
Fri, Jan 24, 8:48 PM
Unknown Object (File)
Thu, Jan 23, 1:56 PM
Unknown Object (File)
Sat, Jan 4, 2:07 PM
Unknown Object (File)
Sat, Jan 4, 6:25 AM
Unknown Object (File)
Sat, Jan 4, 6:25 AM
Unknown Object (File)
Sat, Jan 4, 6:13 AM
Unknown Object (File)
Fri, Jan 3, 5:18 PM
Unknown Object (File)
Wed, Jan 1, 2:54 PM
Subscribers

Details

Reviewers
None
Group Reviewers
iRony Developers
Summary

With large-result sets we go OOM.
Ideally we should respect the requested properties,
but they are not exposed by Sabre DAV.

It's unclear whether there are clients that rely on fetching attachments
via calendar-query, but since there is no paging, it will in any case
fail for large enough collections.

Potential alternatives to this approach:

  • Only disable fetching of attachments beyond a certain number of hits
  • Fix the memory consumption instead. In principle we shouldn't be holding all objects in memory if we only return certain properties, but this may be a sabre issue.
  • Find a way to detect which properties are requested, and only disable fetching of attachments if we don't need it to fullfill the request.

Diff Detail

Repository
rI iRony
Branch
master
Lint
Lint Skipped
Unit
No Test Coverage
Build Status
Buildable 52442
Build 18604: arc lint + arc unit

Event Timeline

mollekopf created this revision.

The client could send some HTTP header, e.g. X-Skip-Attachments: true. Since we control both sides this seems to be the best idea to me. From what I see the client could also advertise itself as "User-Agent: Lightning/1".