Otherwise we trigger duplicate insert warnings
Details
Details
- Reviewers
machniak - Group Reviewers
Syncroton Developers - Commits
- rSbda85c97af5a: Warning on FolderSync synckey reuse, but then don't try to create in the backend
Diff Detail
Diff Detail
- Repository
- rS syncroton
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
Comment Actions
Adding methods to backend interface implementation requires some more code. Phpstan says:
Line lib/ext/Syncroton/Command/FolderSync.php ------ ------------------------------------------------------------------ 295 Call to an undefined method Syncroton_Backend_IFolder::exists().
| lib/ext/Syncroton/Command/FolderSync.php | ||
|---|---|---|
| 74 | Lets make it protected for consistency. | |
| 106 | The message should say that the provided synckey is not the most recent one. | |
| lib/kolab_sync_backend_folder.php | ||
| 120 | SELECT 1 ... would be better. | |
| lib/ext/Syncroton/Command/FolderSync.php | ||
|---|---|---|
| 106 | This is the same message as for the same case in Sync.php, and it already says (to me) that it is not the most recent one, feel free to reword it to something that makes sense to you. | |