Differential D5032

Kolab Tags SQL and ANNOTATE drivers
Needs ReviewPublic
Actions

Authored by machniak on Fri, Nov 22, 10:45 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sun, Dec 1, 1:15 PM

	Unknown Object (File)
	Fri, Nov 29, 9:39 PM

	Unknown Object (File)
	Fri, Nov 29, 3:19 PM

	Unknown Object (File)
	Fri, Nov 29, 1:58 AM

	Unknown Object (File)
	Thu, Nov 28, 10:04 PM

	Unknown Object (File)
	Thu, Nov 28, 2:21 AM

	Unknown Object (File)
	Thu, Nov 28, 12:28 AM

	Unknown Object (File)
	Wed, Nov 27, 7:24 AM

View All 10 Files

Subscribers

Roundcube Kolab Plugins Developers

Details

Reviewers

None

Group Reviewers

Roundcube Kolab Plugins Developers

Summary

The implementation in the SQL driver sub-optimal as it uses the same member format and internal API as the Kolab driver.
We might need to improve this.

Requires https://github.com/roundcube/roundcubemail/commit/b206cbc87a2f766dfc8150a4fdf29531e0782e27

Diff Detail

Repository

rRPK roundcubemail-plugins-kolab

Branch

dev/kolab-tags-db-driver

Lint

Lint Skipped

Unit

No Test Coverage

Build Status

Buildable 52426
Build 18594: arc lint + arc unit

Event Timeline

machniak requested review of this revision.Fri, Nov 22, 10:45 AM

machniak created this revision.

Harbormaster completed remote builds in B52214: Diff 14406.Fri, Nov 22, 10:45 AM

Regarding syncrotons needs:

I think we need to get away from the timestamp comparisons and instead store whatever we need to as part of the synchronization state (tied to the synckey)
Ideally we find something better to store than all entries in a folder that are part of the tag, or at least a more efficient representation than huge urls.

CS fixes
ANNOTATE driver
Improvements
SQL driver fixes

Harbormaster completed remote builds in B52424: Diff 14480.Wed, Dec 11, 3:12 PM

machniak retitled this revision from Kolab Tags SQL Database Driver to Kolab Tags SQL and ANNOTATE drivers.Wed, Dec 11, 3:13 PM

machniak edited the summary of this revision. (Show Details)

Small doc fix

Harbormaster completed remote builds in B52426: Diff 14482.Wed, Dec 11, 3:20 PM

Revision Contents
Changeset List

Path

Size

plugins/

kolab_tags/

71 lines

2 lines

config.inc.php.dist

4 lines

drivers/

DriverInterface.php

102 lines

annotate/

196 lines

database/

399 lines

SQL/

mysql.initial.sql

27 lines

kolab/

273 lines

2 lines

14 lines

lib/

kolab_tags_backend.php

kolab_tags_engine.php

253 lines

skins/

elastic/

templates/

4 lines

libkolab/

lib/

kolab_storage_cache.php

22 lines

kolab_storage_cache_configuration.php

4 lines

kolab_storage_config.php

6 lines

kolab_storage_dav_cache.php

4 lines

kolab_storage_tags.php

466 lines

Diff 14482

plugins/kolab_tags/README

Loading...

plugins/kolab_tags/composer.json

Loading...

plugins/kolab_tags/config.inc.php.dist

Loading...

plugins/kolab_tags/drivers/DriverInterface.php

Loading...

plugins/kolab_tags/drivers/annotate/Driver.php

Loading...

plugins/kolab_tags/drivers/database/Driver.php

Loading...

plugins/kolab_tags/drivers/database/SQL/mysql.initial.sql

Loading...

plugins/kolab_tags/drivers/kolab/Driver.php

Loading...

plugins/kolab_tags/kolab_tags.js

Loading...

plugins/kolab_tags/kolab_tags.php

Loading...

plugins/kolab_tags/lib/kolab_tags_backend.php

Loading...

plugins/kolab_tags/lib/kolab_tags_engine.php

Loading...

plugins/kolab_tags/skins/elastic/templates/ui.html

Loading...

plugins/libkolab/lib/kolab_storage_cache.php

Loading...

plugins/libkolab/lib/kolab_storage_cache_configuration.php

Loading...

plugins/libkolab/lib/kolab_storage_config.php

Loading...

plugins/libkolab/lib/kolab_storage_dav_cache.php

Loading...

plugins/libkolab/lib/kolab_storage_tags.php

Loading...