Project Tags

None

Referenced Files

	F117774102: D5032.1775240542.diff
	Thu, Apr 2, 6:22 PM

Subscribers

mollekopf

Roundcube Kolab Plugins Developers

Details

Reviewers

mollekopf

Group Reviewers

Roundcube Kolab Plugins Developers

Commits

rRPK21ead0149e85: Kolab Tags SQL and ANNOTATE drivers
rRPKbe4865053273: Kolab Tags SQL and ANNOTATE drivers
rRPKabbb3921e172: Kolab Tags SQL and ANNOTATE drivers

Summary

The implementation in the SQL driver sub-optimal as it uses the same member format and internal API as the Kolab driver.
We might need to improve this.

Requires https://github.com/roundcube/roundcubemail/commit/b206cbc87a2f766dfc8150a4fdf29531e0782e27 and https://github.com/roundcube/roundcubemail/commit/a34f7160511e87bff64254fbafb7d10de8e0f59d

Diff Detail

Repository

rRPK roundcubemail-plugins-kolab

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

machniak requested review of this revision.Nov 22 2024, 9:45 AM

machniak created this revision.

Harbormaster completed remote builds in B52214: Diff 14406.Nov 22 2024, 9:45 AM

Regarding syncrotons needs:

I think we need to get away from the timestamp comparisons and instead store whatever we need to as part of the synchronization state (tied to the synckey)
Ideally we find something better to store than all entries in a folder that are part of the tag, or at least a more efficient representation than huge urls.

CS fixes
ANNOTATE driver
Improvements
SQL driver fixes

Harbormaster completed remote builds in B52424: Diff 14480.Dec 11 2024, 2:12 PM

machniak retitled this revision from Kolab Tags SQL Database Driver to Kolab Tags SQL and ANNOTATE drivers.Dec 11 2024, 2:13 PM

machniak edited the summary of this revision. (Show Details)

Small doc fix

Harbormaster completed remote builds in B52426: Diff 14482.Dec 11 2024, 2:20 PM

Fixes regarding syncroton API for tags

Harbormaster completed remote builds in B52428: Diff 14484.Dec 12 2024, 12:44 PM

machniak edited the summary of this revision. (Show Details)Dec 12 2024, 12:50 PM

Support saving task tags as categories

Harbormaster completed remote builds in B52474: Diff 14510.Dec 18 2024, 1:32 PM

Fix regression

Harbormaster completed remote builds in B52492: Diff 14520.Dec 23 2024, 12:44 PM

This revision was not accepted when it landed; it landed in state Needs Review.Dec 24 2024, 6:58 AM

Closed by commit rRPKabbb3921e172: Kolab Tags SQL and ANNOTATE drivers. · Explain Why

This revision was automatically updated to reflect the committed changes.

mollekopf added a commit: rRPKabbb3921e172: Kolab Tags SQL and ANNOTATE drivers.

mollekopf added a commit: rRPKbe4865053273: Kolab Tags SQL and ANNOTATE drivers.

mollekopf reopened this revision.Dec 24 2024, 7:06 AM

mollekopf added inline comments.

plugins/kolab_tags/lib/kolab_tags_engine.php
367	We used to pass an array of folders a now we just pass one folder?

mollekopf requested changes to this revision.Dec 24 2024, 7:12 AM

mollekopf added inline comments.

plugins/kolab_tags/drivers/database/Driver.php
190	The foreach loop takes care of the empty result set, no need for a special case I think.
plugins/kolab_tags/drivers/kolab/Driver.php
90	$list ?? null; (I ran into this)
133	this should be empty($uids), but the foreach is enough so the entire if can be removed. (This is what broke showing emails by tag)
214	- $tag['members'] = array_unique(array_merge((array) $tag['members'], $members)); + $tag['members'] = array_unique(array_merge((array)($tag['members'] ?? []), $members));
plugins/kolab_tags/lib/kolab_tags_engine.php
177	- if ($_POST['_from'] != 'show') { + if (($_POST['_from'] ?? null) != 'show') {
367	So maybe: - $args['result'] = new $class(array_first($folders) ?: 'INBOX', $result); + $args['result'] = new $class($args['folder'] ?? 'INBOX', $result);

This revision now requires changes to proceed.Dec 24 2024, 7:12 AM

CS fixes
Revert unneded change
ANNOTATE base tag driver
Improvements
SQL driver fixes
Small doc fix
Fixes regarding syncroton API for tags
Support saving task tags as categories
Fix regression
Regressions and cleanup

Harbormaster completed remote builds in B52508: Diff 14528.Dec 24 2024, 7:50 AM

This revision was not accepted when it landed; it landed in state Needs Review.Dec 24 2024, 10:00 AM

Closed by commit rRPK21ead0149e85: Kolab Tags SQL and ANNOTATE drivers. · Explain Why

This revision was automatically updated to reflect the committed changes.

machniak added a commit: rRPK21ead0149e85: Kolab Tags SQL and ANNOTATE drivers.

Kolab Tags SQL and ANNOTATE drivers
ClosedPublic
Actions

Details

Diff Detail

Event Timeline

Revision Contents
Changeset List

Diff 14532

plugins/kolab_tags/README

plugins/kolab_tags/composer.json

plugins/kolab_tags/config.inc.php.dist

plugins/kolab_tags/drivers/DriverInterface.php

plugins/kolab_tags/drivers/annotate/Driver.php

plugins/kolab_tags/drivers/database/Driver.php

plugins/kolab_tags/drivers/database/SQL/mysql.initial.sql

plugins/kolab_tags/drivers/kolab/Driver.php

plugins/kolab_tags/kolab_tags.js

plugins/kolab_tags/kolab_tags.php

plugins/kolab_tags/lib/kolab_tags_backend.php

plugins/kolab_tags/lib/kolab_tags_engine.php

plugins/kolab_tags/skins/elastic/templates/ui.html

plugins/libcalendaring/tests/VcalendarTest.php

plugins/libcalendaring/tests/resources/itip.ics

plugins/libkolab/lib/kolab_storage_cache.php

plugins/libkolab/lib/kolab_storage_cache_configuration.php

plugins/libkolab/lib/kolab_storage_config.php

plugins/libkolab/lib/kolab_storage_dav_cache.php

plugins/libkolab/lib/kolab_storage_tags.php

plugins/libkolab/skins/elastic/include/kolab_tags.less

plugins/tasklist/drivers/caldav/tasklist_caldav_driver.php

Kolab Tags SQL and ANNOTATE driversClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 14532

plugins/kolab_tags/README

plugins/kolab_tags/composer.json

plugins/kolab_tags/config.inc.php.dist

plugins/kolab_tags/drivers/DriverInterface.php

plugins/kolab_tags/drivers/annotate/Driver.php

plugins/kolab_tags/drivers/database/Driver.php

plugins/kolab_tags/drivers/database/SQL/mysql.initial.sql

plugins/kolab_tags/drivers/kolab/Driver.php

plugins/kolab_tags/kolab_tags.js

plugins/kolab_tags/kolab_tags.php

plugins/kolab_tags/lib/kolab_tags_backend.php

plugins/kolab_tags/lib/kolab_tags_engine.php

plugins/kolab_tags/skins/elastic/templates/ui.html

plugins/libcalendaring/tests/VcalendarTest.php

plugins/libcalendaring/tests/resources/itip.ics

plugins/libkolab/lib/kolab_storage_cache.php

plugins/libkolab/lib/kolab_storage_cache_configuration.php

plugins/libkolab/lib/kolab_storage_config.php

plugins/libkolab/lib/kolab_storage_dav_cache.php

plugins/libkolab/lib/kolab_storage_tags.php

plugins/libkolab/skins/elastic/include/kolab_tags.less

plugins/tasklist/drivers/caldav/tasklist_caldav_driver.php

Kolab Tags SQL and ANNOTATE drivers
ClosedPublic
Actions

Revision Contents
Changeset List