Page MenuHomePhorge

Kolab4 tags support
ClosedPublic

Authored by machniak on Dec 13 2024, 11:07 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Jan 24, 1:29 AM
Unknown Object (File)
Thu, Jan 23, 5:14 PM
Unknown Object (File)
Thu, Jan 23, 2:46 PM
Unknown Object (File)
Thu, Jan 23, 9:19 AM
Unknown Object (File)
Wed, Jan 22, 3:36 PM
Unknown Object (File)
Thu, Jan 9, 3:36 PM
Unknown Object (File)
Thu, Jan 9, 2:16 PM
Unknown Object (File)
Thu, Jan 9, 12:27 PM

Details

Summary

Added support for Kolab4 tags (kolab_storage_tags)

Also make (set|get)Categories methods protected

Requires changes to kolab plugins and Roundcube core.

Test Plan

vendor/bin/phpunit

Diff Detail

Repository
rS syncroton
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

machniak created this revision.
  • Performance: Use lighter rcube_message_header instead of rcube_message
This revision is now accepted and ready to land.Dec 13 2024, 9:02 PM

I think because of the latest change, this is now required:

diff --git a/lib/kolab_sync_storage.php b/lib/kolab_sync_storage.php
index eb2c379..1dea755 100644
--- a/lib/kolab_sync_storage.php
+++ b/lib/kolab_sync_storage.php
@@ -110,7 +110,7 @@ class kolab_sync_storage
         $this->storage->set_options([
             // @TODO: there can be Roundcube plugins defining additional headers,
             // we maybe would need to add them here
-            'fetch_headers' => 'X-KOLAB-TYPE X-KOLAB-MIME-VERSION',
+            'fetch_headers' => 'X-KOLAB-TYPE X-KOLAB-MIME-VERSION MESSAGE-ID',
             'skip_deleted'  => true,
             'threading'     => false,
         ]);

Otherwise the message id is something generic like "mid:1" (from rcube_imap_generic probably).

Can be shipped after that adjustments IMO.

This revision now requires changes to proceed.Dec 24 2024, 8:02 AM
This revision was not accepted when it landed; it landed in state Needs Review.Dec 24 2024, 9:01 AM
Closed by commit rS01e090894d0a: Kolab4 tags support (authored by machniak). · Explain Why
This revision was automatically updated to reflect the committed changes.