It seems to me we should:
..
In D4839#59874, @machniak wrote:Indeed. I just noticed that the actual error wasn't an exception. It was PHP Fatal error: Uncaught Error: __clone method called on non-object in /usr/share/roundcubemail/plugins/libcalendaring/lib/libcalendaring_vcalendar.php:633, so to catch it we'd have to catch Throwable, I suppose, I'm not sure.
Still, it makes sense to not skip the entire message, but sync it as it was a normal message, ignoring the fact it has an invitation.
I suppose it would be better to just make sure that the logic in Sync.php works instead of ignoring ical errors specifically.
What I find a bit odd is that we already try to catch exceptions in Command/Sync.php on all getEntry calls, so that should already take care of it, no?
You can just push it once you looked over the migration change.
Looks good apart from the migration change (which might be fine but doesn't relate to the diff).
nice cleanup
In D4827#59694, @machniak wrote:Good progress, but I was about to work on DAV, and I already have some conflicting code. Please, don't work on DAV at this moment.
Small imap fixup, let the exporter implement the migration strategy
dav migration, separate migrators for imap/dav
This only implements migrating imap messages but highlights how the current framework doesn't cleanly facilitate not using the job per item strategy.
I think there's a cleaner approach to implementing the two strategies than what I did above, e.g. by moving the processFolder logic entirely to the exporter.
I think we can merge it and take it from there.
Maybe this would be better as a subtab in the finances tab, but it's a start.
Don't break all existing logic related to cost
Sum up charges and fees first, then limit by wallet balance.
Addressed comments
Test, cleanup
Fixed in master
I think everything besides the Docker FROM changes can be merged because it doesn't impact anything existing either way.
Cleanup
Removed print statement
To be able to validate things we now just validate first, and then create everything, and bail out if user or domain are preexisting.
There's doesn't seem to really be a point in converting existing users.
Fixed mail options
Adapt to recent changes
Fixed, sorry about the downtime.
it's not, and I'm also not sure if this really solves anything since we actually try to keep the balance around 10 CHF (I think?). Maybe the better solution would be to just prominently display a warning that the user is being rate limited.