Page MenuHomePhorge
Feed Search

May 19 2023

machniak committed rK1b35cc8cf897: CS fix.
May 19 2023, 8:18 AM
machniak requested review of D4316: Add --filter option to list commands, with a few predefined filters.
May 19 2023, 7:07 AM

May 18 2023

machniak updated the summary of D4310: Add option to disable access to subscriptions (APP_WITH_SUBSCRIPTIONS).
May 18 2023, 1:00 PM
machniak requested review of D4310: Add option to disable access to subscriptions (APP_WITH_SUBSCRIPTIONS).
May 18 2023, 12:59 PM

May 17 2023

machniak committed rKe9812d6766c4: Fix PHPCS issues.
May 17 2023, 12:32 PM
machniak updated the diff for D4304: Merge user info and profile pages.
  • Fix (and test) changing password via My account
May 17 2023, 12:10 PM
machniak updated the summary of D4304: Merge user info and profile pages.
May 17 2023, 11:36 AM
machniak requested review of D4304: Merge user info and profile pages.
May 17 2023, 11:35 AM

May 12 2023

machniak committed rK1855da1a91a1: De-duplicate common payment checkout code.
May 12 2023, 12:41 PM
machniak committed rK15043625794c: Improve signup for a free (vip) account in mandate mode.
May 12 2023, 12:41 PM
machniak closed D4298: Improve signup for a free (vip) account in mandate mode.
May 12 2023, 12:41 PM
machniak committed rS41810fc98258: Fix handling event exceptions with moved date/time in client-to-server direction.
May 12 2023, 11:47 AM
machniak added a member for Web Administration Panel Developers: mollekopf.
May 12 2023, 10:51 AM
machniak committed rSf7e121fef187: Fix event organizer change on event exceptions.
May 12 2023, 10:27 AM
machniak committed rSfd5afe660b6a: "Continue" inside switch() can be confusing.
May 12 2023, 7:28 AM
machniak committed rS321964e7f5ec: Allow MeetingResponse on an event where the acting user is not listed as….
May 12 2023, 7:28 AM

May 11 2023

machniak committed rS6c037c828b34: Small code fix.
May 11 2023, 4:49 PM
machniak committed rRPK84084ff3ab69: Prevent error when using nextcloud_link plugin in CLI.
May 11 2023, 12:46 PM

May 10 2023

machniak committed rRPK8d688a41896a: Fix email address case-sensitivity in a few places.
May 10 2023, 1:21 PM

May 9 2023

machniak added a comment to rSde753265649d: New wbxml encoder.

Nice work with the encoder changes. Instead of these base64 blobs in tests it probably would be better to use the decoder and assert DOMDocument content.

May 9 2023, 2:15 PM
machniak added inline comments to rS8bf48c3dde17: Handle resent Sync commands without resetting the sync state.
May 9 2023, 12:26 PM

May 5 2023

machniak committed rKa64da982c4a7: Fix test regression.
May 5 2023, 12:41 PM
machniak committed rKe809c34e2e19: Fix test.
May 5 2023, 12:14 PM
machniak committed rK5c80cf482eb8: Fix test regressions.
May 5 2023, 11:48 AM
machniak committed rKdc38cbfaecca: Fix linting warning.
May 5 2023, 11:25 AM
machniak committed rK312de2dfdb6a: Drop use of X-TEST-PAYMENT-PROVIDER in tests.
May 5 2023, 11:25 AM
machniak committed rRPK0bbc11858a29: By default subscribe to new non-mail folders.
May 5 2023, 6:55 AM

May 4 2023

machniak committed rWAPc5d26dadf552: Disable cookies for the API controller.
May 4 2023, 11:12 AM

May 3 2023

machniak committed rRPKf70c6d3508db: Fix cache issue with handling more than 500 records.
May 3 2023, 8:39 AM

May 1 2023

machniak committed rRPK68eaf60aca34: Fix moving objects between DAV folders.
May 1 2023, 10:16 AM

Apr 28 2023

machniak requested review of D4298: Improve signup for a free (vip) account in mandate mode.
Apr 28 2023, 1:47 PM
machniak committed rPNL5fa488031761: Fix ldapsearch.
Apr 28 2023, 12:37 PM
machniak added a comment to T7276: kolab-plugins calendar/taskutil caldav driver is not connecting to radicale.

I really tested the drivers only with Cyrus/Kolab DAV servers, so it might indeed not work with others, but I don't fully understand where's the problem. Could you provide the full dav.log (with dav_debug=true in config) from the unmodified code?

Apr 28 2023, 9:34 AM · Roundcube Kolab Plugins , Bug Reports
machniak added a comment to T7282: kolab-plugins - libkolab connecting to radicale gives 'Data too long for column ctag'.

The standards do not define max length, but I think we can set it to 128.

Apr 28 2023, 9:26 AM · Roundcube Kolab Plugins , Bug Reports
machniak committed rRPK000cfa43b5f5: Fix syntax of SQL queries for the caldav driver in Calendar.
Apr 28 2023, 8:47 AM

Apr 27 2023

machniak added a member for Net_LDAP3 Developers: mollekopf.
Apr 27 2023, 10:38 AM
machniak requested changes to D4289: Actually set the host and not the uri.

I learned recently that something like ldapi:/// exists (https://github.com/roundcube/roundcubemail/issues/8990). I suppose this will break it.

Apr 27 2023, 6:49 AM

Apr 26 2023

machniak accepted D4283: Support for ldapsearch 2.4.
Apr 26 2023, 5:18 PM · Restricted Project
machniak accepted D4292: Always include the port in the host..
Apr 26 2023, 5:16 PM
machniak committed rWAPa564c883e063: Fix links in About page(s).
Apr 26 2023, 9:57 AM
machniak committed rWAP9bb0cf3e62ab: Add ability to see and reset passwordRetryCount attribute.
Apr 26 2023, 9:14 AM

Apr 24 2023

machniak committed rKff4e3942675a: Fix/ignore phpstan errors.
Apr 24 2023, 9:53 AM

Apr 21 2023

machniak committed rK42d8f023ecb5: Fix group synchronization to LDAP.
Apr 21 2023, 12:45 PM
machniak closed D4277: Fix group synchronization to LDAP.
Apr 21 2023, 12:45 PM
machniak requested review of D4277: Fix group synchronization to LDAP.
Apr 21 2023, 11:23 AM
machniak committed rS97df7783ff70: Fix parse error in Syncroton_Exception_Status_Settings.
Apr 21 2023, 6:23 AM

Apr 19 2023

machniak added a comment to T7133: Unable to send mail via web interface after roundcube update.

It might be caused by outdated Net_SMTP package in the system (or in Roundcube's /vendor folder). At least version 1.10.0 is required.

Apr 19 2023, 4:38 PM · Kolab 16, Bug Reports
machniak accepted D4271: Deal with invalid timezone information that is sent by outlook.
Apr 19 2023, 2:03 PM
machniak committed rRPK74079820c754: Fix PHP8 warnings.
Apr 19 2023, 1:25 PM
machniak committed rS28ea3dcbfa98: Fix undefined property warnings.
Apr 19 2023, 11:32 AM
machniak committed rS81eba82af43e: PHP8 compat. fixes.
Apr 19 2023, 10:15 AM
machniak committed rS3e3a1e2a666d: Support PHPUnit v9.
Apr 19 2023, 9:48 AM

Apr 18 2023

machniak committed rKa657c85c7c96: Fix plan/package cost calculation.
Apr 18 2023, 1:24 PM
machniak closed D4253: Fix plan/package cost calculation.
Apr 18 2023, 1:24 PM
machniak accepted D4265: Fixed timezone conversion with changing timezones.

We should be fine without cache. I think it was invented for slower PHP5.

Apr 18 2023, 6:13 AM

Apr 17 2023

machniak added inline comments to D4190: Collection support for filesystem items.
Apr 17 2023, 9:17 AM

Apr 14 2023

machniak committed rK2022a6c28952: English grammar fix.
Apr 14 2023, 10:45 AM
machniak committed rKb175bde21820: Resync button.
Apr 14 2023, 10:45 AM
machniak closed D4241: Resync button.
Apr 14 2023, 10:45 AM
machniak committed rKce239cd37129: Simplify code with saveQuietly().
Apr 14 2023, 10:45 AM
machniak closed D4247: Simplify code with saveQuietly().
Apr 14 2023, 10:45 AM
machniak requested changes to D4190: Collection support for filesystem items.
Apr 14 2023, 9:55 AM

Apr 13 2023

machniak committed rK7c7ecf07dbfc: Minimize race-condition on wallet balance update.
Apr 13 2023, 11:47 AM
machniak closed D4259: Minimize race-condition on wallet balance update.
Apr 13 2023, 11:47 AM
machniak updated the diff for D4259: Minimize race-condition on wallet balance update.
  • Add sanity check after refresh
Apr 13 2023, 11:06 AM
machniak updated the diff for D4259: Minimize race-condition on wallet balance update.
  • Fix the race-condition in wallet:charge instead
Apr 13 2023, 10:57 AM
machniak committed rKef48e7b49a38: Continue -> Subscribe.
Apr 13 2023, 10:12 AM
machniak committed rK1fc7056acec2: Make credit card icons colorful.
Apr 13 2023, 8:16 AM

Apr 12 2023

machniak requested review of D4259: Minimize race-condition on wallet balance update.
Apr 12 2023, 1:12 PM
machniak committed rKdc4edff9692a: Remove redundant space.
Apr 12 2023, 11:15 AM
machniak committed rKbcb771ebac73: Make user:wallets command based on ObjectRelationListCommand class.
Apr 12 2023, 9:23 AM
machniak committed rK12669e8c679f: Fix test.
Apr 12 2023, 9:03 AM

Apr 11 2023

machniak requested review of D4253: Fix plan/package cost calculation.
Apr 11 2023, 2:04 PM
machniak requested review of D4247: Simplify code with saveQuietly().
Apr 11 2023, 12:06 PM

Apr 10 2023

machniak committed rRPK06209ca559b2: Fix PHP warnings.
Apr 10 2023, 10:52 AM

Apr 7 2023

machniak updated the diff for D4241: Resync button.
  • Merge branch 'master' into dev/resync-button
  • Use self::trans()
Apr 7 2023, 11:26 AM
machniak committed rKc777e37266c7: If only @kanarip would run linters and tests ... </sigh>.
Apr 7 2023, 11:24 AM
machniak requested review of D4241: Resync button.
Apr 7 2023, 11:07 AM

Apr 6 2023

machniak committed rK3959ec3bb0fd: Improve signup summary page for mandate mode.
Apr 6 2023, 10:38 AM

Apr 4 2023

machniak committed rK3f0c4d50ab9b: Use lowercase page name when looking for the faq entries.
Apr 4 2023, 9:42 AM
machniak committed rK4631284ca999: Support both upper and lower case in theme subpages.
Apr 4 2023, 9:36 AM

Apr 3 2023

machniak added inline comments to D4190: Collection support for filesystem items.
Apr 3 2023, 4:02 PM
machniak updated the diff for D4157: WIP: Amavis/Spamassassin Settings.
  • Merge branch 'master' into dev/spam-settings
  • Tests
Apr 3 2023, 8:29 AM

Mar 31 2023

machniak committed rK8237a13eca59: Wallet::getMinMandateAmount().
Mar 31 2023, 7:58 AM
machniak closed D4235: Wallet::getMinMandateAmount().
Mar 31 2023, 7:58 AM
machniak committed rK7fbcde301b3e: Display users with no ACTIVE flag as Not Ready, code cleanup.
Mar 31 2023, 7:58 AM
machniak closed D4223: Display users with no ACTIVE flag as Not Ready, code cleanup.
Mar 31 2023, 7:58 AM
machniak added inline comments to D4214: health/status endpoint.
Mar 31 2023, 5:53 AM

Mar 30 2023

machniak committed rK4c1f47845e4a: Add tests for ap/v4/payments/mandate/reset end-point.
Mar 30 2023, 12:52 PM
machniak committed rK6983948e71c9: Test /signup/validate.
Mar 30 2023, 12:52 PM
machniak committed rK6f39feaf5f13: Add tests for /payments/status.
Mar 30 2023, 12:52 PM
machniak requested changes to D4190: Collection support for filesystem items.
Mar 30 2023, 12:34 PM
machniak updated the diff for D4223: Display users with no ACTIVE flag as Not Ready, code cleanup.
  • Add some assertions
Mar 30 2023, 8:22 AM
machniak updated the diff for D4223: Display users with no ACTIVE flag as Not Ready, code cleanup.
  • Make domain NEW (and only NEW) on restore
Mar 30 2023, 8:17 AM
machniak added inline comments to D4223: Display users with no ACTIVE flag as Not Ready, code cleanup.
Mar 30 2023, 8:07 AM
machniak accepted D4229: Conditionally show the support form if SUPPORT_EMAIL is set..
Mar 30 2023, 6:07 AM

Mar 29 2023

machniak added a comment to D4229: Conditionally show the support form if SUPPORT_EMAIL is set..

We already have a way to set config options:

$browser->execScript(sprintf('Object.assign(window.config, %s)', \json_encode($config)));

For payment providers we have an additional mechanism that passes the setting to the backend via headers. See https://git.kolab.org/source/kolab/browse/master/src/resources/js/app.js$371 I suppose we could make it a bit more universal mechanism. See also App\Http\Middleware\DevelConfig.

Mar 29 2023, 11:28 AM
machniak committed rK383c6b6b2288: Allow upper-case letters and digits in subpage URL.
Mar 29 2023, 8:47 AM

Mar 28 2023

machniak requested review of D4235: Wallet::getMinMandateAmount().
Mar 28 2023, 9:23 AM
machniak added a comment to D4229: Conditionally show the support form if SUPPORT_EMAIL is set..

I fixed SignupTest in master, WalletTest works for me. Mollie payment tests fail because of https://github.com/mollie/mollie-api-php/issues/649 and I'm not sure what to do about it.

Mar 28 2023, 5:23 AM