Just for clarification:
I was now able to verify that that this work.
Hide the table entry and legend
String based uuid, fixed test
deduplicate sql queries, router reload
Cleanup of a bunch of accidentally added changes
Addressed the comments
Cleaned up .env files & follow symbolic links in configure.sh
Stripping all the secrets will require some additional setup-procedure to generate them, so I'm not going to do that in this patch. The situation has not actually gotten worse because I just concatenated src/env.example and ansible/env.local into ansible/env.
In D3902#47162, @mollekopf wrote:In D3902#47042, @machniak wrote:Specifically the problem might be with src/database/migrations/2022_05_13_090000_permissions_and_room_subscriptions.php. It probably should check if the SKUs already exist and not try to add them again if so. There's another problem with this migration file. It is not self-contained, i.e. it does not remove 'meet' SKU in up(), but does add it in down().
In D3902#47042, @machniak wrote:This migration thing is a mess and will be problematic in the future. I however have no better idea. We'll have to be very careful in the future. And this makes managing Kolab4 installation (and updates), if you are not Apheleia IT, very difficult.
fwiw, the same could be done for the admin/reseller domain if we wanted to.
This should resolve the following modification:
Backwards compatibility
Adjusted tests to pass again
Call IMAP::verifyAccount from the create job
Addressed 2 out of 3 comments
Deployment configs as a filesystem overlay
Optional IMAP backend, pass tests with imap backend disabled, fixed IMAP::verifyAccount.
I suppose Handler::created could be used to spawn a job, not sure if it is a good solution or not.
The abuse check now lives externally. As a generic mechanism vanmeeuwen suggested that we may be able to install an app/Handler/Abuse.php just like we do for app/Handler/Mailbox.php, and that this might provide a suitable generic hook to run an abuse-check background job.
Cleanup
Removed production seeder
Fixed production seeder
Dropped the need for an email address, fixed spacing
Required with the new docker-networking setup.
Addressed comments, added redis check.
Adjusted tests to expect the exception. All tests are passing.
Adjusted tests
yes, for activesync.
I don't think there's anything retrying if we're manually executing the job, so I stand by my proposal.