Avoid hardcoding ip's in the NGINXTest
ClosedPublic
Actions

Authored by mollekopf on Sep 29 2022, 9:36 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Fri, Sep 13, 8:42 AM

	Unknown Object (File)
	Fri, Sep 13, 8:36 AM

	Unknown Object (File)
	Sun, Sep 1, 10:17 AM

	Unknown Object (File)
	Tue, Aug 27, 1:07 PM

	Unknown Object (File)
	Sun, Aug 25, 11:33 PM

	Unknown Object (File)
	Wed, Aug 21, 6:13 PM

	Unknown Object (File)
	Wed, Aug 21, 6:03 PM

	Unknown Object (File)
	Wed, Aug 21, 11:49 AM

View All 67 Files

Subscribers

None

Details

Reviewers

None

Group Reviewers

Restricted Project

Commits

rK469fefd8cd67: Avoid hardcoding ip's in the NGINXTest

Summary

These assumptions don't work if we don't use host networking.

Diff Detail

Repository

rK kolab

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

mollekopf requested review of this revision.Sep 29 2022, 9:36 AM

mollekopf created this revision.

Harbormaster completed remote builds in B40187: Diff 10967.Sep 29 2022, 9:36 AM

Required with the new docker-networking setup.

This revision was not accepted when it landed; it landed in state Needs Review.Oct 12 2022, 3:14 PM

Closed by commit rK469fefd8cd67: Avoid hardcoding ip's in the NGINXTest (authored by mollekopf). · Explain Why

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

tests/

Feature/

Controller/

NGINXTest.php

10 lines

Diff 11108

View Options

src/tests/Feature/Controller/NGINXTest.php

Avoid hardcoding ip's in the NGINXTestClosedPublicActions