Page MenuHomekolab.org

Throw an error if we attempt to release a manually executed job.
ClosedPublic

Authored by mollekopf on Fri, Sep 9, 10:01 AM.

Diff Detail

Repository
rK kolab
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

mollekopf requested review of this revision.Fri, Sep 9, 10:01 AM
mollekopf created this revision.
mollekopf added a reviewer: Restricted Project.Fri, Sep 9, 10:02 AM
machniak requested changes to this revision.Tue, Sep 20, 12:20 PM
machniak added a subscriber: machniak.

This does not sound right. In your use-case we do release(60) which is not "failing silently" but waiting for domain to be set up and trying again.

This revision now requires changes to proceed.Tue, Sep 20, 12:20 PM

I don't think there's anything retrying if we're manually executing the job, so I stand by my proposal.

mollekopf requested review of this revision.Tue, Sep 20, 1:04 PM
machniak accepted this revision.Tue, Sep 20, 1:51 PM

Please, add an explanatory comment .

This revision is now accepted and ready to land.Tue, Sep 20, 1:51 PM
mollekopf updated this revision to Diff 10919.Tue, Sep 20, 4:36 PM

Adjusted tests to expect the exception. All tests are passing.

Closed by commit rK1fd42ef602d3: Throw an error if we attempt to release a manually executed job. (authored by Christian Mollekopf <mollekopf@apheleia-it.ch>). · Explain WhyTue, Sep 20, 5:16 PM
This revision was automatically updated to reflect the committed changes.