Page MenuHomePhorge

Throw an error if we attempt to release a manually executed job.

Authored by mollekopf on Sep 9 2022, 10:01 AM.
Referenced Files
Unknown Object (File)
Sat, Feb 24, 11:51 PM
Unknown Object (File)
Sat, Feb 24, 8:54 PM
Unknown Object (File)
Sat, Feb 17, 9:22 PM
Unknown Object (File)
Sun, Feb 4, 8:43 AM
Unknown Object (File)
Jan 24 2024, 4:58 AM
Unknown Object (File)
Jan 24 2024, 4:58 AM
Unknown Object (File)
Jan 24 2024, 3:31 AM
Unknown Object (File)
Jan 23 2024, 11:14 PM

Diff Detail

rK kolab
Lint Not Applicable
Tests Not Applicable

Event Timeline

mollekopf created this revision.
mollekopf added a reviewer: Restricted Project.Sep 9 2022, 10:02 AM
machniak subscribed.

This does not sound right. In your use-case we do release(60) which is not "failing silently" but waiting for domain to be set up and trying again.

This revision now requires changes to proceed.Sep 20 2022, 12:20 PM

I don't think there's anything retrying if we're manually executing the job, so I stand by my proposal.

Please, add an explanatory comment .

This revision is now accepted and ready to land.Sep 20 2022, 1:51 PM

Adjusted tests to expect the exception. All tests are passing.

This revision was automatically updated to reflect the committed changes.