Page MenuHomePhorge

Throw an error if we attempt to release a manually executed job.

Authored by mollekopf on Sep 9 2022, 10:01 AM.
Referenced Files
F10578463: D3821.diff
Thu, Nov 30, 1:58 AM
Unknown Object (File)
Fri, Nov 17, 2:46 PM
Unknown Object (File)
Wed, Nov 8, 2:50 PM
Unknown Object (File)
Mon, Nov 6, 1:14 PM
Unknown Object (File)
Oct 20 2023, 10:01 AM
Unknown Object (File)
Sep 27 2023, 5:00 PM
Unknown Object (File)
Sep 26 2023, 10:50 PM
Unknown Object (File)
Sep 26 2023, 10:15 PM

Diff Detail

rK kolab
Lint Not Applicable
Tests Not Applicable

Event Timeline

mollekopf created this revision.
mollekopf added a reviewer: Restricted Project.Sep 9 2022, 10:02 AM
machniak subscribed.

This does not sound right. In your use-case we do release(60) which is not "failing silently" but waiting for domain to be set up and trying again.

This revision now requires changes to proceed.Sep 20 2022, 12:20 PM

I don't think there's anything retrying if we're manually executing the job, so I stand by my proposal.

Please, add an explanatory comment .

This revision is now accepted and ready to land.Sep 20 2022, 1:51 PM

Adjusted tests to expect the exception. All tests are passing.

This revision was automatically updated to reflect the committed changes.