Page MenuHomePhorge
Differential D3821

Throw an error if we attempt to release a manually executed job.
ClosedPublic
Actions

Authored by mollekopf on Sep 9 2022, 10:01 AM.
Tags
None
Referenced Files
F11901651: D3821.diff
Thu, Apr 25, 11:02 PM
Unknown Object (File)
Sun, Apr 21, 4:59 PM
Unknown Object (File)
Sun, Apr 21, 4:59 PM
Unknown Object (File)
Sun, Apr 21, 4:59 PM
Unknown Object (File)
Sun, Apr 21, 4:58 PM
Unknown Object (File)
Sat, Apr 20, 8:56 PM
Unknown Object (File)
Wed, Apr 17, 9:42 AM
Unknown Object (File)
Sat, Apr 13, 10:55 AM
View All 44 Files
Subscribers
machniak

Details

Reviewers
machniak
Group Reviewers
Restricted Project
Commits
rK1fd42ef602d3: Throw an error if we attempt to release a manually executed job.
rK6b0c80186222: Throw an error if we attempt to release a manually executed job.
rK84e523e7a4a2: Throw an error if we attempt to release a manually executed job.
Summary

In my case the UserCreateJob silently failed because the domain was not
ready.

Diff Detail

Repository
rK kolab
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

mollekopf requested review of this revision.Sep 9 2022, 10:01 AM
mollekopf created this revision.
Harbormaster completed remote builds in B40037: Diff 10853.Sep 9 2022, 10:01 AM
mollekopf added a reviewer: Restricted Project.Sep 9 2022, 10:02 AM
machniak requested changes to this revision.Sep 20 2022, 12:20 PM
machniak subscribed.

This does not sound right. In your use-case we do release(60) which is not "failing silently" but waiting for domain to be set up and trying again.

This revision now requires changes to proceed.Sep 20 2022, 12:20 PM
mollekopf added a comment.Sep 20 2022, 1:03 PM

I don't think there's anything retrying if we're manually executing the job, so I stand by my proposal.

mollekopf requested review of this revision.Sep 20 2022, 1:04 PM
machniak accepted this revision.Sep 20 2022, 1:51 PM

Please, add an explanatory comment .

This revision is now accepted and ready to land.Sep 20 2022, 1:51 PM
mollekopf updated this revision to Diff 10919.Sep 20 2022, 4:36 PM

Adjusted tests to expect the exception. All tests are passing.

Harbormaster completed remote builds in B40148: Diff 10919.Sep 20 2022, 4:36 PM
Closed by commit rK1fd42ef602d3: Throw an error if we attempt to release a manually executed job. (authored by mollekopf). · Explain WhySep 20 2022, 5:16 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
app/
Jobs/
4 lines
tests/
Feature/
Jobs/
Domain/
1 line
Group/
1 line
Resource/
1 line
SharedFolder/
1 line
User/
1 line

Diff 10925

View Options

src/app/Jobs/CommonJob.php

Loading...
View Options

src/tests/Feature/Jobs/Domain/CreateTest.php

Loading...
View Options

src/tests/Feature/Jobs/Group/CreateTest.php

Loading...
View Options

src/tests/Feature/Jobs/Resource/CreateTest.php

Loading...
View Options

src/tests/Feature/Jobs/SharedFolder/CreateTest.php

Loading...
View Options

src/tests/Feature/Jobs/User/CreateTest.php

Loading...